Enable sending quoted replies, two fixes #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that we reload thumbnails for every message when any new message is added to the conversation. This fix prevents that by actually checking for the proper sentinel on the message model
gasi-signal
approved these changes
Apr 25, 2018
| if (view) { | ||
| view.applyTheme(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Thanks for fixing this one! Is that the one Matt found?
scottnonnenberg-signal
added a commit
that referenced
this pull request
Apr 25, 2018
Send quoted replies via hover menu on message (#2284, #2292) Fixed: Linking a new iOS device would not initially show iOS theme (#2284) Fixed: In iOS theme, narrow images would result in a broken chat bubble (#2273, #2282) Dev: - Fix beta install instructions in readme for debian-based linux (#2262) - Media Gallery: Phase 1 - currently disabled (#2236)
scottnonnenberg-signal
added a commit
that referenced
this pull request
May 1, 2018
v1.9.0-beta.1 Send quoted replies via hover menu on message (#2284, #2292) Fixed: Linking a new iOS device would not initially show iOS theme (#2284) Fixed: In iOS theme, narrow images would result in a broken chat bubble (#2273, #2282) Dev: - Fix beta install instructions in readme for debian-based linux (#2262) - Media Gallery: Phase 1 - currently disabled (#2236)
scottnonnenberg-signal
added a commit
that referenced
this pull request
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the bit of code for
v1.8.0that prevents the ability to quote messages.It also fixes two other bugs: