Don't lock the Node version so strictly #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is particularly problematic because Yarn apparently errors (not warns) if the engine doesn't match.
|
I am said friend. Seriously, it's pretty annoying that it was refusing to build because my system's Node package was too new. I understand that sometimes changing versions causes compatibility problems. That's fine - it happens. Please don't pin to a version like this and not do something to reflect that the package is updating. |
|
@strugee @RobertCochran Thanks for PR. For local development we want to have a specific version to reduce the surface area, but |
|
I run the production releases; I just filed this since I had helped @RobertCochran work around it. I believe he compiles from source because there are no Fedora packages. |
|
@strugee is correct - I build from source because neither the Fedora Project nor OWS currently packages Signal as an RPM. Because this is supposed to be a secure application, I actually care where it comes from more than I generally do. So, aside from coming from either FP or yourselves, the next best thing is to compile source. |
|
Thanks for explaining, @strugee and @RobertCochran! Would you be willing to contribute some instructions ( |
scottnonnenberg-signal
added a commit
that referenced
this pull request
Apr 5, 2018
Update to electron 1.8.4 (#2186) Migrate all attachments from IndexedDB to file system in the background (#2208, #2193, #2165, #2162, #2129) Save attachments to disk when importing Chrome app export (#2212) Fixed: Read receipts setting would not be synchronized along with re-link (#2218) Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks @colefranz! (#2032) Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (#2191) Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (#2167) Dev: - Relax Node.js version requirements (#2203) - Fix a few typos in documentation - thanks @Vinnl (#2171) - Update issue template to mention that translation should be via Transifex (#2157)
gasi
pushed a commit
to gasi/Signal-Desktop
that referenced
this pull request
Apr 6, 2018
Update to electron 1.8.4 (signalapp#2186) Migrate all attachments from IndexedDB to file system in the background (signalapp#2208, signalapp#2193, signalapp#2165, signalapp#2162, signalapp#2129) Save attachments to disk when importing Chrome app export (signalapp#2212) Fixed: Read receipts setting would not be synchronized along with re-link (signalapp#2218) Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks @colefranz! (signalapp#2032) Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (signalapp#2191) Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (signalapp#2167) Dev: - Relax Node.js version requirements (signalapp#2203) - Fix a few typos in documentation - thanks @Vinnl (signalapp#2171) - Update issue template to mention that translation should be via Transifex (signalapp#2157)
scottnonnenberg-signal
added a commit
that referenced
this pull request
Apr 11, 2018
v1.7.0-beta.3 Update to electron 1.8.4 (#2186) Migrate all attachments from IndexedDB to file system in the background (#2208, #2193, #2165, #2162, #2129) Save attachments to disk when importing Chrome app export (#2212) Fixed: Read receipts setting would not be synchronized along with re-link (#2218) Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks @colefranz! (#2032) Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (#2191) Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (#2167) Dev: - Relax Node.js version requirements (#2203) - Fix a few typos in documentation - thanks @Vinnl (#2171) - Update issue template to mention that translation should be via Transifex (#2157)
scottnonnenberg-signal
added a commit
that referenced
this pull request
Apr 11, 2018
Note: this release is equivalent to v1.7.0-beta.3. The changes listed below are compared to the previous production release, v1.6.1. Update to electron 1.8.4 (#2186) Migrate all attachments from IndexedDB to file system in the background (#2208, #2193, #2165, #2162, #2129) Save attachments to disk when importing Chrome app export (#2212) New option in settings: delete all application data (383e02e, #2144 and #2153) Remove all configuration in database when we discover we are unlinked (9acb189 and 1c6d91b) Delete everything in database when we link with a different phone number from previous link (9acb189) Windows: Delete all data on uninstall (c855597) Fixed: Read receipts setting would not be synchronized along with re-link (#2218) Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks @colefranz! (#2032) Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (#2191) Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (#2167) Dev: - Redact file paths in anything that goes to the log on disk (#2110) - When top-level process errors happen, don't show dialog with stack trace (#2110) - Add `nsp` to CI runs (fd056e1) - Add eslint-plugin-mocha to disallow exclusive tests using *.only (#2110) - Preparation for encrypted backups (cea42bd) - Updates to structure of exported data - messages.zip, flat list of attachments (6d8f4b7) - Relax Node.js version requirements (#2203) - Fix a few typos in documentation - thanks @Vinnl (#2171) - Update issue template to mention that translation should be via Transifex (#2157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
developmentbranchDescription
What the title says. This is particularly problematic because Yarn apparently errors (not warns) if the engine doesn't match; I just had a friend complain about this in a group chat.