Remove ‘Ctrl+,’ keyboard shortcut on Windows & Linux #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottnonnenberg
added a commit
that referenced
this pull request
Mar 6, 2018
Upgrade to the latest version of Electron, 1.8.2 (#2066) Replace custom notification sound with system sound (#2108) Update menus (#2078 and #2099) - A few copy changes to make things clearer - Settings now available via the File (Windows/Linux) or Signal Desktop (macOS) OS menu - Eliminate the triple-dot menu in the top-center of the screen Fix: Hitting enter after entering device name on install would not move to next screen (#2085) Dev: - Ensure consistent builds using `yarn --frozen-lockfile` (#2098) - Update code to match eslint-enforced formatting (#2077) - Upgrade to latest version of electron-builder and associated packages (#2066 and #2097)
scottnonnenberg-signal
added a commit
that referenced
this pull request
Mar 13, 2018
v1.6.0-beta.2 Upgrade to the latest version of Electron, 1.8.2 (#2066) Replace custom notification sound with system sound (#2108) Update menus (#2078 and #2099) - A few copy changes to make things clearer - Settings now available via the File (Windows/Linux) or Signal Desktop (macOS) OS menu - Eliminate the triple-dot menu in the top-center of the screen Fix: Hitting enter after entering device name on install would not move to next screen (#2085) Dev: - Ensure consistent builds using `yarn --frozen-lockfile` (#2098) - Update code to match eslint-enforced formatting (#2077) - Upgrade to latest version of electron-builder and associated packages (#2066 and #2097)
scottnonnenberg-signal
added a commit
that referenced
this pull request
Mar 13, 2018
_Note: This release is equivalent to v1.6.0-beta.2 (https://github.com/signalapp/Signal-Desktop/releases/tag/v1.6.0-beta.2)_ Upgrade to the latest version of Electron, 1.8.2 (#2066) Replace custom notification sound with system sound (#2108) Update menus (#2078 and #2099) - A few copy changes to make things clearer - Settings now available via the File (Windows/Linux) or Signal Desktop (macOS) OS menu - Eliminate the triple-dot menu in the top-center of the screen Fixed: Hitting enter after entering device name on install would not move to next screen (#2085) Dev: - Ensure consistent builds using yarn --frozen-lockfile (#2098) - Update code to match eslint-enforced formatting (#2077) - Upgrade to latest version of electron-builder and associated packages (#2066 and #2097)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed,
Ctrl+,is not idiomatic on Windows & Linux.