Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0] Merge shopinvader invoice + invoice download #407

Merged
merged 6 commits into from
Oct 28, 2019
Merged

[10.0] Merge shopinvader invoice + invoice download #407

merged 6 commits into from
Oct 28, 2019

Conversation

acsonefho
Copy link
Contributor

@acsonefho acsonefho commented Sep 18, 2019 •
edited
Loading

@codecov-io
Copy link

codecov-io commented Sep 18, 2019 •
edited
Loading

Codecov Report

Merging #407 into 10.0 will decrease coverage by 0.02%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0     #407      +/-   ##
==========================================
- Coverage   89.38%   89.36%   -0.03%     
==========================================
  Files         139      139              
  Lines        3626     3619       -7     
==========================================
- Hits         3241     3234       -7     
  Misses        385      385
Impacted Files Coverage Δ
shopinvader_invoice/services/invoice.py 96.96% <100%> (-0.54%) ⬇️
shopinvader/services/invoice.py 81.81% <66.66%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1356deb...0f46580. Read the comment docs.

@acsonefho acsonefho mentioned this pull request Sep 19, 2019
Merged
@lmignon
Copy link
Collaborator

lmignon commented Sep 20, 2019

@acsonefho #327 is merged... 🍾
If you finalize this one, I'll close #366

@lmignon
Copy link
Collaborator

lmignon commented Sep 20, 2019

@sebastienbeau Don you think that the code to download the invoice should go into shopinvader_invoice or shopinvader???????

@acsonefho acsonefho force-pushed the 10.0-shopinvader_invoice_download branch from bf16318 to 693e737 Compare September 27, 2019 07:45
simahawk
simahawk requested changes Oct 1, 2019
View reviewed changes
@simahawk
Copy link
Contributor

simahawk commented Oct 1, 2019

as @lmignon I'm not sure this thing stays in the right place...

@acsonefho acsonefho mentioned this pull request Oct 17, 2019
Merged
@simahawk
Copy link
Contributor

@sebastienbeau ping on #407 (comment)

@acsonefho acsonefho force-pushed the 10.0-shopinvader_invoice_download branch from 693e737 to e590183 Compare October 21, 2019 10:14
@acsonefho acsonefho force-pushed the 10.0-shopinvader_invoice_download branch from e590183 to 617de38 Compare October 21, 2019 10:25
@acsonefho acsonefho changed the title WIP [10.0] Merge shopinvader invoice + invoice download [10.0] Merge shopinvader invoice + invoice download Oct 21, 2019
@acsonefho
Copy link
Contributor Author

If no more remarks/idea/suggestions, is it possible to merge it?
@lmignon @simahawk
Thank you :)

lmignon
lmignon approved these changes Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since downloading an invoice is a basic functionality into e-commerce, we can keep it into this addon

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon
Copy link
Collaborator

lmignon commented Oct 28, 2019

/ocabot merge minor

shopinvader-git-bot pushed a commit that referenced this pull request Oct 28, 2019
Merge PR #407 into 10.0
b1ab394 
Signed-off-by lmignon
@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-407-by-lmignon-bump-minor, awaiting test results.

@lmignon lmignon mentioned this pull request Oct 28, 2019
Closed
77 tasks
@shopinvader-git-bot shopinvader-git-bot merged commit 0f46580 into shopinvader:10.0 Oct 28, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 4627e01. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 10.0-shopinvader_invoice_download branch October 28, 2019 16:26
lmignon added a commit to acsone/odoo-shopinvader that referenced this pull request Oct 31, 2019
@lmignon
[FIX] shopinvader_invoice: Adapt code to 12.0 after forward port of s…
2d7ae2e 
…hopinvader#407
@lmignon lmignon mentioned this pull request Oct 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@lmignon lmignon lmignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acsonefho @codecov-io @lmignon @simahawk @shopinvader-git-bot