Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] Merge shopinvader invoice + invoice download #487

Merged

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Oct 31, 2019

forward port of #407

@lmignon lmignon mentioned this pull request Oct 31, 2019
77 tasks
@codecov-io
Copy link

Codecov Report

Merging #487 into 12.0 will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0     #487      +/-   ##
==========================================
- Coverage   91.58%   91.57%   -0.02%     
==========================================
  Files         111      111              
  Lines        3127     3120       -7     
==========================================
- Hits         2864     2857       -7     
  Misses        263      263
Impacted Files Coverage Δ
shopinvader_invoice/services/invoice.py 96.96% <100%> (-0.54%) ⬇️
shopinvader/services/invoice.py 81.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 194113a...2d7ae2e. Read the comment docs.

@lmignon
Copy link
Collaborator Author

lmignon commented Oct 31, 2019

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-487-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Oct 31, 2019
Signed-off-by lmignon
@shopinvader-git-bot shopinvader-git-bot merged commit 2d7ae2e into shopinvader:12.0 Oct 31, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at c94df90. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 12.0-shopinvader_invoice_download branch October 31, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants