Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][UPD] update with shopinvader invoice payment #467

Merged
merged 3 commits into from
Mar 23, 2020
Merged

[10.0][UPD] update with shopinvader invoice payment #467

merged 3 commits into from
Mar 23, 2020

Conversation

acsonefho
Copy link
Contributor

@acsonefho acsonefho commented Oct 17, 2019 •
edited
Loading

Include #512 (invoice/get service)
Few changes to to have some inheritance points to use into invoice payment.

Fail due to missing MR (sale-workflow). Fixed into #505

@acsonefho acsonefho force-pushed the 10.0-update_with_shopinvader_invoice_payment branch 2 times, most recently from 2c721fc to ea93f56 Compare October 17, 2019 08:42
@acsonefho acsonefho mentioned this pull request Oct 17, 2019
Closed
@codecov-io
Copy link

codecov-io commented Oct 17, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (10.0@93819ce). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             10.0     #467   +/-   ##
=======================================
  Coverage        ?   60.98%           
=======================================
  Files           ?       48           
  Lines           ?     2076           
  Branches        ?        0           
=======================================
  Hits            ?     1266           
  Misses          ?      810           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93819ce...7d537b6. Read the comment docs.

@acsonefho acsonefho force-pushed the 10.0-update_with_shopinvader_invoice_payment branch from ea93f56 to 3ad891a Compare October 21, 2019 10:35
@acsonefho acsonefho changed the title WIP [10.0][UPD] update with shopinvader invoice payment [10.0][UPD] update with shopinvader invoice payment Oct 29, 2019
@acsonefho acsonefho force-pushed the 10.0-update_with_shopinvader_invoice_payment branch from 3ad891a to 4d9f393 Compare November 8, 2019 10:52
@acsonefho acsonefho force-pushed the 10.0-update_with_shopinvader_invoice_payment branch 3 times, most recently from 9b3cc40 to 0e08e21 Compare November 15, 2019 12:55
@Cedric-Pigeon Cedric-Pigeon force-pushed the 10.0-update_with_shopinvader_invoice_payment branch 2 times, most recently from fed57e2 to f873248 Compare March 20, 2020 20:48
@acsonefho
[10.0][UPD] Add the invoice/get service + add unit test about it. (+ …
09d2981 
…fix issue into unit test to check returned json)
@acsonefho
[10.0][UPD] Add the invoice/get service + add unit test about it. (+ …
44c8bd3 
…fix issue into unit test to check returned json)
@acsonefho acsonefho force-pushed the 10.0-update_with_shopinvader_invoice_payment branch from f873248 to d48a817 Compare March 23, 2020 06:44
@acsonefho acsonefho force-pushed the 10.0-update_with_shopinvader_invoice_payment branch from d48a817 to 7d537b6 Compare March 23, 2020 07:19
@Cedric-Pigeon
Copy link

/ocabot merge patch

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 10.0-ocabot-merge-pr-467-by-Cedric-Pigeon-bump-patch, awaiting test results.

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon lmignon mentioned this pull request Mar 23, 2020
Closed
77 tasks
@shopinvader-git-bot shopinvader-git-bot merged commit f3fc542 into shopinvader:10.0 Mar 23, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 81ffba7. Thanks a lot for contributing to shopinvader. ❤️

@sebastienbeau sebastienbeau mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acsonefho @codecov-io @Cedric-Pigeon @shopinvader-git-bot @lmignon @rousseldenis