Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][IMP] shopinvader: Allows to download paid invoices for confirmed sal… #366

Merged

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Aug 7, 2019

…e orders

In this change the invoices information are included into the sale order info And a new service allows to download the invoice document.

forward port from 9.0

to be merged with #327

@lmignon lmignon added this to the 10.0 milestone Aug 7, 2019
@lmignon lmignon added the WIP label Aug 7, 2019
@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #366 into 10.0 will decrease coverage by 0.06%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0     #366      +/-   ##
==========================================
- Coverage   89.38%   89.31%   -0.07%     
==========================================
  Files         136      137       +1     
  Lines        3542     3614      +72     
==========================================
+ Hits         3166     3228      +62     
- Misses        376      386      +10
Impacted Files Coverage Δ
shopinvader/services/abstract_mail.py 88.63% <ø> (-1.16%) ⬇️
shopinvader/services/service.py 77.5% <100%> (+1.5%) ⬆️
shopinvader/services/sale.py 97.61% <100%> (+0.84%) ⬆️
shopinvader/controllers/main.py 38.46% <60%> (+1.31%) ⬆️
shopinvader/services/invoice.py 81.81% <81.81%> (ø)
shopinvader/services/cart.py 87.93% <0%> (+0.12%) ⬆️
partner_contact_company/models/partner.py 79.41% <0%> (+1.47%) ⬆️
shopinvader/services/customer.py 89.47% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183a7e2...eb2e48e. Read the comment docs.

@lmignon lmignon force-pushed the 10.0-sale-invoice-downloadable branch from e04689d to a0e836b Compare August 7, 2019 09:15
@lmignon lmignon changed the title [10.0][IMP] shopinvader: Allows to download paid invoices for confirmed sal… [WIP][10.0][IMP] shopinvader: Allows to download paid invoices for confirmed sal… Sep 11, 2019
@acsonefho acsonefho force-pushed the 10.0-sale-invoice-downloadable branch 2 times, most recently from 17959b3 to a9eacfe Compare September 17, 2019 15:11
@Cedric-Pigeon
Copy link

@lmignon Could you rebase this one please? #327 is merged.

@lmignon lmignon force-pushed the 10.0-sale-invoice-downloadable branch from a9eacfe to c4738d7 Compare October 17, 2019 07:17
@lmignon
Copy link
Collaborator Author

lmignon commented Oct 17, 2019

@Cedric-Pigeon rebase done

@lmignon lmignon added 10.0 and removed needs review labels Oct 17, 2019
@lmignon lmignon force-pushed the 10.0-sale-invoice-downloadable branch from c4738d7 to eb2e48e Compare October 17, 2019 07:47
@lmignon
Copy link
Collaborator Author

lmignon commented Oct 21, 2019

/ocabot merge minor

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 10.0-ocabot-merge-pr-366-by-lmignon-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Oct 21, 2019
Signed-off-by lmignon
@lmignon lmignon changed the title [WIP][10.0][IMP] shopinvader: Allows to download paid invoices for confirmed sal… [10.0][IMP] shopinvader: Allows to download paid invoices for confirmed sal… Oct 21, 2019
@lmignon lmignon mentioned this pull request Oct 21, 2019
77 tasks
@shopinvader-git-bot shopinvader-git-bot merged commit eb2e48e into shopinvader:10.0 Oct 21, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at b3157b4. Thanks a lot for contributing to shopinvader. ❤️

@shopinvader-git-bot shopinvader-git-bot changed the title [10.0][IMP] shopinvader: Allows to download paid invoices for confirmed sal… [10.0][IMP] shopinvader: Allows to download paid invoices for confirmed sal… Oct 21, 2019
@lmignon lmignon deleted the 10.0-sale-invoice-downloadable branch October 21, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants