Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [IMP] shopinvader: Allows to download paid invoices for confirmed sale order #483

Merged

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Oct 30, 2019

foward port of #366

@lmignon lmignon mentioned this pull request Oct 30, 2019
77 tasks
@lmignon lmignon changed the title [12.0] IMP] shopinvader: Allows to download paid invoices for confirmed sale order [12.0] [IMP] shopinvader: Allows to download paid invoices for confirmed sale order Oct 30, 2019
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #483 into 12.0 will decrease coverage by 0.01%.
The diff coverage is 83.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0     #483      +/-   ##
==========================================
- Coverage   91.26%   91.25%   -0.02%     
==========================================
  Files         104      105       +1     
  Lines        2898     2973      +75     
==========================================
+ Hits         2645     2713      +68     
- Misses        253      260       +7
Impacted Files Coverage Δ
shopinvader/services/abstract_mail.py 88.63% <ø> (-1.16%) ⬇️
shopinvader/services/service.py 77.5% <100%> (+1.5%) ⬆️
shopinvader/services/sale.py 97.61% <100%> (+0.84%) ⬆️
shopinvader/controllers/main.py 92.3% <60%> (-4.84%) ⬇️
shopinvader/services/invoice.py 81.66% <81.66%> (ø)
shopinvader/models/account_invoice.py 100% <0%> (+54.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c46c00...3961592. Read the comment docs.

@lmignon
Copy link
Collaborator Author

lmignon commented Oct 30, 2019

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-483-by-lmignon-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Oct 30, 2019
Signed-off-by lmignon
@shopinvader-git-bot shopinvader-git-bot merged commit 3961592 into shopinvader:12.0 Oct 30, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 401aa1e. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 12.0-sale-invoice-downloadable branch October 30, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants