Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rmw_iceoryx to use Eclipse iceoryx Blueberry #76

Closed
4 tasks done
mossmaurice opened this issue Mar 16, 2022 · 0 comments · Fixed by #84
Closed
4 tasks done

Update rmw_iceoryx to use Eclipse iceoryx Blueberry #76

mossmaurice opened this issue Mar 16, 2022 · 0 comments · Fixed by #84
Assignees
@mossmaurice
Labels
enhancement New feature or request humble Related to ROS 2 Humble rolling Related to ROS 2 Rolling

Comments

@mossmaurice
Copy link
Collaborator

mossmaurice commented Mar 16, 2022 •
edited
Loading

Eclipse iceoryx Blueberry aka v2.0.0 was released on 2022/03/14.

Planned new features:

  • Use request/response feature for
    • rmw_create_service ✔️
    • rmw_destroy_service ✔️
    • rmw_create_client ✔️
    • rmw_destroy_client ✔️
    • rmw_take_response ✔️
    • rmw_send_response ✔️
    • rmw_send_request ✔️
    • rmw_take_request ✔️
    • rmw_service_server_is_available ✔️
  • Use ServiceDiscovery for
    • Publishers / Servers discovery ❌
    • rmw_get_service_names_and_types ✔️
    • rmw_count_publishers? ❌

Todo:

  • Change default branch to humble
  • Create release v2.0.3-humble once iceoryx release v2.0.3 was released
  • Check rmw_service_set_on_new_request_callback and rmw_client_set_on_new_response_callback Moved to Implement callback methods #88
  • Cherry-pick changes from humble to master (rolling) branch
@mossmaurice mossmaurice added enhancement New feature or request galactic Related to ROS 2 Galactic rolling Related to ROS 2 Rolling labels Mar 16, 2022
@mossmaurice mossmaurice self-assigned this Mar 16, 2022
@mossmaurice mossmaurice added humble Related to ROS 2 Humble and removed galactic Related to ROS 2 Galactic labels Mar 31, 2022
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Apr 4, 2022
@mossmaurice
ros2#76 Implement create and destroy methods for service and client
868845a 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Apr 4, 2022
@mossmaurice
Implement create and destroy methods for service and client (ros2#76)
da3672a 
Signed-off-by: Simon Hoinkis <[email protected]>
@mossmaurice mossmaurice mentioned this issue Apr 29, 2022
Closed
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Format all the things (ros2#76)
339ef04 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Update CI and docs (ros2#76)
f0842b4 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Implement create and destroy methods for service and client (ros2#76)
c9006a8 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Implement wrapper classes for client and server and add type introspe…
57b5b7f 
…ction methods accordingly (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Update Readme (ros2#76)
d73422a 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Implement 'rmw_send_request', 'rmw_take_request' and 'rmw_take_response'
287a211 
(ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Add fixed-size path for 'rmw_send_response' and 'rmw_take_response' (r…
64870a1 
…os2#76)

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Create server and client abstraction (ros2#76)
146ada8 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Fix 'is_fixed_size' for ROS 2 services (ros2#76)
7db68cb 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Properly destroy services and clients and add serialization for services
5f84993 
(ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Fix typo leading to a segfault (ros2#76)
60ea893 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Attach servers and clients to waitset (ros2#76)
998edd1 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Remove debug prints and add de-serialization to 'rmw_send_response' (r…
1d4b469 
…os2#76)

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Add missing remove-from-waitset part (ros2#76)
1911d21 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Do not send 'request_header' over user payload (ros2#76)
917da67 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Properly save the sample in 'rwm_take_request' (ros2#76)
56cc840 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Fix lost responses issue (ros2#76)
57cc79a 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Implement 'rmw_get_service_names_and_types' (ros2#76)
ce02908 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Format all the things (ros2#76)
eebf11b 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Update CI and docs (ros2#76)
577ddce 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Add copyright notice to all touched files (ros2#76)
007d264 
Signed-off-by: Simon Hoinkis <[email protected]>
@mossmaurice mossmaurice mentioned this issue Jan 5, 2023
Merged
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Fix cpplint warnings (ros2#76)
e8e4071 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Fix cpplint warnings (ros2#76)
fca0340 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Update Ubuntu version to be able to build for humble (ros2#76)
de11e0e 
Signed-off-by: Simon Hoinkis <[email protected]>
@mossmaurice mossmaurice linked a pull request Jan 5, 2023 that will close this issue
Use new Blueberry v2.0.3 feature request-response and its discovery #84
Merged
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Add copyright notice to all touched files (ros2#76)
3777744 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Fix cpplint warnings (ros2#76)
305b28a 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Update Ubuntu version to be able to build for humble (ros2#76)
709ccf8 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Add copyright notice to all touched files (ros2#76)
3df3724 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Fix cpplint warnings (ros2#76)
9963cb6 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Update Ubuntu version to be able to build for humble (ros2#76)
43557a7 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Add copyright notice to all touched files (ros2#76)
3c278f1 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Fix cpplint warnings (ros2#76)
8cd3111 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 5, 2023
@mossmaurice
Update Ubuntu version to be able to build for humble (ros2#76)
18ab525 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 9, 2023
@mossmaurice
Check request pointer for 'nullptr' (ros2#76)
8b67b38 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 11, 2023
@mossmaurice
Remove out-commented code and implement setting the GUID (ros2#76)
bb005ce 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 11, 2023
@mossmaurice
Move the code to inside the happy-path lambda for client server commu…
9613b46 
…nication (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 11, 2023
@mossmaurice
Move the code to inside the happy-path lambda for client server commu…
b186509 
…nication (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 12, 2023
@mossmaurice
Use default alignment when loaning for request/response (ros2#76)
6546111 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 24, 2023
@mossmaurice
Remove sleeps in 'rmw_send_response' as fix will be in 'v2.0.3' relea…
9021bcb 
…se (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 24, 2023
@mossmaurice
Remove sleeps in 'rmw_send_response' as fix will be in 'v2.0.3' relea…
cbb145d 
…se (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Jan 25, 2023
@mossmaurice
Update version number in package.xml (ros2#76)
78201e1 
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit that referenced this issue Jan 30, 2023
@mossmaurice
Use new Blueberry v2.0.3 feature request-response and its discovery (…
cfed5d6 
…#84)

* Implement create and destroy methods for service and client (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Implement wrapper classes for client and server and add type introspection methods accordingly (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Update Readme (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Implement 'rmw_send_request', 'rmw_take_request' and 'rmw_take_response'
(#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Add fixed-size path for 'rmw_send_response' and 'rmw_take_response' (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Create server and client abstraction (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Fix 'is_fixed_size' for ROS 2 services (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Properly destroy services and clients and add serialization for services
(#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Fix typo leading to a segfault (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Attach servers and clients to waitset (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Remove debug prints and add de-serialization to 'rmw_send_response' (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Add missing remove-from-waitset part (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Do not send 'request_header' over user payload (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Properly save the sample in 'rwm_take_request' (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Fix lost responses issue (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Implement 'rmw_get_service_names_and_types' (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Format all the things (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Update CI and docs (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Add copyright notice to all touched files (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Fix cpplint warnings (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Update Ubuntu version to be able to build for humble (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Check request pointer for 'nullptr' (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Remove out-commented code and implement setting the GUID (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Move the code to inside the happy-path lambda for client server communication (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Use default alignment when loaning for request/response (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Remove sleeps in 'rmw_send_response' as fix will be in 'v2.0.3' release (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Update version number in package.xml (#76)

Signed-off-by: Simon Hoinkis <[email protected]>

---------

Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice added a commit to ApexAI/rmw_iceoryx that referenced this issue Sep 16, 2023
@mossmaurice
Use new Blueberry v2.0.3 feature request-response and its discovery (…
15bf7ed 
…ros2#84)

* Implement create and destroy methods for service and client (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Implement wrapper classes for client and server and add type introspection methods accordingly (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Update Readme (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Implement 'rmw_send_request', 'rmw_take_request' and 'rmw_take_response'
(ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Add fixed-size path for 'rmw_send_response' and 'rmw_take_response' (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Create server and client abstraction (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Fix 'is_fixed_size' for ROS 2 services (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Properly destroy services and clients and add serialization for services
(ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Fix typo leading to a segfault (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Attach servers and clients to waitset (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Remove debug prints and add de-serialization to 'rmw_send_response' (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Add missing remove-from-waitset part (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Do not send 'request_header' over user payload (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Properly save the sample in 'rwm_take_request' (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Fix lost responses issue (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Implement 'rmw_get_service_names_and_types' (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Format all the things (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Update CI and docs (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Add copyright notice to all touched files (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Fix cpplint warnings (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Update Ubuntu version to be able to build for humble (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Check request pointer for 'nullptr' (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Remove out-commented code and implement setting the GUID (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Move the code to inside the happy-path lambda for client server communication (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Use default alignment when loaning for request/response (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Remove sleeps in 'rmw_send_response' as fix will be in 'v2.0.3' release (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

* Update version number in package.xml (ros2#76)

Signed-off-by: Simon Hoinkis <[email protected]>

---------

Signed-off-by: Simon Hoinkis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossmaurice mossmaurice

Labels
enhancement New feature or request humble Related to ROS 2 Humble rolling Related to ROS 2 Rolling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new Blueberry v2.0.3 feature request-response and its discovery ApexAI/rmw_iceoryx
1 participant
@mossmaurice