Use new Blueberry v2.0.3 feature request-response and its discovery
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Hoinkis <[email protected]>
…ction methods accordingly (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
(ros2#76) Signed-off-by: Simon Hoinkis <[email protected]>
…os2#76) Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
(ros2#76) Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
…os2#76) Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
changed the title
v2.0.2 features request-response and their discovery
|
@elBoberido Would you mind reviewing this PR? FYI @budrus @ZhenshengLee if you interested in having a look. |
mossmaurice
force-pushed
the
use-new-blueberry-features-request-response-and-discovery
branch
from
e8e4071 to
fca0340
Compare
mossmaurice
changed the title
v2.0.2 features request-response and their discoveryv2.0.2 feature request-response and its discovery
mossmaurice
commented
Jan 5, 2023
mossmaurice
commented
Jan 5, 2023
mossmaurice
commented
Jan 5, 2023
Signed-off-by: Simon Hoinkis <[email protected]>
…nication (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
force-pushed
the
use-new-blueberry-features-request-response-and-discovery
branch
from
9613b46 to
b186509
Compare
Signed-off-by: Simon Hoinkis <[email protected]>
|
Currently, this PR is blocked by eclipse-iceoryx/iceoryx#1505 and eclipse-iceoryx/iceoryx#1668. Once iceoryx Blueberry |
mossmaurice
changed the title
v2.0.2 feature request-response and its discoveryv2.0.3 feature request-response and its discovery
…se (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
force-pushed
the
use-new-blueberry-features-request-response-and-discovery
branch
from
9021bcb to
cbb145d
Compare
Signed-off-by: Simon Hoinkis <[email protected]>
budrus
approved these changes
Jan 30, 2023
mossmaurice
added a commit
to ApexAI/rmw_iceoryx
that referenced
this pull request
Sep 16, 2023
…ros2#84) * Implement create and destroy methods for service and client (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Implement wrapper classes for client and server and add type introspection methods accordingly (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Update Readme (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Implement 'rmw_send_request', 'rmw_take_request' and 'rmw_take_response' (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Add fixed-size path for 'rmw_send_response' and 'rmw_take_response' (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Create server and client abstraction (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Fix 'is_fixed_size' for ROS 2 services (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Properly destroy services and clients and add serialization for services (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Fix typo leading to a segfault (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Attach servers and clients to waitset (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Remove debug prints and add de-serialization to 'rmw_send_response' (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Add missing remove-from-waitset part (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Do not send 'request_header' over user payload (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Properly save the sample in 'rwm_take_request' (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Fix lost responses issue (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Implement 'rmw_get_service_names_and_types' (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Format all the things (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Update CI and docs (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Add copyright notice to all touched files (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Fix cpplint warnings (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Update Ubuntu version to be able to build for humble (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Check request pointer for 'nullptr' (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Remove out-commented code and implement setting the GUID (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Move the code to inside the happy-path lambda for client server communication (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Use default alignment when loaning for request/response (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Remove sleeps in 'rmw_send_response' as fix will be in 'v2.0.3' release (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> * Update version number in package.xml (ros2#76) Signed-off-by: Simon Hoinkis <[email protected]> --------- Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/rmw_iceoryx
that referenced
this pull request
Sep 16, 2023
mossmaurice
added a commit
to ApexAI/rmw_iceoryx
that referenced
this pull request
Sep 16, 2023
…os2#84) Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/rmw_iceoryx
that referenced
this pull request
Sep 18, 2023
mossmaurice
added a commit
to ApexAI/rmw_iceoryx
that referenced
this pull request
Sep 18, 2023
mossmaurice
added a commit
to ApexAI/rmw_iceoryx
that referenced
this pull request
Sep 18, 2023
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/rmw_iceoryx
that referenced
this pull request
Sep 20, 2023
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
that referenced
this pull request
Sep 20, 2023
* Use new Blueberry v2.0.3 feature request-response and its discovery (#84) Signed-off-by: Simon Hoinkis <[email protected]> * Remove cppcheck from linter job and use Ubuntu 22.04 Signed-off-by: Simon Hoinkis <[email protected]> * Include 'iceoryx_hoofs' legacy header and use 'iox::into' for string conversion Signed-off-by: Simon Hoinkis <[email protected]> * Fix dependency of name conversion lib (#81) Signed-off-by: Simon Hoinkis <[email protected]> * Call correct destructor (#81) Signed-off-by: Simon Hoinkis <[email protected]> * Use 'rcutils_get_executable_name' to get the name of the process (#94) Signed-off-by: Simon Hoinkis <[email protected]> * Set C++ standard in accordance with iceoryx (#93) Signed-off-by: Simon Hoinkis <[email protected]> * Address review findings (#84) Signed-off-by: Simon Hoinkis <[email protected]> --------- Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
to ApexAI/rmw_iceoryx
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Simon Hoinkis <[email protected]>
mossmaurice
added a commit
that referenced
this pull request
Oct 17, 2023
* Address review findings (#84) Signed-off-by: Simon Hoinkis <[email protected]> * Implement new rmw functions needed for iron (#99) Signed-off-by: Simon Hoinkis <[email protected]> * Change CI to iron (#99) Signed-off-by: Simon Hoinkis <[email protected]> --------- Signed-off-by: Simon Hoinkis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rmw_*functions need for request-response aka ROS 2 service-client communication.IceoryxServerandIceoryxClientrmw_get_service_names_and_typesis not fully implemented and only contains the data available throughServiceDiscoveryas the server and clients and not yet published via the introspection portsCommands for a quick test:
Open questions:
Is the writer GUID needed?✔️Is there a better workaround than sleeping in✔️ Bug in iceoryx, seermw_send_response? See here forrmw_cycloneddscommentWaitSet::waitdoes not return if data was send beforeWaitSet::attachStateeclipse-iceoryx/iceoryx#1855How can the full type be aquired via rosidl to do an✔️ Created Add default alignment toalignof()?loanmethod inpopo::UntypedServerImplandpopo:UntypedClientImpleclipse-iceoryx/iceoryx#1845ServiceDiscoveryto query node and other relevant info, tbd in the next developer meetup -> Added to the meeting agenda ✔️Known limitations:
rmw_request_id_tand add avoid *there if accepted in upstream https://github.com/ros2/rmw/. For now, the limitation exists to always callrmw_take_requestfollowed byrmw_send_responseand not call e.g. 2x timesrmw_take_requestand then 2xrmw_send_response.Closes #76 (partly)