refactor(mainnet): monetary config #440

al3mart · 2025-01-21T00:42:35Z

Creates monetary config module including:

pallet_balances
pallet_transaction_payment
fee constants

Notable configuration items are:

deposit

Mainnet to use its own deposit function different from the one defined in pop_runtime_common being used in devnet and testnet. It aligns the deposit pricing with system chains in Polkadot.

pub const fn deposit(items: u32, bytes: u32) -> Balance {
	// src: https://github.com/polkadot-fellows/runtimes/blob/main/system-parachains/constants/src/polkadot.rs#L70
	(items as Balance * 20 * UNIT + (bytes as Balance) * 100 * fee::MILLI_CENTS) / 100
}

Weight to fee

Maps ExtrinsicBaseWeight::get().ref_time() to 1/200 CENT.
Maps 20kb proof to 1 CENT.

Existential deposit

1_000_000_000 units.

pallet_balances

type MaxLocks = ConstU32<0>;
type MaxReserves = ConstU32<0>;
type ReserveIdentifier = ();

Configured this way as these types are deprecated: paritytech/substrate#12951

pallet_transaction_payment

OnChargeTransaction needs to align with the result of [sc-2260]

type OnChargeTransaction =
		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<SudoAddress, Balances>>;

[sc-2205]

al3mart · 2025-01-21T08:37:18Z

runtime/mainnet/src/config/monetary.rs

+	type ExistentialDeposit = ExistentialDeposit;
+	type FreezeIdentifier = RuntimeFreezeReason;
+	type MaxFreezes = VariantCountOf<RuntimeFreezeReason>;
+	type MaxLocks = ConstU32<0>;


Locks are deprecated.

al3mart · 2025-01-21T08:37:30Z

runtime/mainnet/src/config/monetary.rs

+	type FreezeIdentifier = RuntimeFreezeReason;
+	type MaxFreezes = VariantCountOf<RuntimeFreezeReason>;
+	type MaxLocks = ConstU32<0>;
+	type MaxReserves = ConstU32<0>;


Reserves are deprecated.

al3mart · 2025-01-21T08:39:08Z

runtime/mainnet/src/config/monetary.rs

+	type FeeMultiplierUpdate = SlowAdjustingFeeUpdate<Self>;
+	type LengthToFee = ConstantMultiplier<Balance, TransactionByteFee>;
+	type OnChargeTransaction =
+		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<SudoAddress, Balances>>;


Needs to align with the result of [sc-2260]

runtime/mainnet/src/config/monetary.rs

codecov-commenter · 2025-01-27T22:15:43Z

Codecov Report

Attention: Patch coverage is 95.48872% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (al3mart/refactor-mainnet-config@e866970). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
runtime/mainnet/src/config/monetary.rs	95.48%	10 Missing and 2 partials ⚠️

@@                        Coverage Diff                         @@
##             al3mart/refactor-mainnet-config     #440   +/-   ##
==================================================================
  Coverage                                   ?   72.55%           
==================================================================
  Files                                      ?       77           
  Lines                                      ?    14472           
  Branches                                   ?    14472           
==================================================================
  Hits                                       ?    10500           
  Misses                                     ?     3703           
  Partials                                   ?      269

Files with missing lines	Coverage Δ
runtime/mainnet/src/apis.rs	`0.00% <ø> (ø)`
runtime/mainnet/src/config/xcm.rs	`100.00% <ø> (ø)`
runtime/mainnet/src/lib.rs	`81.25% <ø> (ø)`
runtime/mainnet/src/config/monetary.rs	`95.48% <95.48%> (ø)`

runtime/mainnet/src/config/monetary.rs

al3mart · 2025-01-28T00:47:22Z

runtime/mainnet/src/config/monetary.rs

@@ -131,7 +131,7 @@ impl pallet_transaction_payment::Config for Runtime {
 	type FeeMultiplierUpdate = SlowAdjustingFeeUpdate<Self>;
 	type LengthToFee = ConstantMultiplier<Balance, TransactionByteFee>;
 	type OnChargeTransaction =
-		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<SudoAddress, Balances>>;
+		pallet_transaction_payment::FungibleAdapter<Balances, ResolveTo<TreasuryAccount, Balances>>;


Still needs aligning with [sc-2260] but allowed me to remove sudo completely from here.

al3mart · 2025-01-28T11:57:50Z

runtime/mainnet/src/config/monetary.rs

+				value: UNIT + (existential_deposit / 2),
+			});
+			Balances::set_balance(&who, existential_deposit + UNIT);
+			Balances::set_balance(&TreasuryAccount::get(), UNIT);


TreasuryAccount existence needs to be covered before it starts receiving dust amounts. Otherwise dust won't be resolved into the account.

peterwht

Approving! Nice.

I left two comments you could commit directly in GitHub that use the ED value instead of UNIT for the dust test. Not a blocker though as it's a small detail.

peterwht · 2025-01-29T15:48:26Z

runtime/mainnet/src/config/monetary.rs

+				value: UNIT + (existential_deposit / 2),
+			});
+			Balances::set_balance(&who, existential_deposit + UNIT);
+			Balances::set_balance(&TreasuryAccount::get(), UNIT);


more accurate to use the ED value, right?

Suggested change

Balances::set_balance(&TreasuryAccount::get(), UNIT);

Balances::set_balance(&TreasuryAccount::get(), existential_deposit);

Resolved in 2fdfee7 as I spotted an import that could be removed.

peterwht · 2025-01-29T15:53:29Z

runtime/mainnet/src/config/monetary.rs

+			// Treasury balance equals its initial balance + the dusted amount from `who`.
+			assert_eq!(
+				Balances::free_balance(&TreasuryAccount::get()),
+				UNIT + existential_deposit / 2


Suggested change

UNIT + existential_deposit / 2

existential_deposit + existential_deposit / 2

if you agree with using ED value instead of UNIT for the initial treasury balance.

al3mart · 2025-01-29T18:00:06Z

runtime/mainnet/src/config/monetary.rs

+	fn transaction_payment_weight_to_fee_as_expected() {
+		let arb_weight = Weight::from_parts(126_142_001, 123_456);
+		let no_proof_size_weight = Weight::from_parts(126_142_001, 0);
+		let weights: [Weight; 4] = [


Could be a list of the actual weights of some of the extrinsics from the pallets in the runtime, would make for a better test.
Can be updated after we run benchmarks..

peterwht

LGTM!

Daanvdplas

Super cool PR, nice to go over the details here again :)

Left a few nitpicks but overall looking goood!

Daanvdplas · 2025-01-31T10:17:31Z

runtime/mainnet/src/config/monetary.rs

+	SlowAdjustingFeeUpdate, System, VariantCountOf, EXISTENTIAL_DEPOSIT,
+};
+
+pub const fn deposit(items: u32, bytes: u32) -> Balance {


Missing docs for pub functions

Daanvdplas · 2025-01-31T10:19:11Z

runtime/mainnet/src/config/monetary.rs

+}
+
+/// Constants related to Polkadot fee payment.
+/// Source: https://github.com/polkadot-fellows/runtimes/blob/main/system-parachains/constants/src/polkadot.rs#L65C47-L65C58


Doesn't have to be included in docs tmo, serves more as a reference for code maintainers / readers:

Suggested change

/// Source: https://github.com/polkadot-fellows/runtimes/blob/main/system-parachains/constants/src/polkadot.rs#L65C47-L65C58

// Source: https://github.com/polkadot-fellows/runtimes/blob/main/system-parachains/constants/src/polkadot.rs#L65C47-L65C58

Daanvdplas · 2025-01-31T10:20:21Z

runtime/mainnet/src/config/monetary.rs

+	pub const CENTS: Balance = MILLI_UNIT * 10; // 100_000_000
+	pub const MILLI_CENTS: Balance = CENTS / 1_000; // 100_000
+
+	/// Cost of every transaction byte at Polkadot system parachains.


Don't understand this sentence and we are not a system parachain.

When calculating the cost of a transaction this price will be multiplied by the length (in #bytes) of the transaction in question.
Removed the system chain reference. The price is aligned with the one system chains charge.

When calculating the cost of a transaction this price will be multiplied by the length (in #bytes) of the transaction in question. very informative and perfect for the docs of this type

Daanvdplas · 2025-01-31T10:24:06Z

runtime/mainnet/src/config/monetary.rs

+
+	/// Cost of every transaction byte at Polkadot system parachains.
+	///
+	/// It is the Relay Chain (Polkadot) `TransactionByteFee` / 20.


I don't find this adding value as we are using MILLI_CENTS and there is no correlation provided with TransactionByteFee. I also don't understand what this means, what is the TransactionByteFee and why is it 20 times smaller?

It doesn't align with line 126.

Can we also remove the public docs from it, it is more a detail for code mantainers / readers.

Good catch! Updated that comment.

runtime/mainnet/src/config/monetary.rs

Daanvdplas

One final check on the TRANSACTION_BYTE_FEE

Daanvdplas · 2025-02-03T13:34:01Z

runtime/mainnet/src/config/monetary.rs

+
+parameter_types! {
+	/// Relay Chain `TransactionByteFee` / 20.
+	pub const TransactionByteFee: Balance = fee::TRANSACTION_BYTE_FEE;


I still don't understand, we are already dividing this constant by 2 and saying the exact same here (both types have the comment of the relay chains value divided by 20). Are not doing what the comment says twice?

Maybe a comment that doesn't talk about the cost but how TransactionByteFee is relevant can be more clear ?

f426357

We are not doing anything twice. The comment was just a heads up that the value equals the relay's divided by 20.
I've removed this comment.

al3mart · 2025-02-04T11:43:10Z

rebased after merning proxy config changes into the base branch.

Daanvdplas

LGTM, well done!

remove extra clone

…UNITS

changes after rebase more changes after reabse

* refactor(mainnet): pallet_balances & fee constants * test(mainnet): add pallet_balances tests * refactor(mainnet): add pallet_transaction_payment to monetary config * test(mainnet): add transaction_payment tests * fix(mainnet): rebase fixes * fix(monetary): don't burn dust * refactor(monetary): use treasury account instead of sudo remove extra clone * refactor(monetary): use existential_deposit instead of UNIT in dust test * refactor(monetary): Don't use DOLLARS & CENTS is defined in terms of UNITS * fix(monetary): missing doc for fn deposit * docs(monetary): remove src from docs * docs(monetary): update TransactionByteFee comments * refactor(monetary): reorg tests into modules * style(monetary): remove confussing comment * style(monetar): remove prefixes from tests changes after rebase more changes after reabse

* refactor(mainnet): add governance & pallet_sudo tests (#443) * refactor(mainnet): add governance & pallet_sudo tests * refactor(sudo): sudo account defined in governance & unit test fix(governance): make governance mod public & better sudo declaration * refactor(mainnet): utility config (#438) * refactor(mainnet): add pallet_multisig to utility * test(mainnet): add pallet_multisig tests * refactor(mainnet): add pallet_utility to utility * test(mainnet): add pallet_utility tests * refactor(mainnet): add pallet_preimage to utility * test(mainnet): add pallet_preimage tests * refactor(mainnet): add pallet_scheduler to utility * test(mainnet): add pallet_scheduler tests * refactor(mainnet): pallet_proxy config & tests (#441) * refactor(mainnet): pallet_proxy config & tests * style(proxy): tests follow config order * refactor(proxy): remove asset related ProxyTypes * refactor(proxy): update ProxyDepositBase price * refactor(proxy): revert d3bfc6c and redefine ProxyType for mainnet typo * fix(proxy): amend proxy_has_deposit_base test * docs(proxy): Clarify new ProxyType definition * docs(proxy): add is_superset comments * test(proxy): clarify deposit byte size lenght * refactor(mainnet): system config (#442) * refactor(mainnet): add frame_system to system * test(mainnet): add pallet_system test * fix(mainnet): rebase fixes * fix(system): bring missing types in scope * refactor(system): add cumulus_parachain_system to system config module * test(system): add cumulus_parachain_system tests * refactor(system): add parachain_info into system config module * refactor(system): add pallet_timestamp into system config module * style(system): add ConsensusHook comment * refactor(system): separate tests by module * docs(system): document public config modules * fix(system): allow unused_imports to remove Executive warning * refactor(system): reintroduce FilteredCalls * style(system): get rid of test prefixes * style(system): relocate max_block_weigth comment * test(system): check for Hash type config * docs(system): amend outdated comments * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <[email protected]> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <[email protected]> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <[email protected]> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <[email protected]> --------- Co-authored-by: Daan van der Plas <[email protected]> * refactor(mainnet): monetary config (#440) * refactor(mainnet): pallet_balances & fee constants * test(mainnet): add pallet_balances tests * refactor(mainnet): add pallet_transaction_payment to monetary config * test(mainnet): add transaction_payment tests * fix(mainnet): rebase fixes * fix(monetary): don't burn dust * refactor(monetary): use treasury account instead of sudo remove extra clone * refactor(monetary): use existential_deposit instead of UNIT in dust test * refactor(monetary): Don't use DOLLARS & CENTS is defined in terms of UNITS * fix(monetary): missing doc for fn deposit * docs(monetary): remove src from docs * docs(monetary): update TransactionByteFee comments * refactor(monetary): reorg tests into modules * style(monetary): remove confussing comment * style(monetar): remove prefixes from tests changes after rebase more changes after reabse * refactor(mainnet): collation config (#439) * refactor(mainnet): add pallet_authorship to collation * test(mainnet): add pallet_auhtorship test * refactor(mainnet): add pallet_aura to collation * test(mainnet): add pallet_aura tests * refactor(mainnet): add collator_selection to collation * test(mainnet): add collator_selection tests * refactor(mainnet): add pallet_session & aura_ext to collation * test(mainnet): add pallet_session tests * chore(aura): MaxAuthorities matches max possible blocks produced * remove unnused imports * style(collation): order tests following pallet config * style(collation): remove unnecessary qualifications * style(collation): max_authorities_is_3600 * style(collation): reorg definition in session_keys_provided_by_aura test * style(collation): better Period comment * style(collation): clarify session::SessionHandler comment * refactor(collation): separate tests in modules by pallet * style(collation): Explain SessionHandler config fixes after rebase * style(collation): remove prefixes from tests * style(collation): Period comment was not helpful changes after rebase * style(utility): better test structure style(utility): fmt rebase fmt fmt * refactor(mainnet): xcm config (#455) * refactor(mainnet): rebase changes * chore(mainnet): update Cargo.lock * refactor(mainnet): utility config (#438) * refactor(mainnet): add pallet_multisig to utility * test(mainnet): add pallet_multisig tests * refactor(mainnet): add pallet_utility to utility * test(mainnet): add pallet_utility tests * refactor(mainnet): add pallet_preimage to utility * test(mainnet): add pallet_preimage tests * refactor(mainnet): add pallet_scheduler to utility * test(mainnet): add pallet_scheduler tests * refactor(mainnet): system config (#442) * refactor(mainnet): add frame_system to system * test(mainnet): add pallet_system test * fix(mainnet): rebase fixes * fix(system): bring missing types in scope * refactor(system): add cumulus_parachain_system to system config module * test(system): add cumulus_parachain_system tests * refactor(system): add parachain_info into system config module * refactor(system): add pallet_timestamp into system config module * style(system): add ConsensusHook comment * refactor(system): separate tests by module * docs(system): document public config modules * fix(system): allow unused_imports to remove Executive warning * refactor(system): reintroduce FilteredCalls * style(system): get rid of test prefixes * style(system): relocate max_block_weigth comment * test(system): check for Hash type config * docs(system): amend outdated comments * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <[email protected]> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <[email protected]> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <[email protected]> * Update runtime/mainnet/src/config/mod.rs Co-authored-by: Daan van der Plas <[email protected]> --------- Co-authored-by: Daan van der Plas <[email protected]> * refactor(mainnet): collation config (#439) * refactor(mainnet): add pallet_authorship to collation * test(mainnet): add pallet_auhtorship test * refactor(mainnet): add pallet_aura to collation * test(mainnet): add pallet_aura tests * refactor(mainnet): add collator_selection to collation * test(mainnet): add collator_selection tests * refactor(mainnet): add pallet_session & aura_ext to collation * test(mainnet): add pallet_session tests * chore(aura): MaxAuthorities matches max possible blocks produced * remove unnused imports * style(collation): order tests following pallet config * style(collation): remove unnecessary qualifications * style(collation): max_authorities_is_3600 * style(collation): reorg definition in session_keys_provided_by_aura test * style(collation): better Period comment * style(collation): clarify session::SessionHandler comment * refactor(collation): separate tests in modules by pallet * style(collation): Explain SessionHandler config fixes after rebase * style(collation): remove prefixes from tests * style(collation): Period comment was not helpful changes after rebase * refactor(xcm): add pallet_message_queue into xcm config module * test(xcm): add message_queue tests * test(xcm): test location, transactor and barrier type definitions * refactor(xcm): include pallet_xcmp_queue into xcm config module * test(xcm): add pallet_xcmp_queue configuration tests * test(xcm): add xcm_executor configuration tests * test(xcm): adding pallet_xcm config tests * fix(xcm): typo fix(xcm): XcmReserveTransferFilter is Everything * refactor(xcm): use unitype for MaxRemoteLockConsumers * style(xcm): tests separated in modules * style(xcm): better naming for XcmTeleportFilter test * style(xcm): test naming and order * docs(xcm): clarifying comments for specific xcmp_queueu types * style(xcm): typo * style(xcm): better name for reserves tests * refactor(xcm): Use `NativeAssetFrom<T>` as `XcmReserveTransferFilter` (#459) * refactor(xcm): Use NativeAssetFrom<T> as XcmReserveTransferFilter style:fmt * fix(xcm): NativeAssetFrom<AssetHub> filters everything but DOT from AH * fix(xcm): XcmReserveTransferFilter filters only by asset fix changes after rebase fmt * fix(xcm): remove waived locations (#456) * fix(xcm): no locations are waived * test(xcm): improved waived_location test changes after rebase * style(xcm): clarify that we are not waiving fees for any location * fix(xcm): charge delivery fees (#457) * resolve rebase conflicts * fix(xcm): reserve_transfer_native_asset_from_para_to_system_para accounts for delivery fees * fix(integration-tests): handle delivery_fees only with mainnet feature on fmt after rebase fmt changes after rebase fmt fmt * test(xcm): address feedback from #459 typos AssetFilter * style(xcm): locate reserve tests within executor lint * fix(integration-test): improve tests & remove feature gated compilation unnecessary Fungibles * refactor: integration tests mainnet xcm (#466) * refactor: integration tests mainnet xcm * fix: remove unused ED rebase fmt fmt * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <[email protected]> * refactor(xcm): use TreasuryAccount from monetary * chore(xcm): unused imports * chore(xcm): amend test modules * chore(integration-tests): amend reserve_transfer_native_asset_from_para_to_system * chore(xcm): divive reserve filter test in two * chore(xcm): fmt * style(integration-tests): fix unwanted indentation * test(xcm): more focused unit tests * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <[email protected]> * Update runtime/mainnet/src/config/xcm.rs Co-authored-by: Daan van der Plas <[email protected]> * fix(test): amend suggestions --------- Co-authored-by: Daan van der Plas <[email protected]> * feat(mainnet): introduce assets (#465) * refactor(mainnet): include assets fmt refactor(collator): not necessary import * test(assets): add nfts config unit tests * refactor(proxy): Add assets & smart contract proxy type * refactor(assets): implement nfts runtime api * fix(pallet-nfts-api): workspace linters are not defined * docs(assets): clarify deposits * chore(proxy): improve usage of references * docs(assets): update src reference * chore(assets): update MetadataDepositBase * docs(assets): remove TODOs * refactor(proxy): revert SmartContract ProxyType * revert: e614927 * style(Cargo): revert format changes on dep comments * chore(assets): apply feedback to tests * chore(assets): removed unused type * revert: fb92342 This reverts commit fb92342. * docs(assets): better comments * chore(assets): lower nfts deposit costs * chore(assets): reduced deposit cost for AssetAccountDeposit * chore(assets): use SDK's pallet_nfts * chore(assets): better deposits & fmt Cargo * chore(assets): better comments * chore(assets): more explicit comments for deposits * chore(assets): provide src for NftsCollectionDeposit deposit * chore(assets): apply feedback * chore(monetary): clean unnecessary comments * chore(utility): make deposit calc explicit. (#469) chore(utility): explicit deposit justification rebase fixes * chore(proxy): reintroduce Asset related proxy types * syle(proxy): Clarify proxy test comments --------- Co-authored-by: Daan van der Plas <[email protected]>

al3mart force-pushed the al3mart/refactor-mainnet-config branch from d68af12 to 937ca11 Compare January 21, 2025 08:35

al3mart commented Jan 21, 2025

View reviewed changes

runtime/mainnet/src/config/monetary.rs Show resolved Hide resolved

al3mart force-pushed the al3mart/refactor-mainnet-config branch 2 times, most recently from 7359e7a to 9594a3b Compare January 24, 2025 17:20

al3mart force-pushed the al3mart/refactor-mainnet-monetary branch from 8792be4 to e209cce Compare January 27, 2025 21:13

al3mart marked this pull request as ready for review January 27, 2025 21:37

al3mart added the ready-for-final-review label Jan 27, 2025

peterwht self-requested a review January 27, 2025 22:22

peterwht requested changes Jan 27, 2025

View reviewed changes

runtime/mainnet/src/config/monetary.rs Show resolved Hide resolved

runtime/mainnet/src/config/monetary.rs Outdated Show resolved Hide resolved

al3mart commented Jan 28, 2025

View reviewed changes

al3mart force-pushed the al3mart/refactor-mainnet-monetary branch from dc7df88 to f49c3c6 Compare January 28, 2025 00:54

al3mart commented Jan 28, 2025

View reviewed changes

al3mart requested a review from Daanvdplas January 29, 2025 15:56

peterwht approved these changes Jan 29, 2025

View reviewed changes

al3mart commented Jan 29, 2025

View reviewed changes

peterwht approved these changes Jan 29, 2025

View reviewed changes

al3mart mentioned this pull request Jan 31, 2025

refactor(mainnet): ready runtime config #458

Merged

11 tasks

Daanvdplas reviewed Jan 31, 2025

View reviewed changes

al3mart requested a review from Daanvdplas February 3, 2025 12:21

Daanvdplas reviewed Feb 3, 2025

View reviewed changes

al3mart force-pushed the al3mart/refactor-mainnet-monetary branch from 215f68b to f426357 Compare February 4, 2025 11:42

Daanvdplas self-requested a review February 4, 2025 13:18

Daanvdplas approved these changes Feb 4, 2025

View reviewed changes

al3mart added 2 commits February 4, 2025 17:59

refactor(mainnet): pallet_balances & fee constants

3a7b28d

test(mainnet): add pallet_balances tests

7f0989a

al3mart added 13 commits February 4, 2025 18:00

refactor(mainnet): add pallet_transaction_payment to monetary config

8519576

test(mainnet): add transaction_payment tests

de7fde0

fix(mainnet): rebase fixes

9a4ba25

fix(monetary): don't burn dust

87b1054

refactor(monetary): use treasury account instead of sudo

5b680bb

remove extra clone

refactor(monetary): use existential_deposit instead of UNIT in dust test

06682d0

refactor(monetary): Don't use DOLLARS & CENTS is defined in terms of …

3c4f199

…UNITS

fix(monetary): missing doc for fn deposit

7570cad

docs(monetary): remove src from docs

54c7f6c

docs(monetary): update TransactionByteFee comments

011a079

refactor(monetary): reorg tests into modules

d5d96a3

style(monetary): remove confussing comment

acedaad

style(monetar): remove prefixes from tests

7f2d4c1

changes after rebase more changes after reabse

al3mart force-pushed the al3mart/refactor-mainnet-monetary branch from 14161f2 to 7f2d4c1 Compare February 4, 2025 17:13

al3mart merged commit 5f24440 into al3mart/refactor-mainnet-config Feb 4, 2025
3 checks passed

al3mart deleted the al3mart/refactor-mainnet-monetary branch February 4, 2025 17:14

al3mart mentioned this pull request Mar 3, 2025

feat(testnet): mainnet & devnet into testnet runtime #482

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(mainnet): monetary config #440

refactor(mainnet): monetary config #440

al3mart commented Jan 21, 2025 •

edited

Loading

al3mart Jan 21, 2025

al3mart Jan 21, 2025

al3mart Jan 21, 2025

codecov-commenter commented Jan 27, 2025 •

edited

Loading

al3mart Jan 28, 2025

al3mart Jan 28, 2025

peterwht left a comment

peterwht Jan 29, 2025

al3mart Jan 29, 2025

al3mart Jan 29, 2025

peterwht Jan 29, 2025

al3mart Jan 29, 2025

al3mart Jan 29, 2025 •

edited

Loading

peterwht left a comment

Daanvdplas left a comment

Daanvdplas Jan 31, 2025

al3mart Feb 3, 2025

Daanvdplas Jan 31, 2025

al3mart Feb 3, 2025

Daanvdplas Jan 31, 2025

al3mart Feb 3, 2025 •

edited

Loading

al3mart Feb 3, 2025

Daanvdplas Feb 3, 2025

Daanvdplas Jan 31, 2025

al3mart Feb 3, 2025

al3mart Feb 3, 2025

Daanvdplas left a comment

Daanvdplas Feb 3, 2025 •

edited

Loading

al3mart Feb 3, 2025 •

edited

Loading

al3mart Feb 4, 2025 •

edited

Loading

al3mart commented Feb 4, 2025

Daanvdplas left a comment

	Balances::set_balance(&TreasuryAccount::get(), UNIT);
	Balances::set_balance(&TreasuryAccount::get(), existential_deposit);

	UNIT + existential_deposit / 2
	existential_deposit + existential_deposit / 2

	/// Source: https://github.com/polkadot-fellows/runtimes/blob/main/system-parachains/constants/src/polkadot.rs#L65C47-L65C58
	// Source: https://github.com/polkadot-fellows/runtimes/blob/main/system-parachains/constants/src/polkadot.rs#L65C47-L65C58

refactor(mainnet): monetary config #440

refactor(mainnet): monetary config #440

Conversation

al3mart commented Jan 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 27, 2025 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterwht left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

al3mart Jan 29, 2025 • edited Loading

Choose a reason for hiding this comment

peterwht left a comment

Choose a reason for hiding this comment

Daanvdplas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

al3mart Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Daanvdplas left a comment

Choose a reason for hiding this comment

Daanvdplas Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

al3mart Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

al3mart Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

al3mart commented Feb 4, 2025

Daanvdplas left a comment

Choose a reason for hiding this comment

al3mart commented Jan 21, 2025 •

edited

Loading

codecov-commenter commented Jan 27, 2025 •

edited

Loading

al3mart Jan 29, 2025 •

edited

Loading

al3mart Feb 3, 2025 •

edited

Loading

Daanvdplas Feb 3, 2025 •

edited

Loading

al3mart Feb 3, 2025 •

edited

Loading

al3mart Feb 4, 2025 •

edited

Loading