Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: integration tests mainnet xcm #466

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Feb 6, 2025

The tests need to be improved in general but refactored it so that there is no mainnet specific code to a runtime generic test.

@Daanvdplas Daanvdplas changed the base branch from main to al3mart/refactor-mainnet-xcm February 6, 2025 20:24
@Daanvdplas Daanvdplas force-pushed the daan/refactor-it_xcm branch from 3302670 to fd9601a Compare February 6, 2025 20:31
@Daanvdplas Daanvdplas requested a review from al3mart February 6, 2025 20:31
// To avoid the account from being reaped we need to ensure its balance is >= ED.
let amount_to_send = amount_to_send - (pop_mainnet_ed + delivery_fees);
let assets: Assets = (Parent, amount_to_send).into();
let amount_to_send = PopNetworkPara::account_data_of(PopNetworkParaReceiver::get()).free / 4; // bob on pop balance
Copy link
Collaborator

@al3mart al3mart Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason for the division. Is it arbitrary ?

If the reason is not having the account balance lower than the ED I'd argue that showing that explicitly gives more information.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.96%. Comparing base (d63b78b) to head (fd9601a).

@@                      Coverage Diff                      @@
##           al3mart/refactor-mainnet-xcm     #466   +/-   ##
=============================================================
  Coverage                         73.96%   73.96%           
=============================================================
  Files                                78       78           
  Lines                             15254    15254           
  Branches                          15254    15254           
=============================================================
  Hits                              11282    11282           
  Misses                             3703     3703           
  Partials                            269      269           

@al3mart al3mart merged commit cd28cf7 into al3mart/refactor-mainnet-xcm Feb 7, 2025
16 checks passed
@al3mart al3mart deleted the daan/refactor-it_xcm branch February 7, 2025 01:05
al3mart pushed a commit that referenced this pull request Feb 7, 2025
* refactor: integration tests mainnet xcm

* fix: remove unused ED

rebase
al3mart pushed a commit that referenced this pull request Feb 7, 2025
* refactor: integration tests mainnet xcm

* fix: remove unused ED

rebase

fmt
al3mart pushed a commit that referenced this pull request Feb 7, 2025
* refactor: integration tests mainnet xcm

* fix: remove unused ED

rebase

fmt

fmt
al3mart added a commit that referenced this pull request Feb 10, 2025
* refactor(mainnet): rebase changes

* chore(mainnet): update Cargo.lock

* refactor(mainnet): utility config (#438)

* refactor(mainnet): add pallet_multisig to utility

* test(mainnet): add pallet_multisig tests

* refactor(mainnet): add pallet_utility to utility

* test(mainnet): add pallet_utility tests

* refactor(mainnet): add pallet_preimage to utility

* test(mainnet): add pallet_preimage tests

* refactor(mainnet): add pallet_scheduler to utility

* test(mainnet): add pallet_scheduler tests

* refactor(mainnet): system config (#442)

* refactor(mainnet): add frame_system to system

* test(mainnet): add pallet_system test

* fix(mainnet): rebase fixes

* fix(system): bring missing types in scope

* refactor(system): add cumulus_parachain_system to system config module

* test(system): add cumulus_parachain_system tests

* refactor(system): add parachain_info into system config module

* refactor(system): add pallet_timestamp into system config module

* style(system): add ConsensusHook comment

* refactor(system): separate tests by module

* docs(system): document public config modules

* fix(system): allow unused_imports to remove Executive warning

* refactor(system): reintroduce FilteredCalls

* style(system): get rid of test prefixes

* style(system): relocate max_block_weigth comment

* test(system): check for Hash type config

* docs(system): amend outdated comments

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

---------

Co-authored-by: Daan van der Plas <[email protected]>

* refactor(mainnet): collation config (#439)

* refactor(mainnet): add pallet_authorship to collation

* test(mainnet): add pallet_auhtorship test

* refactor(mainnet): add pallet_aura to collation

* test(mainnet): add pallet_aura tests

* refactor(mainnet): add collator_selection to collation

* test(mainnet): add collator_selection tests

* refactor(mainnet): add pallet_session & aura_ext to collation

* test(mainnet): add pallet_session tests

* chore(aura): MaxAuthorities matches max possible blocks produced

* remove unnused imports

* style(collation): order tests following pallet config

* style(collation): remove unnecessary qualifications

* style(collation): max_authorities_is_3600

* style(collation): reorg definition in session_keys_provided_by_aura test

* style(collation): better Period  comment

* style(collation): clarify session::SessionHandler comment

* refactor(collation): separate tests in modules by pallet

* style(collation): Explain SessionHandler config

fixes after rebase

* style(collation): remove prefixes from tests

* style(collation): Period comment was not helpful

changes after rebase

* refactor(xcm): add pallet_message_queue into xcm config module

* test(xcm): add message_queue tests

* test(xcm): test location, transactor and barrier type definitions

* refactor(xcm): include pallet_xcmp_queue into xcm config module

* test(xcm): add pallet_xcmp_queue configuration tests

* test(xcm): add xcm_executor configuration tests

* test(xcm): adding pallet_xcm config tests

* fix(xcm): typo

fix(xcm): XcmReserveTransferFilter is Everything

* refactor(xcm): use unitype for MaxRemoteLockConsumers

* style(xcm): tests separated in modules

* style(xcm): better naming for XcmTeleportFilter test

* style(xcm): test naming and order

* docs(xcm): clarifying comments for specific xcmp_queueu types

* style(xcm): typo

* style(xcm): better name for reserves tests

* refactor(xcm): Use `NativeAssetFrom<T>` as `XcmReserveTransferFilter` (#459)

* refactor(xcm): Use NativeAssetFrom<T> as XcmReserveTransferFilter

style:fmt

* fix(xcm): NativeAssetFrom<AssetHub> filters everything but DOT from AH

* fix(xcm): XcmReserveTransferFilter filters only by asset

fix

changes after rebase

fmt

* fix(xcm): remove waived locations (#456)

* fix(xcm): no locations are waived

* test(xcm): improved waived_location test

changes after rebase

* style(xcm): clarify that we are not waiving fees for any location

* fix(xcm): charge delivery fees (#457)

* resolve rebase conflicts

* fix(xcm): reserve_transfer_native_asset_from_para_to_system_para accounts for delivery fees

* fix(integration-tests): handle delivery_fees only with mainnet feature on

fmt after rebase

fmt

changes after rebase

fmt

fmt

* test(xcm): address feedback from #459

typos

AssetFilter

* style(xcm): locate reserve tests within executor

lint

* fix(integration-test): improve tests & remove feature gated compilation

unnecessary Fungibles

* refactor: integration tests mainnet xcm (#466)

* refactor: integration tests mainnet xcm

* fix: remove unused ED

rebase

fmt

fmt

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* refactor(xcm): use TreasuryAccount from monetary

* chore(xcm): unused imports

* chore(xcm): amend test modules

* chore(integration-tests): amend reserve_transfer_native_asset_from_para_to_system

* chore(xcm): divive reserve filter test in two

* chore(xcm): fmt

* style(integration-tests): fix unwanted indentation

* test(xcm): more focused unit tests

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* fix(test): amend suggestions

---------

Co-authored-by: Daan van der Plas <[email protected]>
al3mart added a commit that referenced this pull request Feb 17, 2025
* refactor(mainnet): rebase changes

* chore(mainnet): update Cargo.lock

* refactor(mainnet): utility config (#438)

* refactor(mainnet): add pallet_multisig to utility

* test(mainnet): add pallet_multisig tests

* refactor(mainnet): add pallet_utility to utility

* test(mainnet): add pallet_utility tests

* refactor(mainnet): add pallet_preimage to utility

* test(mainnet): add pallet_preimage tests

* refactor(mainnet): add pallet_scheduler to utility

* test(mainnet): add pallet_scheduler tests

* refactor(mainnet): system config (#442)

* refactor(mainnet): add frame_system to system

* test(mainnet): add pallet_system test

* fix(mainnet): rebase fixes

* fix(system): bring missing types in scope

* refactor(system): add cumulus_parachain_system to system config module

* test(system): add cumulus_parachain_system tests

* refactor(system): add parachain_info into system config module

* refactor(system): add pallet_timestamp into system config module

* style(system): add ConsensusHook comment

* refactor(system): separate tests by module

* docs(system): document public config modules

* fix(system): allow unused_imports to remove Executive warning

* refactor(system): reintroduce FilteredCalls

* style(system): get rid of test prefixes

* style(system): relocate max_block_weigth comment

* test(system): check for Hash type config

* docs(system): amend outdated comments

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

---------

Co-authored-by: Daan van der Plas <[email protected]>

* refactor(mainnet): collation config (#439)

* refactor(mainnet): add pallet_authorship to collation

* test(mainnet): add pallet_auhtorship test

* refactor(mainnet): add pallet_aura to collation

* test(mainnet): add pallet_aura tests

* refactor(mainnet): add collator_selection to collation

* test(mainnet): add collator_selection tests

* refactor(mainnet): add pallet_session & aura_ext to collation

* test(mainnet): add pallet_session tests

* chore(aura): MaxAuthorities matches max possible blocks produced

* remove unnused imports

* style(collation): order tests following pallet config

* style(collation): remove unnecessary qualifications

* style(collation): max_authorities_is_3600

* style(collation): reorg definition in session_keys_provided_by_aura test

* style(collation): better Period  comment

* style(collation): clarify session::SessionHandler comment

* refactor(collation): separate tests in modules by pallet

* style(collation): Explain SessionHandler config

fixes after rebase

* style(collation): remove prefixes from tests

* style(collation): Period comment was not helpful

changes after rebase

* refactor(xcm): add pallet_message_queue into xcm config module

* test(xcm): add message_queue tests

* test(xcm): test location, transactor and barrier type definitions

* refactor(xcm): include pallet_xcmp_queue into xcm config module

* test(xcm): add pallet_xcmp_queue configuration tests

* test(xcm): add xcm_executor configuration tests

* test(xcm): adding pallet_xcm config tests

* fix(xcm): typo

fix(xcm): XcmReserveTransferFilter is Everything

* refactor(xcm): use unitype for MaxRemoteLockConsumers

* style(xcm): tests separated in modules

* style(xcm): better naming for XcmTeleportFilter test

* style(xcm): test naming and order

* docs(xcm): clarifying comments for specific xcmp_queueu types

* style(xcm): typo

* style(xcm): better name for reserves tests

* refactor(xcm): Use `NativeAssetFrom<T>` as `XcmReserveTransferFilter` (#459)

* refactor(xcm): Use NativeAssetFrom<T> as XcmReserveTransferFilter

style:fmt

* fix(xcm): NativeAssetFrom<AssetHub> filters everything but DOT from AH

* fix(xcm): XcmReserveTransferFilter filters only by asset

fix

changes after rebase

fmt

* fix(xcm): remove waived locations (#456)

* fix(xcm): no locations are waived

* test(xcm): improved waived_location test

changes after rebase

* style(xcm): clarify that we are not waiving fees for any location

* fix(xcm): charge delivery fees (#457)

* resolve rebase conflicts

* fix(xcm): reserve_transfer_native_asset_from_para_to_system_para accounts for delivery fees

* fix(integration-tests): handle delivery_fees only with mainnet feature on

fmt after rebase

fmt

changes after rebase

fmt

fmt

* test(xcm): address feedback from #459

typos

AssetFilter

* style(xcm): locate reserve tests within executor

lint

* fix(integration-test): improve tests & remove feature gated compilation

unnecessary Fungibles

* refactor: integration tests mainnet xcm (#466)

* refactor: integration tests mainnet xcm

* fix: remove unused ED

rebase

fmt

fmt

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* refactor(xcm): use TreasuryAccount from monetary

* chore(xcm): unused imports

* chore(xcm): amend test modules

* chore(integration-tests): amend reserve_transfer_native_asset_from_para_to_system

* chore(xcm): divive reserve filter test in two

* chore(xcm): fmt

* style(integration-tests): fix unwanted indentation

* test(xcm): more focused unit tests

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* fix(test): amend suggestions

---------

Co-authored-by: Daan van der Plas <[email protected]>
al3mart added a commit that referenced this pull request Feb 17, 2025
* refactor(mainnet): add governance & pallet_sudo tests (#443)

* refactor(mainnet): add governance & pallet_sudo tests

* refactor(sudo): sudo account defined in governance & unit test

fix(governance): make governance mod public & better sudo declaration

* refactor(mainnet): utility config (#438)

* refactor(mainnet): add pallet_multisig to utility

* test(mainnet): add pallet_multisig tests

* refactor(mainnet): add pallet_utility to utility

* test(mainnet): add pallet_utility tests

* refactor(mainnet): add pallet_preimage to utility

* test(mainnet): add pallet_preimage tests

* refactor(mainnet): add pallet_scheduler to utility

* test(mainnet): add pallet_scheduler tests

* refactor(mainnet): pallet_proxy config & tests (#441)

* refactor(mainnet): pallet_proxy config & tests

* style(proxy): tests follow config order

* refactor(proxy): remove asset related ProxyTypes

* refactor(proxy): update ProxyDepositBase price

* refactor(proxy): revert d3bfc6c and redefine ProxyType for mainnet

typo

* fix(proxy): amend proxy_has_deposit_base test

* docs(proxy): Clarify new ProxyType definition

* docs(proxy): add is_superset comments

* test(proxy): clarify deposit byte size lenght

* refactor(mainnet): system config (#442)

* refactor(mainnet): add frame_system to system

* test(mainnet): add pallet_system test

* fix(mainnet): rebase fixes

* fix(system): bring missing types in scope

* refactor(system): add cumulus_parachain_system to system config module

* test(system): add cumulus_parachain_system tests

* refactor(system): add parachain_info into system config module

* refactor(system): add pallet_timestamp into system config module

* style(system): add ConsensusHook comment

* refactor(system): separate tests by module

* docs(system): document public config modules

* fix(system): allow unused_imports to remove Executive warning

* refactor(system): reintroduce FilteredCalls

* style(system): get rid of test prefixes

* style(system): relocate max_block_weigth comment

* test(system): check for Hash type config

* docs(system): amend outdated comments

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

---------

Co-authored-by: Daan van der Plas <[email protected]>

* refactor(mainnet): monetary config (#440)

* refactor(mainnet): pallet_balances & fee constants

* test(mainnet): add pallet_balances tests

* refactor(mainnet): add pallet_transaction_payment to monetary config

* test(mainnet): add transaction_payment tests

* fix(mainnet): rebase fixes

* fix(monetary): don't burn dust

* refactor(monetary): use treasury account instead of sudo

remove extra clone

* refactor(monetary): use existential_deposit instead of UNIT in dust test

* refactor(monetary): Don't use DOLLARS & CENTS is defined in terms of UNITS

* fix(monetary): missing doc for fn deposit

* docs(monetary): remove src from docs

* docs(monetary): update TransactionByteFee comments

* refactor(monetary): reorg tests into modules

* style(monetary): remove confussing comment

* style(monetar): remove prefixes from tests

changes after rebase

more changes after reabse

* refactor(mainnet): collation config (#439)

* refactor(mainnet): add pallet_authorship to collation

* test(mainnet): add pallet_auhtorship test

* refactor(mainnet): add pallet_aura to collation

* test(mainnet): add pallet_aura tests

* refactor(mainnet): add collator_selection to collation

* test(mainnet): add collator_selection tests

* refactor(mainnet): add pallet_session & aura_ext to collation

* test(mainnet): add pallet_session tests

* chore(aura): MaxAuthorities matches max possible blocks produced

* remove unnused imports

* style(collation): order tests following pallet config

* style(collation): remove unnecessary qualifications

* style(collation): max_authorities_is_3600

* style(collation): reorg definition in session_keys_provided_by_aura test

* style(collation): better Period  comment

* style(collation): clarify session::SessionHandler comment

* refactor(collation): separate tests in modules by pallet

* style(collation): Explain SessionHandler config

fixes after rebase

* style(collation): remove prefixes from tests

* style(collation): Period comment was not helpful

changes after rebase

* style(utility): better test structure

style(utility): fmt

rebase

fmt

fmt

* refactor(mainnet): xcm config (#455)

* refactor(mainnet): rebase changes

* chore(mainnet): update Cargo.lock

* refactor(mainnet): utility config (#438)

* refactor(mainnet): add pallet_multisig to utility

* test(mainnet): add pallet_multisig tests

* refactor(mainnet): add pallet_utility to utility

* test(mainnet): add pallet_utility tests

* refactor(mainnet): add pallet_preimage to utility

* test(mainnet): add pallet_preimage tests

* refactor(mainnet): add pallet_scheduler to utility

* test(mainnet): add pallet_scheduler tests

* refactor(mainnet): system config (#442)

* refactor(mainnet): add frame_system to system

* test(mainnet): add pallet_system test

* fix(mainnet): rebase fixes

* fix(system): bring missing types in scope

* refactor(system): add cumulus_parachain_system to system config module

* test(system): add cumulus_parachain_system tests

* refactor(system): add parachain_info into system config module

* refactor(system): add pallet_timestamp into system config module

* style(system): add ConsensusHook comment

* refactor(system): separate tests by module

* docs(system): document public config modules

* fix(system): allow unused_imports to remove Executive warning

* refactor(system): reintroduce FilteredCalls

* style(system): get rid of test prefixes

* style(system): relocate max_block_weigth comment

* test(system): check for Hash type config

* docs(system): amend outdated comments

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

---------

Co-authored-by: Daan van der Plas <[email protected]>

* refactor(mainnet): collation config (#439)

* refactor(mainnet): add pallet_authorship to collation

* test(mainnet): add pallet_auhtorship test

* refactor(mainnet): add pallet_aura to collation

* test(mainnet): add pallet_aura tests

* refactor(mainnet): add collator_selection to collation

* test(mainnet): add collator_selection tests

* refactor(mainnet): add pallet_session & aura_ext to collation

* test(mainnet): add pallet_session tests

* chore(aura): MaxAuthorities matches max possible blocks produced

* remove unnused imports

* style(collation): order tests following pallet config

* style(collation): remove unnecessary qualifications

* style(collation): max_authorities_is_3600

* style(collation): reorg definition in session_keys_provided_by_aura test

* style(collation): better Period  comment

* style(collation): clarify session::SessionHandler comment

* refactor(collation): separate tests in modules by pallet

* style(collation): Explain SessionHandler config

fixes after rebase

* style(collation): remove prefixes from tests

* style(collation): Period comment was not helpful

changes after rebase

* refactor(xcm): add pallet_message_queue into xcm config module

* test(xcm): add message_queue tests

* test(xcm): test location, transactor and barrier type definitions

* refactor(xcm): include pallet_xcmp_queue into xcm config module

* test(xcm): add pallet_xcmp_queue configuration tests

* test(xcm): add xcm_executor configuration tests

* test(xcm): adding pallet_xcm config tests

* fix(xcm): typo

fix(xcm): XcmReserveTransferFilter is Everything

* refactor(xcm): use unitype for MaxRemoteLockConsumers

* style(xcm): tests separated in modules

* style(xcm): better naming for XcmTeleportFilter test

* style(xcm): test naming and order

* docs(xcm): clarifying comments for specific xcmp_queueu types

* style(xcm): typo

* style(xcm): better name for reserves tests

* refactor(xcm): Use `NativeAssetFrom<T>` as `XcmReserveTransferFilter` (#459)

* refactor(xcm): Use NativeAssetFrom<T> as XcmReserveTransferFilter

style:fmt

* fix(xcm): NativeAssetFrom<AssetHub> filters everything but DOT from AH

* fix(xcm): XcmReserveTransferFilter filters only by asset

fix

changes after rebase

fmt

* fix(xcm): remove waived locations (#456)

* fix(xcm): no locations are waived

* test(xcm): improved waived_location test

changes after rebase

* style(xcm): clarify that we are not waiving fees for any location

* fix(xcm): charge delivery fees (#457)

* resolve rebase conflicts

* fix(xcm): reserve_transfer_native_asset_from_para_to_system_para accounts for delivery fees

* fix(integration-tests): handle delivery_fees only with mainnet feature on

fmt after rebase

fmt

changes after rebase

fmt

fmt

* test(xcm): address feedback from #459

typos

AssetFilter

* style(xcm): locate reserve tests within executor

lint

* fix(integration-test): improve tests & remove feature gated compilation

unnecessary Fungibles

* refactor: integration tests mainnet xcm (#466)

* refactor: integration tests mainnet xcm

* fix: remove unused ED

rebase

fmt

fmt

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* refactor(xcm): use TreasuryAccount from monetary

* chore(xcm): unused imports

* chore(xcm): amend test modules

* chore(integration-tests): amend reserve_transfer_native_asset_from_para_to_system

* chore(xcm): divive reserve filter test in two

* chore(xcm): fmt

* style(integration-tests): fix unwanted indentation

* test(xcm): more focused unit tests

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* fix(test): amend suggestions

---------

Co-authored-by: Daan van der Plas <[email protected]>

* feat(mainnet): introduce assets (#465)

* refactor(mainnet): include assets

fmt

refactor(collator): not necessary import

* test(assets): add nfts config unit tests

* refactor(proxy): Add assets & smart contract proxy type

* refactor(assets): implement nfts runtime api

* fix(pallet-nfts-api): workspace linters are not defined

* docs(assets): clarify deposits

* chore(proxy): improve usage of references

* docs(assets): update src reference

* chore(assets): update MetadataDepositBase

* docs(assets): remove TODOs

* refactor(proxy): revert SmartContract ProxyType

* revert: e614927

* style(Cargo): revert format changes on dep comments

* chore(assets): apply feedback to tests

* chore(assets): removed unused type

* revert: fb92342

This reverts commit fb92342.

* docs(assets): better comments

* chore(assets): lower nfts deposit costs

* chore(assets): reduced deposit cost for AssetAccountDeposit

* chore(assets): use SDK's pallet_nfts

* chore(assets): better deposits & fmt Cargo

* chore(assets): better comments

* chore(assets): more explicit comments for deposits

* chore(assets): provide src for NftsCollectionDeposit deposit

* chore(assets): apply feedback

* chore(monetary): clean unnecessary comments

* chore(utility): make deposit calc explicit. (#469)

chore(utility): explicit deposit justification

rebase fixes

* chore(proxy): reintroduce Asset related proxy types

* syle(proxy): Clarify proxy test comments

---------

Co-authored-by: Daan van der Plas <[email protected]>
al3mart added a commit that referenced this pull request Feb 17, 2025
* refactor(mainnet): rebase changes

* chore(mainnet): update Cargo.lock

* refactor(mainnet): utility config (#438)

* refactor(mainnet): add pallet_multisig to utility

* test(mainnet): add pallet_multisig tests

* refactor(mainnet): add pallet_utility to utility

* test(mainnet): add pallet_utility tests

* refactor(mainnet): add pallet_preimage to utility

* test(mainnet): add pallet_preimage tests

* refactor(mainnet): add pallet_scheduler to utility

* test(mainnet): add pallet_scheduler tests

* refactor(mainnet): system config (#442)

* refactor(mainnet): add frame_system to system

* test(mainnet): add pallet_system test

* fix(mainnet): rebase fixes

* fix(system): bring missing types in scope

* refactor(system): add cumulus_parachain_system to system config module

* test(system): add cumulus_parachain_system tests

* refactor(system): add parachain_info into system config module

* refactor(system): add pallet_timestamp into system config module

* style(system): add ConsensusHook comment

* refactor(system): separate tests by module

* docs(system): document public config modules

* fix(system): allow unused_imports to remove Executive warning

* refactor(system): reintroduce FilteredCalls

* style(system): get rid of test prefixes

* style(system): relocate max_block_weigth comment

* test(system): check for Hash type config

* docs(system): amend outdated comments

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/mod.rs

Co-authored-by: Daan van der Plas <[email protected]>

---------

Co-authored-by: Daan van der Plas <[email protected]>

* refactor(mainnet): collation config (#439)

* refactor(mainnet): add pallet_authorship to collation

* test(mainnet): add pallet_auhtorship test

* refactor(mainnet): add pallet_aura to collation

* test(mainnet): add pallet_aura tests

* refactor(mainnet): add collator_selection to collation

* test(mainnet): add collator_selection tests

* refactor(mainnet): add pallet_session & aura_ext to collation

* test(mainnet): add pallet_session tests

* chore(aura): MaxAuthorities matches max possible blocks produced

* remove unnused imports

* style(collation): order tests following pallet config

* style(collation): remove unnecessary qualifications

* style(collation): max_authorities_is_3600

* style(collation): reorg definition in session_keys_provided_by_aura test

* style(collation): better Period  comment

* style(collation): clarify session::SessionHandler comment

* refactor(collation): separate tests in modules by pallet

* style(collation): Explain SessionHandler config

fixes after rebase

* style(collation): remove prefixes from tests

* style(collation): Period comment was not helpful

changes after rebase

* refactor(xcm): add pallet_message_queue into xcm config module

* test(xcm): add message_queue tests

* test(xcm): test location, transactor and barrier type definitions

* refactor(xcm): include pallet_xcmp_queue into xcm config module

* test(xcm): add pallet_xcmp_queue configuration tests

* test(xcm): add xcm_executor configuration tests

* test(xcm): adding pallet_xcm config tests

* fix(xcm): typo

fix(xcm): XcmReserveTransferFilter is Everything

* refactor(xcm): use unitype for MaxRemoteLockConsumers

* style(xcm): tests separated in modules

* style(xcm): better naming for XcmTeleportFilter test

* style(xcm): test naming and order

* docs(xcm): clarifying comments for specific xcmp_queueu types

* style(xcm): typo

* style(xcm): better name for reserves tests

* refactor(xcm): Use `NativeAssetFrom<T>` as `XcmReserveTransferFilter` (#459)

* refactor(xcm): Use NativeAssetFrom<T> as XcmReserveTransferFilter

style:fmt

* fix(xcm): NativeAssetFrom<AssetHub> filters everything but DOT from AH

* fix(xcm): XcmReserveTransferFilter filters only by asset

fix

changes after rebase

fmt

* fix(xcm): remove waived locations (#456)

* fix(xcm): no locations are waived

* test(xcm): improved waived_location test

changes after rebase

* style(xcm): clarify that we are not waiving fees for any location

* fix(xcm): charge delivery fees (#457)

* resolve rebase conflicts

* fix(xcm): reserve_transfer_native_asset_from_para_to_system_para accounts for delivery fees

* fix(integration-tests): handle delivery_fees only with mainnet feature on

fmt after rebase

fmt

changes after rebase

fmt

fmt

* test(xcm): address feedback from #459

typos

AssetFilter

* style(xcm): locate reserve tests within executor

lint

* fix(integration-test): improve tests & remove feature gated compilation

unnecessary Fungibles

* refactor: integration tests mainnet xcm (#466)

* refactor: integration tests mainnet xcm

* fix: remove unused ED

rebase

fmt

fmt

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* refactor(xcm): use TreasuryAccount from monetary

* chore(xcm): unused imports

* chore(xcm): amend test modules

* chore(integration-tests): amend reserve_transfer_native_asset_from_para_to_system

* chore(xcm): divive reserve filter test in two

* chore(xcm): fmt

* style(integration-tests): fix unwanted indentation

* test(xcm): more focused unit tests

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* Update runtime/mainnet/src/config/xcm.rs

Co-authored-by: Daan van der Plas <[email protected]>

* fix(test): amend suggestions

---------

Co-authored-by: Daan van der Plas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants