refactor(mainnet): pallet_proxy config & tests

[al3mart]

Extends proxy config module for the pallet:

• pallet_proxy

Notable configuration items are:

• pallet_proxy

Updated deposits for mainnet runtime:

// One storage item; key size 32 + 8.
pub const ProxyDepositBase: Balance = deposit(1, 40);
// Additional storage item size of AccountId 32 bytes + ProxyType 1 byte + BlockNum 4 bytes.
pub const ProxyDepositFactor: Balance = deposit(0, 37);
// One storage item; key size 32, value size 16.
pub const AnnouncementDepositBase: Balance = deposit(1, 48);
// Additional storage item 32 bytes AccountId + 32 bytes Hash + 4 bytes BlockNum.
pub const AnnouncementDepositFactor: Balance = deposit(0, 68);

type MaxPending = 32;
type MaxProxies = 32;

[sc-2205]

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 93.68421% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.46%. Comparing base (9594a3b) to head (f318840).
Report is 2 commits behind head on al3mart/refactor-mainnet-config.

Files with missing lines	Patch %	Lines
runtime/mainnet/src/config/proxy.rs	93.68%	6 Missing ⚠️

@@                         Coverage Diff                         @@
##           al3mart/refactor-mainnet-config     #441      +/-   ##
===================================================================
+ Coverage                            71.02%   71.46%   +0.44%     
===================================================================
  Files                                   73       75       +2     
  Lines                                13748    13971     +223     
  Branches                             13748    13971     +223     
===================================================================
+ Hits                                  9764     9984     +220     
- Misses                                3717     3720       +3     
  Partials                               267      267              

Files with missing lines	Coverage Δ
runtime/mainnet/src/config/proxy.rs	83.17% <93.68%> (+83.17%)	⬆️

... and 3 files with indirect coverage changes

[peterwht]

Only concern is around the ProxyDepositBase and ProxyDepositFactor.

1. Wasn't able to calculate the value size myself (so not sure where the 16 comes from)
2. Our deposits are several times more expensive than the polkadot relay.

[peterwht]

we have 6 times the amount of bytes Polkadot has. Any reason not to just align to the Polkadot relay chain on this: https://github.com/polkadot-fellows/runtimes/blob/main/relay/polkadot/src/lib.rs#L977

[al3mart]

Certainly. Double checking after your comment I'm also seeing that I did the following miscalculation:

the number we have for ProxyDepositBase was the result of adding AccountId + Balance, but I realize that we should be accounting for 8 bytes, which is the correct length of the key of the map.

I also added the bytes for Balance because the deposited amount is always stored. Although, as it is the size corresponding to the deposit itself, I could see why it is not being included on Polkadot's configuration.

ProxyDepositFactor reasoning in the comment above its declaration, what's the concern ?

[al3mart]

d4c936e

As discussed off GH this change updates ProxyDepositBase from deposit(1, 48) to deposit(1, 40).

[peterwht]

Nice! Thanks for resolving the deposit issue. Makes much more sense now.

[Daanvdplas]

Missing the explanation why are we not using the values from pop-common anymore. Other than that, looking good!

[Daanvdplas]

Nice! Thanks for the updated tests, very good!