Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testnet): mainnet & devnet into testnet runtime #482

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

al3mart
Copy link
Collaborator

@al3mart al3mart commented Mar 1, 2025

This PR introduces different features from mainnet and devnet runtimes into testnet.
And refactors some code just to make my work around the code a bit friendlier.

From mainnet:

From devnet:

[sc-2987]

@al3mart al3mart changed the title feat(testnet): mainnet & devnet into testnet runtime. feat(testnet): mainnet & devnet into testnet runtime Mar 1, 2025
@al3mart al3mart marked this pull request as ready for review March 1, 2025 04:22
@al3mart al3mart requested a review from a team March 1, 2025 04:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 3.42857% with 507 lines in your changes missing coverage. Please review.

Project coverage is 76.77%. Comparing base (980ef6e) to head (91aa0a1).

Files with missing lines Patch % Lines
runtime/testnet/src/apis.rs 0.00% 460 Missing ⚠️
runtime/testnet/src/config/monetary.rs 0.00% 25 Missing ⚠️
runtime/testnet/src/lib.rs 0.00% 14 Missing ⚠️
runtime/testnet/src/config/contracts.rs 0.00% 5 Missing ⚠️
runtime/testnet/src/config/xcm.rs 0.00% 2 Missing ⚠️
runtime/testnet/src/genesis.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   77.38%   76.77%   -0.61%     
==========================================
  Files          93       95       +2     
  Lines       18758    18888     +130     
  Branches    18758    18888     +130     
==========================================
- Hits        14515    14501      -14     
- Misses       3977     4121     +144     
  Partials      266      266              
Files with missing lines Coverage Δ
node/src/command.rs 0.00% <ø> (ø)
runtime/testnet/src/config/proxy.rs 0.00% <ø> (ø)
runtime/testnet/src/config/system.rs 100.00% <100.00%> (ø)
runtime/testnet/src/genesis.rs 0.00% <0.00%> (ø)
runtime/testnet/src/config/xcm.rs 0.00% <0.00%> (ø)
runtime/testnet/src/config/contracts.rs 66.66% <0.00%> (-17.55%) ⬇️
runtime/testnet/src/lib.rs 15.55% <0.00%> (+9.25%) ⬆️
runtime/testnet/src/config/monetary.rs 0.00% <0.00%> (ø)
runtime/testnet/src/apis.rs 0.00% <0.00%> (ø)

Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! No concerns here.

  • Mainnet / testnet diffs show minimal config differences. The ones that exist aren't relevant to the goal here
  • All configs moved from testnet lib.rs to individual modules are also fine without any concerning changes
  • APIs are good as well

>;

/// SUDO account set at genesis.
const SUDO_ACCOUNT: &str = "5FPL3ZLqUk6MyBoZrQZ1Co29WAteX6T6N68TZ6jitHvhpyuD";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just notes for other reviewers: this is the correct Sudo address as exists on Testnet currently.

Screenshot 2025-03-03 at 11 20 37 AM
Screenshot 2025-03-03 at 11 20 46 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants