-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testnet): mainnet & devnet into testnet runtime #482
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 77.38% 76.77% -0.61%
==========================================
Files 93 95 +2
Lines 18758 18888 +130
Branches 18758 18888 +130
==========================================
- Hits 14515 14501 -14
- Misses 3977 4121 +144
Partials 266 266
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving! No concerns here.
- Mainnet / testnet diffs show minimal config differences. The ones that exist aren't relevant to the goal here
- All configs moved from testnet lib.rs to individual modules are also fine without any concerning changes
- APIs are good as well
>; | ||
|
||
/// SUDO account set at genesis. | ||
const SUDO_ACCOUNT: &str = "5FPL3ZLqUk6MyBoZrQZ1Co29WAteX6T6N68TZ6jitHvhpyuD"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR introduces different features from mainnet and devnet runtimes into testnet.
And refactors some code just to make my work around the code a bit friendlier.
From mainnet:
From devnet:
[sc-2987]