feat(mainnet): Add treasury pallet and handle fees #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-gate
changed the title
f-gate
requested review from
peterwht,
evilrobot-01,
chungquantin and
Daanvdplas
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #428 +/- ##
==========================================
- Coverage 71.02% 70.86% -0.17%
==========================================
Files 73 74 +1
Lines 13748 14170 +422
Branches 13748 14170 +422
==========================================
+ Hits 9764 10041 +277
- Misses 3717 3861 +144
- Partials 267 268 +1
|
|
Could we please add a unit test to ensure the fee split is accurately distributed. Will send DM. |
peterwht
requested changes
Jan 22, 2025
peterwht
approved these changes
Jan 29, 2025
peterwht
approved these changes
Jan 29, 2025
Daanvdplas
approved these changes
Jan 30, 2025
al3mart
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Looks great!
It looks like there are a couple of imports that could be removed as they are not being used.
A few config items for pallet_treasury aren't being check on the tests. I think we could add them. Maybe I'm too paranoid ?
Also I'd like to rise the point that right now we are not funneling any fee % for block production. Which might be desired for now or handled later one.
peterwht
approved these changes
Jan 30, 2025
al3mart
approved these changes
Jan 30, 2025
11 tasks
chungquantin
pushed a commit
that referenced
this pull request
Feb 3, 2025
* add treasury pallet to runtime * add treasury pallet * add features * clean * fmt * remove-comment * add a sanity test, clean * fmt * fix * comment out and strip back * update to patch version * back to normality, builds good * fmt * add integration tests back * taplo * dont burn anything * finally tests * fmt * moar tests :) * fmt * use onunbalanced * daans comments * fmt * docs * peters comments * franks comments * fmt * style: fmt * chore(mainnet): remove unused imports * test(mainnet): more tresaury config tests --------- Co-authored-by: Felix G <[email protected]> Co-authored-by: f-gate <[email protected]> Co-authored-by: Peter White <[email protected]>
chungquantin
pushed a commit
that referenced
this pull request
Feb 3, 2025
* add treasury pallet to runtime * add treasury pallet * add features * clean * fmt * remove-comment * add a sanity test, clean * fmt * fix * comment out and strip back * update to patch version * back to normality, builds good * fmt * add integration tests back * taplo * dont burn anything * finally tests * fmt * moar tests :) * fmt * use onunbalanced * daans comments * fmt * docs * peters comments * franks comments * fmt * style: fmt * chore(mainnet): remove unused imports * test(mainnet): more tresaury config tests --------- Co-authored-by: Felix G <[email protected]> Co-authored-by: f-gate <[email protected]> Co-authored-by: Peter White <[email protected]>
chungquantin
added a commit
that referenced
this pull request
Feb 4, 2025
* chore: rebase * chore: rebase nonfungibles pallet to pallet-nfts * chore: update nonfungibles tests * refactor: do_approve and do_cancel_approval * chore: naming * chore: resolve review comments * chore: resolve review comments & update weights * chore: add tests for nonfungibles api in runtime devnet * fix: integration test & return post dispatch weight for transfer() on error * refactor: reorder `Read` impl in nonfungibles * chore: remove unnecessary clone() * chore: remove description for pallet configure * refactor: approve() tests * chore: resolve review comments * feat: add AttributeSet event * chore: comments and add test for Collection read * chore: revert changes made to pallet nfts * chore: fix comment * chore: resolve review comments * chore: update function order * chore: add release conventions document and refactor CI to run node release separately (#433) * refactor: reuse `WeightInfo` in nonfungibles pallet test (#450) * chore: update collection details field to public (#449) * chore: rebase and remove local collection details type * chore: remove impls.rs and update burn() * chore: remove double-charged weights * chore: reorder test and update comments * fix: test * chore: sync spec * chore: revert changes made to mint witness * chore: update approve() and tests * chore: resolve review comments * chore: add more comment to dispatchables * chore: revert changes * refactor: approve weight * chore: update approve() weight * chore: update approve weight * refactor: weight approve (#460) * feat(mainnet): add XCM APIs, config tests, refactor mod (#447) * test(mainnet): more configuration tests * refactor(mainnet): runtime APIs to apis module * feat(mainnet): add XCM runtime APIs * feat(mainnet): add pallet revive (#452) * feat(mainnet): add pallet-revive * test(mainnet): revive configuration tests refactor(mainnet): import revive config for tests and use consistent pallet syntax fix(mainnet): UncheckedExtrinsic test needs to use revive unchecked extrinsics * feat(mainnet): add EthExtraImpl for UncheckedExtrinsic * feat(mainnet): add `EventRecord` type * docs(mainnet): add config comments for revive * test(mainnet): check percent value in revive config test * docs(mainnet): update comments on EthExtraImpl * chore(mainnet): remove unnecessary revive path prefix * feat(mainnet): Add treasury pallet and handle fees (#428) * add treasury pallet to runtime * add treasury pallet * add features * clean * fmt * remove-comment * add a sanity test, clean * fmt * fix * comment out and strip back * update to patch version * back to normality, builds good * fmt * add integration tests back * taplo * dont burn anything * finally tests * fmt * moar tests :) * fmt * use onunbalanced * daans comments * fmt * docs * peters comments * franks comments * fmt * style: fmt * chore(mainnet): remove unused imports * test(mainnet): more tresaury config tests --------- Co-authored-by: Felix G <[email protected]> Co-authored-by: f-gate <[email protected]> Co-authored-by: Peter White <[email protected]> * chore: revert pallet-nfts changes * chore: update weights * chore: update index of the dispatchables * chore: remove Collection read As discussed in #432 (comment), the Collection read might not be needed and there are better ways to implement it in the future if there is a demand for it. * chore: add TODO comment for approve weight --------- Co-authored-by: Daan van der Plas <[email protected]> Co-authored-by: Peter White <[email protected]> Co-authored-by: gatsey <[email protected]> Co-authored-by: Felix G <[email protected]> Co-authored-by: f-gate <[email protected]>
chungquantin
added a commit
that referenced
this pull request
Feb 11, 2025
* chore: rebase * chore: rebase nonfungibles pallet to pallet-nfts * chore: update nonfungibles tests * refactor: do_approve and do_cancel_approval * chore: naming * chore: resolve review comments * chore: resolve review comments & update weights * chore: add tests for nonfungibles api in runtime devnet * fix: integration test & return post dispatch weight for transfer() on error * refactor: reorder `Read` impl in nonfungibles * chore: remove unnecessary clone() * chore: remove description for pallet configure * refactor: approve() tests * chore: resolve review comments * feat: add AttributeSet event * chore: comments and add test for Collection read * chore: revert changes made to pallet nfts * chore: fix comment * chore: resolve review comments * chore: update function order * chore: add release conventions document and refactor CI to run node release separately (#433) * refactor: reuse `WeightInfo` in nonfungibles pallet test (#450) * chore: update collection details field to public (#449) * chore: rebase and remove local collection details type * chore: remove impls.rs and update burn() * chore: remove double-charged weights * chore: reorder test and update comments * fix: test * chore: sync spec * chore: revert changes made to mint witness * chore: update approve() and tests * chore: resolve review comments * chore: add more comment to dispatchables * chore: revert changes * refactor: approve weight * chore: update approve() weight * chore: update approve weight * refactor: weight approve (#460) * feat(mainnet): add XCM APIs, config tests, refactor mod (#447) * test(mainnet): more configuration tests * refactor(mainnet): runtime APIs to apis module * feat(mainnet): add XCM runtime APIs * feat(mainnet): add pallet revive (#452) * feat(mainnet): add pallet-revive * test(mainnet): revive configuration tests refactor(mainnet): import revive config for tests and use consistent pallet syntax fix(mainnet): UncheckedExtrinsic test needs to use revive unchecked extrinsics * feat(mainnet): add EthExtraImpl for UncheckedExtrinsic * feat(mainnet): add `EventRecord` type * docs(mainnet): add config comments for revive * test(mainnet): check percent value in revive config test * docs(mainnet): update comments on EthExtraImpl * chore(mainnet): remove unnecessary revive path prefix * feat(mainnet): Add treasury pallet and handle fees (#428) * add treasury pallet to runtime * add treasury pallet * add features * clean * fmt * remove-comment * add a sanity test, clean * fmt * fix * comment out and strip back * update to patch version * back to normality, builds good * fmt * add integration tests back * taplo * dont burn anything * finally tests * fmt * moar tests :) * fmt * use onunbalanced * daans comments * fmt * docs * peters comments * franks comments * fmt * style: fmt * chore(mainnet): remove unused imports * test(mainnet): more tresaury config tests --------- Co-authored-by: Felix G <[email protected]> Co-authored-by: f-gate <[email protected]> Co-authored-by: Peter White <[email protected]> * chore: revert pallet-nfts changes * chore: update weights * feat: pop-api nonfungibles feature * fix: integration tests * chore: remove integration tests * chore: remove integration tests * chore: remove integration tests * chore: update comments and add README * chore: update index of the dispatchables * chore: update index of the dispatchables * chore: update index of reads & dispatchables * chore: add comments for api methods * chore: update index of the dispatchables * chore: update types * chore: update traits & types, map psp34 error * chore: remove Collection read As discussed in #432 (comment), the Collection read might not be needed and there are better ways to implement it in the future if there is a demand for it. * chore: add TODO comment for approve weight * chore: update pallet dispatchable index * chore: remove redundant type in macro * feat: pop-api nonfungibles feature * chore: rebase * chore: rebase * chore: remove changes made for integration-tests * fix: comments * chore: remove unused derive * refactor: remove `Decode` derive * chore: remove macro * chore: revert macro * chore: revert macro TypeInfo * feat: add Psp34Mintable and Psp34Burnable * chore: add macro comment * chore: fix trait error type * chore: add tests for nonfungibles api types * refactor: dependencies order * chore: remove unused types * fix: comment Co-authored-by: Daan van der Plas <[email protected]> * chore: revert CollectionConfigOf --------- Co-authored-by: Daan van der Plas <[email protected]> Co-authored-by: Peter White <[email protected]> Co-authored-by: gatsey <[email protected]>
chungquantin
added a commit
that referenced
this pull request
Feb 25, 2025
* chore: rebase * chore: rebase nonfungibles pallet to pallet-nfts * chore: update nonfungibles tests * refactor: do_approve and do_cancel_approval * chore: naming * chore: resolve review comments * chore: resolve review comments & update weights * chore: add tests for nonfungibles api in runtime devnet * fix: integration test & return post dispatch weight for transfer() on error * refactor: reorder `Read` impl in nonfungibles * chore: remove unnecessary clone() * chore: remove description for pallet configure * refactor: approve() tests * chore: resolve review comments * feat: add AttributeSet event * chore: comments and add test for Collection read * chore: revert changes made to pallet nfts * chore: fix comment * chore: resolve review comments * chore: update function order * chore: add release conventions document and refactor CI to run node release separately (#433) * refactor: reuse `WeightInfo` in nonfungibles pallet test (#450) * chore: update collection details field to public (#449) * chore: rebase and remove local collection details type * chore: remove impls.rs and update burn() * chore: remove double-charged weights * chore: reorder test and update comments * fix: test * chore: sync spec * chore: revert changes made to mint witness * chore: update approve() and tests * chore: resolve review comments * chore: add more comment to dispatchables * chore: revert changes * refactor: approve weight * chore: update approve() weight * chore: update approve weight * refactor: weight approve (#460) * feat(mainnet): add XCM APIs, config tests, refactor mod (#447) * test(mainnet): more configuration tests * refactor(mainnet): runtime APIs to apis module * feat(mainnet): add XCM runtime APIs * feat(mainnet): add pallet revive (#452) * feat(mainnet): add pallet-revive * test(mainnet): revive configuration tests refactor(mainnet): import revive config for tests and use consistent pallet syntax fix(mainnet): UncheckedExtrinsic test needs to use revive unchecked extrinsics * feat(mainnet): add EthExtraImpl for UncheckedExtrinsic * feat(mainnet): add `EventRecord` type * docs(mainnet): add config comments for revive * test(mainnet): check percent value in revive config test * docs(mainnet): update comments on EthExtraImpl * chore(mainnet): remove unnecessary revive path prefix * feat(mainnet): Add treasury pallet and handle fees (#428) * add treasury pallet to runtime * add treasury pallet * add features * clean * fmt * remove-comment * add a sanity test, clean * fmt * fix * comment out and strip back * update to patch version * back to normality, builds good * fmt * add integration tests back * taplo * dont burn anything * finally tests * fmt * moar tests :) * fmt * use onunbalanced * daans comments * fmt * docs * peters comments * franks comments * fmt * style: fmt * chore(mainnet): remove unused imports * test(mainnet): more tresaury config tests --------- Co-authored-by: Felix G <[email protected]> Co-authored-by: f-gate <[email protected]> Co-authored-by: Peter White <[email protected]> * chore: revert pallet-nfts changes * chore: update weights * feat: pop-api nonfungibles feature * fix: integration tests * chore: remove integration tests * chore: remove integration tests * chore: remove integration tests * chore: update comments and add README * chore: update index of the dispatchables * chore: update index of the dispatchables * chore: update index of reads & dispatchables * chore: add comments for api methods * chore: update index of the dispatchables * chore: update types * chore: update traits & types, map psp34 error * chore: remove Collection read As discussed in #432 (comment), the Collection read might not be needed and there are better ways to implement it in the future if there is a demand for it. * chore: add TODO comment for approve weight * chore: update pallet dispatchable index * chore: remove redundant type in macro * feat: pop-api nonfungibles feature * chore: rebase * chore: rebase * chore: remove changes made for integration-tests * fix: comments * chore: remove unused derive * refactor: remove `Decode` derive * chore: remove macro * chore: rebase * refactor: do_approve and do_cancel_approval * chore: naming * chore: resolve review comments & update weights * chore: add tests for nonfungibles api in runtime devnet * chore: remove description for pallet configure * refactor: approve() tests * chore: comments and add test for Collection read * chore: revert changes made to pallet nfts * chore: resolve review comments * chore: update function order * chore: rebase and remove local collection details type * chore: remove impls.rs and update burn() * chore: remove double-charged weights * fix: test * chore: sync spec * chore: revert changes made to mint witness * chore: resolve review comments * chore: add more comment to dispatchables * chore: revert changes * refactor: approve weight * chore: update approve() weight * refactor: weight approve (#460) * chore: revert pallet-nfts changes * feat: pop-api nonfungibles feature * fix: integration tests * chore: remove integration tests * chore: remove integration tests * chore: update comments and add README * Revert "chore: update comments and add README" This reverts commit b86e68b. * Revert "chore: remove integration tests" This reverts commit 5e6b685. * Revert "chore: remove integration tests" This reverts commit baeb5ea. * chore: fix test * chore: remove collection read test * chore: disable devnet feature for nonfungibles * chore: revert changes * chore: revert macro * chore: revert devnet runtime changes * chore: revert macro TypeInfo * feat: add Psp34Mintable and Psp34Burnable * chore: add macro comment * chore: fix trait error type * chore: add tests for nonfungibles api types * refactor: dependencies order * chore: remove unused types * fix: comment Co-authored-by: Daan van der Plas <[email protected]> * chore: revert macro TypeInfo * feat: add Psp34Mintable and Psp34Burnable * chore: add macro comment * chore: fix trait error type * chore: add tests for nonfungibles api types * refactor: dependencies order * chore: remove unused types * fix: comment Co-authored-by: Daan van der Plas <[email protected]> * feat: pop-api nonfungibles feature * chore: revert changes * chore: rebase * chore: revert CollectionConfigOf * chore: revert changes made to pop-api * chore: revert CollectionConfigOf * feat: pop-api nonfungibles feature * chore: revert changes * chore: revert changes * chore: rebase * refactor: storage type aliases * refactor: test order * refactor: integration test method params order * fix: test * chore: remove unused dependencies * chore: remove features * chore: resolve review comments --------- Co-authored-by: Daan van der Plas <[email protected]> Co-authored-by: Peter White <[email protected]> Co-authored-by: gatsey <[email protected]> Co-authored-by: Felix G <[email protected]> Co-authored-by: f-gate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added the treasury pallet with reasonable parameters and have taken inspiration from polkadot and rococo for these. The only one really of concern is
MaxSpendi have left it as u32::MAX.The
DealWithFeessimply takes both the fees and tips and splits equally between the newly createdTreasuryAccountandMaintenenceAccount.In the future i will split the tasks down into 2 PRs as Peter and i discussed yesterday.
[sc-2260]
[sc-2199]