Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add release conventions document and refactor CI to run node release separately #433

Merged
merged 3 commits into from
Jan 22, 2025
Merged

chore: add release conventions document and refactor CI to run node release separately #433

merged 3 commits into from
Jan 22, 2025

Conversation

Daanvdplas
Copy link
Collaborator

@Daanvdplas Daanvdplas commented Jan 16, 2025 •
edited
Loading

This PR does two things (apologies for not separating them, will do next time).

  1. Lines out the release conventions. View here: https://github.com/r0gue-io/pop-node/blob/daan/docs-release_conventions/docs/release.md
  2. Refactors the CI so that it is clear how to manually run the job to build the release for a node without a runtime build (works). As well as having the CI pickup automatically when a release title is created with node (works).

[sc-2432]

@Daanvdplas Daanvdplas force-pushed the daan/docs-release_conventions branch from 3ac7338 to 0d1203c Compare January 16, 2025 08:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.41%. Comparing base (8fb843f) to head (f6d78df).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   68.31%   71.41%   +3.10%     
==========================================
  Files          70       72       +2     
  Lines       11764    13568    +1804     
  Branches    11764    13568    +1804     
==========================================
+ Hits         8036     9690    +1654     
- Misses       3470     3605     +135     
- Partials      258      273      +15

see 20 files with indirect coverage changes

@Daanvdplas Daanvdplas force-pushed the daan/docs-release_conventions branch from 0d1203c to a3036fa Compare January 16, 2025 13:21
@Daanvdplas Daanvdplas marked this pull request as ready for review January 16, 2025 13:21
@Daanvdplas Daanvdplas changed the title docs: release conventions chore: add release conventions document and refactor CI to run node release separately Jan 16, 2025
@Daanvdplas Daanvdplas merged commit 8b2438b into main Jan 22, 2025
30 checks passed
@Daanvdplas Daanvdplas deleted the daan/docs-release_conventions branch January 22, 2025 09:03
chungquantin pushed a commit that referenced this pull request Jan 24, 2025
@Daanvdplas @chungquantin
chore: add release conventions document and refactor CI to run node r…
ac68a1f 
…elease separately (#433)
chungquantin added a commit that referenced this pull request Feb 4, 2025
@chungquantin @Daanvdplas
@peterwht @f-gate
feat: add pallet-api/nonfungibles (#432)
168cf85 
* chore: rebase

* chore: rebase nonfungibles pallet to pallet-nfts

* chore: update nonfungibles tests

* refactor: do_approve and do_cancel_approval

* chore: naming

* chore: resolve review comments

* chore: resolve review comments & update weights

* chore: add tests for nonfungibles api in runtime devnet

* fix: integration test & return post dispatch weight for transfer() on error

* refactor: reorder `Read` impl in nonfungibles

* chore: remove unnecessary clone()

* chore: remove description for pallet configure

* refactor: approve() tests

* chore: resolve review comments

* feat: add AttributeSet event

* chore: comments and add test for Collection read

* chore: revert changes made to pallet nfts

* chore: fix comment

* chore: resolve review comments

* chore: update function order

* chore: add release conventions document and refactor CI to run node release separately (#433)

* refactor: reuse `WeightInfo` in nonfungibles pallet test (#450)

* chore: update collection details field to public (#449)

* chore: rebase and remove local collection details type

* chore: remove impls.rs and update burn()

* chore: remove double-charged weights

* chore: reorder test and update comments

* fix: test

* chore: sync spec

* chore: revert changes made to mint witness

* chore: update approve() and tests

* chore: resolve review comments

* chore: add more comment to dispatchables

* chore: revert changes

* refactor: approve weight

* chore: update approve() weight

* chore: update approve weight

* refactor: weight approve (#460)

* feat(mainnet): add XCM APIs, config tests, refactor mod (#447)

* test(mainnet): more configuration tests

* refactor(mainnet): runtime APIs to apis module

* feat(mainnet): add XCM runtime APIs

* feat(mainnet): add pallet revive (#452)

* feat(mainnet): add pallet-revive

* test(mainnet): revive configuration tests

refactor(mainnet): import revive config for tests and use consistent pallet syntax

fix(mainnet): UncheckedExtrinsic test needs to use revive unchecked extrinsics

* feat(mainnet): add EthExtraImpl for UncheckedExtrinsic

* feat(mainnet): add `EventRecord` type

* docs(mainnet): add config comments for revive

* test(mainnet): check percent value in revive config test

* docs(mainnet): update comments on EthExtraImpl

* chore(mainnet): remove unnecessary revive path prefix

* feat(mainnet): Add treasury pallet and handle fees (#428)

* add treasury pallet to runtime

* add treasury pallet

* add features

* clean

* fmt

* remove-comment

* add a sanity test, clean

* fmt

* fix

* comment out and strip back

* update to patch version

* back to normality, builds good

* fmt

* add integration tests back

* taplo

* dont burn anything

* finally tests

* fmt

* moar tests :)

* fmt

* use onunbalanced

* daans comments

* fmt

* docs

* peters comments

* franks comments

* fmt

* style: fmt

* chore(mainnet): remove unused imports

* test(mainnet): more tresaury config tests

---------

Co-authored-by: Felix G <[email protected]>
Co-authored-by: f-gate <[email protected]>
Co-authored-by: Peter White <[email protected]>

* chore: revert pallet-nfts changes

* chore: update weights

* chore: update index of the dispatchables

* chore: remove Collection read

As discussed in #432 (comment), the Collection read might not be needed and there are better ways to implement it in the future if there is a demand for it.

* chore: add TODO comment for approve weight

---------

Co-authored-by: Daan van der Plas <[email protected]>
Co-authored-by: Peter White <[email protected]>
Co-authored-by: gatsey <[email protected]>
Co-authored-by: Felix G <[email protected]>
Co-authored-by: f-gate <[email protected]>
chungquantin added a commit that referenced this pull request Feb 11, 2025
@chungquantin @Daanvdplas
@peterwht @f-gate
feat: pop-api nonfungibles implementation (#461)
76128fc 
* chore: rebase

* chore: rebase nonfungibles pallet to pallet-nfts

* chore: update nonfungibles tests

* refactor: do_approve and do_cancel_approval

* chore: naming

* chore: resolve review comments

* chore: resolve review comments & update weights

* chore: add tests for nonfungibles api in runtime devnet

* fix: integration test & return post dispatch weight for transfer() on error

* refactor: reorder `Read` impl in nonfungibles

* chore: remove unnecessary clone()

* chore: remove description for pallet configure

* refactor: approve() tests

* chore: resolve review comments

* feat: add AttributeSet event

* chore: comments and add test for Collection read

* chore: revert changes made to pallet nfts

* chore: fix comment

* chore: resolve review comments

* chore: update function order

* chore: add release conventions document and refactor CI to run node release separately (#433)

* refactor: reuse `WeightInfo` in nonfungibles pallet test (#450)

* chore: update collection details field to public (#449)

* chore: rebase and remove local collection details type

* chore: remove impls.rs and update burn()

* chore: remove double-charged weights

* chore: reorder test and update comments

* fix: test

* chore: sync spec

* chore: revert changes made to mint witness

* chore: update approve() and tests

* chore: resolve review comments

* chore: add more comment to dispatchables

* chore: revert changes

* refactor: approve weight

* chore: update approve() weight

* chore: update approve weight

* refactor: weight approve (#460)

* feat(mainnet): add XCM APIs, config tests, refactor mod (#447)

* test(mainnet): more configuration tests

* refactor(mainnet): runtime APIs to apis module

* feat(mainnet): add XCM runtime APIs

* feat(mainnet): add pallet revive (#452)

* feat(mainnet): add pallet-revive

* test(mainnet): revive configuration tests

refactor(mainnet): import revive config for tests and use consistent pallet syntax

fix(mainnet): UncheckedExtrinsic test needs to use revive unchecked extrinsics

* feat(mainnet): add EthExtraImpl for UncheckedExtrinsic

* feat(mainnet): add `EventRecord` type

* docs(mainnet): add config comments for revive

* test(mainnet): check percent value in revive config test

* docs(mainnet): update comments on EthExtraImpl

* chore(mainnet): remove unnecessary revive path prefix

* feat(mainnet): Add treasury pallet and handle fees (#428)

* add treasury pallet to runtime

* add treasury pallet

* add features

* clean

* fmt

* remove-comment

* add a sanity test, clean

* fmt

* fix

* comment out and strip back

* update to patch version

* back to normality, builds good

* fmt

* add integration tests back

* taplo

* dont burn anything

* finally tests

* fmt

* moar tests :)

* fmt

* use onunbalanced

* daans comments

* fmt

* docs

* peters comments

* franks comments

* fmt

* style: fmt

* chore(mainnet): remove unused imports

* test(mainnet): more tresaury config tests

---------

Co-authored-by: Felix G <[email protected]>
Co-authored-by: f-gate <[email protected]>
Co-authored-by: Peter White <[email protected]>

* chore: revert pallet-nfts changes

* chore: update weights

* feat: pop-api nonfungibles feature

* fix: integration tests

* chore: remove integration tests

* chore: remove integration tests

* chore: remove integration tests

* chore: update comments and add README

* chore: update index of the dispatchables

* chore: update index of the dispatchables

* chore: update index of reads & dispatchables

* chore: add comments for api methods

* chore: update index of the dispatchables

* chore: update types

* chore: update traits & types, map psp34 error

* chore: remove Collection read

As discussed in #432 (comment), the Collection read might not be needed and there are better ways to implement it in the future if there is a demand for it.

* chore: add TODO comment for approve weight

* chore: update pallet dispatchable index

* chore: remove redundant type in macro

* feat: pop-api nonfungibles feature

* chore: rebase

* chore: rebase

* chore: remove changes made for integration-tests

* fix: comments

* chore: remove unused derive

* refactor: remove `Decode` derive

* chore: remove macro

* chore: revert macro

* chore: revert macro TypeInfo

* feat: add Psp34Mintable and Psp34Burnable

* chore: add macro comment

* chore: fix trait error type

* chore: add tests for nonfungibles api types

* refactor: dependencies order

* chore: remove unused types

* fix: comment

Co-authored-by: Daan van der Plas <[email protected]>

* chore: revert CollectionConfigOf

---------

Co-authored-by: Daan van der Plas <[email protected]>
Co-authored-by: Peter White <[email protected]>
Co-authored-by: gatsey <[email protected]>
chungquantin added a commit that referenced this pull request Feb 25, 2025
@chungquantin @Daanvdplas
@peterwht @f-gate
feat: pop-api nonfungibles integration tests (#462)
be93f6b 
* chore: rebase

* chore: rebase nonfungibles pallet to pallet-nfts

* chore: update nonfungibles tests

* refactor: do_approve and do_cancel_approval

* chore: naming

* chore: resolve review comments

* chore: resolve review comments & update weights

* chore: add tests for nonfungibles api in runtime devnet

* fix: integration test & return post dispatch weight for transfer() on error

* refactor: reorder `Read` impl in nonfungibles

* chore: remove unnecessary clone()

* chore: remove description for pallet configure

* refactor: approve() tests

* chore: resolve review comments

* feat: add AttributeSet event

* chore: comments and add test for Collection read

* chore: revert changes made to pallet nfts

* chore: fix comment

* chore: resolve review comments

* chore: update function order

* chore: add release conventions document and refactor CI to run node release separately (#433)

* refactor: reuse `WeightInfo` in nonfungibles pallet test (#450)

* chore: update collection details field to public (#449)

* chore: rebase and remove local collection details type

* chore: remove impls.rs and update burn()

* chore: remove double-charged weights

* chore: reorder test and update comments

* fix: test

* chore: sync spec

* chore: revert changes made to mint witness

* chore: update approve() and tests

* chore: resolve review comments

* chore: add more comment to dispatchables

* chore: revert changes

* refactor: approve weight

* chore: update approve() weight

* chore: update approve weight

* refactor: weight approve (#460)

* feat(mainnet): add XCM APIs, config tests, refactor mod (#447)

* test(mainnet): more configuration tests

* refactor(mainnet): runtime APIs to apis module

* feat(mainnet): add XCM runtime APIs

* feat(mainnet): add pallet revive (#452)

* feat(mainnet): add pallet-revive

* test(mainnet): revive configuration tests

refactor(mainnet): import revive config for tests and use consistent pallet syntax

fix(mainnet): UncheckedExtrinsic test needs to use revive unchecked extrinsics

* feat(mainnet): add EthExtraImpl for UncheckedExtrinsic

* feat(mainnet): add `EventRecord` type

* docs(mainnet): add config comments for revive

* test(mainnet): check percent value in revive config test

* docs(mainnet): update comments on EthExtraImpl

* chore(mainnet): remove unnecessary revive path prefix

* feat(mainnet): Add treasury pallet and handle fees (#428)

* add treasury pallet to runtime

* add treasury pallet

* add features

* clean

* fmt

* remove-comment

* add a sanity test, clean

* fmt

* fix

* comment out and strip back

* update to patch version

* back to normality, builds good

* fmt

* add integration tests back

* taplo

* dont burn anything

* finally tests

* fmt

* moar tests :)

* fmt

* use onunbalanced

* daans comments

* fmt

* docs

* peters comments

* franks comments

* fmt

* style: fmt

* chore(mainnet): remove unused imports

* test(mainnet): more tresaury config tests

---------

Co-authored-by: Felix G <[email protected]>
Co-authored-by: f-gate <[email protected]>
Co-authored-by: Peter White <[email protected]>

* chore: revert pallet-nfts changes

* chore: update weights

* feat: pop-api nonfungibles feature

* fix: integration tests

* chore: remove integration tests

* chore: remove integration tests

* chore: remove integration tests

* chore: update comments and add README

* chore: update index of the dispatchables

* chore: update index of the dispatchables

* chore: update index of reads & dispatchables

* chore: add comments for api methods

* chore: update index of the dispatchables

* chore: update types

* chore: update traits & types, map psp34 error

* chore: remove Collection read

As discussed in #432 (comment), the Collection read might not be needed and there are better ways to implement it in the future if there is a demand for it.

* chore: add TODO comment for approve weight

* chore: update pallet dispatchable index

* chore: remove redundant type in macro

* feat: pop-api nonfungibles feature

* chore: rebase

* chore: rebase

* chore: remove changes made for integration-tests

* fix: comments

* chore: remove unused derive

* refactor: remove `Decode` derive

* chore: remove macro

* chore: rebase

* refactor: do_approve and do_cancel_approval

* chore: naming

* chore: resolve review comments & update weights

* chore: add tests for nonfungibles api in runtime devnet

* chore: remove description for pallet configure

* refactor: approve() tests

* chore: comments and add test for Collection read

* chore: revert changes made to pallet nfts

* chore: resolve review comments

* chore: update function order

* chore: rebase and remove local collection details type

* chore: remove impls.rs and update burn()

* chore: remove double-charged weights

* fix: test

* chore: sync spec

* chore: revert changes made to mint witness

* chore: resolve review comments

* chore: add more comment to dispatchables

* chore: revert changes

* refactor: approve weight

* chore: update approve() weight

* refactor: weight approve (#460)

* chore: revert pallet-nfts changes

* feat: pop-api nonfungibles feature

* fix: integration tests

* chore: remove integration tests

* chore: remove integration tests

* chore: update comments and add README

* Revert "chore: update comments and add README"

This reverts commit b86e68b.

* Revert "chore: remove integration tests"

This reverts commit 5e6b685.

* Revert "chore: remove integration tests"

This reverts commit baeb5ea.

* chore: fix test

* chore: remove collection read test

* chore: disable devnet feature for nonfungibles

* chore: revert changes

* chore: revert macro

* chore: revert devnet runtime changes

* chore: revert macro TypeInfo

* feat: add Psp34Mintable and Psp34Burnable

* chore: add macro comment

* chore: fix trait error type

* chore: add tests for nonfungibles api types

* refactor: dependencies order

* chore: remove unused types

* fix: comment

Co-authored-by: Daan van der Plas <[email protected]>

* chore: revert macro TypeInfo

* feat: add Psp34Mintable and Psp34Burnable

* chore: add macro comment

* chore: fix trait error type

* chore: add tests for nonfungibles api types

* refactor: dependencies order

* chore: remove unused types

* fix: comment

Co-authored-by: Daan van der Plas <[email protected]>

* feat: pop-api nonfungibles feature

* chore: revert changes

* chore: rebase

* chore: revert CollectionConfigOf

* chore: revert changes made to pop-api

* chore: revert CollectionConfigOf

* feat: pop-api nonfungibles feature

* chore: revert changes

* chore: revert changes

* chore: rebase

* refactor: storage type aliases

* refactor: test order

* refactor: integration test method params order

* fix: test

* chore: remove unused dependencies

* chore: remove features

* chore: resolve review comments

---------

Co-authored-by: Daan van der Plas <[email protected]>
Co-authored-by: Peter White <[email protected]>
Co-authored-by: gatsey <[email protected]>
Co-authored-by: Felix G <[email protected]>
Co-authored-by: f-gate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al3mart al3mart al3mart approved these changes

@chungquantin chungquantin chungquantin approved these changes

@evilrobot-01 evilrobot-01 Awaiting requested review from evilrobot-01

@peterwht peterwht Awaiting requested review from peterwht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Daanvdplas @codecov-commenter @al3mart @chungquantin