Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pop-api nonfungibles integration tests #462

Merged
merged 148 commits into from
Feb 25, 2025
Merged

feat: pop-api nonfungibles integration tests #462

merged 148 commits into from
Feb 25, 2025

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Feb 3, 2025 •
edited
Loading

Integration tests for #461

The test structure for each API methods follow:

  1. Test if at least one error thrown from the API method and decoded correctly.
  2. Test if the API method can be executed successfully.
  3. Test if the event is emitted from the API method.

[sc-1243]

chungquantin and others added 30 commits January 22, 2025 12:13
@chungquantin
chore: rebase
0ae0d7b
@chungquantin
chore: rebase nonfungibles pallet to pallet-nfts
b585741
@chungquantin
chore: update nonfungibles tests
5a272f9
@chungquantin
refactor: do_approve and do_cancel_approval
2fccbcb
@chungquantin
chore: naming
3571709
@chungquantin
chore: resolve review comments
6777440
@chungquantin
chore: resolve review comments & update weights
9cf8502
@chungquantin
chore: add tests for nonfungibles api in runtime devnet
9f17d66
@chungquantin
fix: integration test & return post dispatch weight for transfer() on…
010b9cf 
… error
@chungquantin
refactor: reorder Read impl in nonfungibles
c185d36
@chungquantin
chore: remove unnecessary clone()
665feea
@chungquantin
chore: remove description for pallet configure
f65dc98
@chungquantin
refactor: approve() tests
15df8b3
@chungquantin
chore: resolve review comments
0396644
@chungquantin
feat: add AttributeSet event
ea59ba3
@chungquantin
chore: comments and add test for Collection read
728c1df
@chungquantin
chore: revert changes made to pallet nfts
bec6b25
@chungquantin
chore: fix comment
6a8adaa
@chungquantin
chore: resolve review comments
f70e005
@chungquantin
chore: update function order
4bfbafe
@Daanvdplas @chungquantin
chore: add release conventions document and refactor CI to run node r…
ac68a1f 
…elease separately (#433)
@chungquantin
refactor: reuse WeightInfo in nonfungibles pallet test (#450)
a8b2e7e
@chungquantin
chore: update collection details field to public (#449)
bbf5915
@chungquantin
chore: rebase and remove local collection details type
9604472
@chungquantin
chore: remove impls.rs and update burn()
924e520
@chungquantin
Merge branch 'main' into chungquantin/feat-main_pallet_nonfungibles
5316da1
@chungquantin
chore: remove double-charged weights
e8d875b
@chungquantin
chore: reorder test and update comments
ea1b163
@chungquantin
fix: test
cef9c9a
@chungquantin
chore: sync spec
a6c586c
@chungquantin chungquantin force-pushed the chungquantin/feat-api_nonfungibles_integration_tests branch from c18f878 to e231b77 Compare February 10, 2025 06:27
Base automatically changed from chungquantin/feat-only_api_nonfungibles to main February 11, 2025 02:51
@r0gue-io r0gue-io deleted a comment from chungquantin Feb 11, 2025
Daanvdplas
Daanvdplas reviewed Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR seems good but did not do a final review. Many of the files have already been reviewed so it would be nice if that can be fixed :)

Could we add the contract size of both contracts too please

Daanvdplas
Daanvdplas approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Mostly some comments around simplifying some of the tests more, but after that ready to go!

peterwht
peterwht approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Thanks for addressing the feedback.

@Daanvdplas Daanvdplas self-requested a review February 24, 2025 22:27
Daanvdplas
Daanvdplas approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks!

@chungquantin chungquantin merged commit be93f6b into main Feb 25, 2025
15 checks passed
@chungquantin chungquantin deleted the chungquantin/feat-api_nonfungibles_integration_tests branch February 25, 2025 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwht peterwht peterwht approved these changes

@Daanvdplas Daanvdplas Daanvdplas approved these changes

Assignees

@chungquantin chungquantin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chungquantin @codecov-commenter @peterwht @Daanvdplas @f-gate