change casing to folder structures to be compliant with our rules #9197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Kim <[email protected]>
angle943
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
7 tasks
github-actions
bot
added
the
Skip-Changelog
LDrago27
approved these changes
Jan 16, 2025
ananzh
approved these changes
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9197 +/- ##
=======================================
Coverage 61.01% 61.01%
=======================================
Files 3813 3813
Lines 91400 91400
Branches 14443 14443
=======================================
Hits 55770 55770
Misses 32068 32068
Partials 3562 3562
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d-buckner
pushed a commit
to d-buckner/OpenSearch-Dashboards
that referenced
this pull request
Jan 17, 2025
…ensearch-project#9197) Signed-off-by: Justin Kim <[email protected]>
7 tasks
ananzh
added
the
discover_2.0-test
ananzh
pushed a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Jan 23, 2025
…ensearch-project#9197) Signed-off-by: Justin Kim <[email protected]>
7 tasks
ananzh
added a commit
that referenced
this pull request
Jan 23, 2025
…ing backports (#9261) * [Discover] Makes caching dataset options optional (#8799) * [Discover] Makes caching dataset options optional. * Adds unit test * Changeset file for PR #8799 created/updated * Update test Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> * Upgrade Cypress to v12 (#8995) * Update Cypress to v12 (#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <[email protected]> * Add required e2e.js Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8926 created/updated * Update license header Signed-off-by: Daniel Rowe <[email protected]> * Update license in e2e.js Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <[email protected]> * fix lint Signed-off-by: Daniel Rowe <[email protected]> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover Test] TestID-69: Filtering. Add data-test-subj tags. (#9027) * Update Cypress to v12 (#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <[email protected]> * Add required e2e.js Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8926 created/updated * Update license header Signed-off-by: Daniel Rowe <[email protected]> * Update license in e2e.js Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <[email protected]> * fix lint Signed-off-by: Daniel Rowe <[email protected]> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add data-test-subj tags. Signed-off-by: Argus Li <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Argus Li <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Migrate query enhancement tests from functional repo to main (#9048) * migrate query enhacenement tests Signed-off-by: abbyhu2000 <[email protected]> * ignore lint in data files Signed-off-by: abbyhu2000 <[email protected]> * remove yarn lock changes Signed-off-by: abbyhu2000 <[email protected]> * add changelog Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * Add missing data-test-subj tags for discover plugin (#9049) * Add data-test-subj for discover Signed-off-by: Anan Zhuang <[email protected]> * fix comment Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Add missing data-test-subj tags for data plugin (#9051) * Add missing data-test-subj tags for data plugin * Update Snapshots * Fix as per the comments --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Follow up on #9048 by updating data and utilities (#9060) * Follow up on #9048 by updating data and utilities Feature branch PRs: #9038 #9006 Signed-off-by: Anan <[email protected]> * fix comment Signed-off-by: Anan <[email protected]> * update path and add utility from suchit commit Signed-off-by: Anan <[email protected]> * update the path to run sample test Signed-off-by: Anan <[email protected]> * fix PR comments Signed-off-by: Anan <[email protected]> * skip tests before enable workspace Signed-off-by: Anan <[email protected]> --------- Signed-off-by: Anan <[email protected]> * refactor some query-enhancement utility functions, add some missing typings (#9074) * refactor some query-enhancement utility functions, add some missing typings Signed-off-by: Justin Kim <[email protected]> * Changeset file for PR #9074 created/updated --------- Signed-off-by: Justin Kim <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * add queryEditorLanguageOptions data-test-subj on language_selector.tsx (#9029) Signed-off-by: Federico Silva <[email protected]> Co-authored-by: Federico Silva <[email protected]> * Re-enable dataset_selector.spec.js and queries.spec.js under workspace (#9082) * Re-enable dataset_selector.spec.js and queries.spec.js under workspace Signed-off-by: Anan <[email protected]> * fix comment Signed-off-by: Anan <[email protected]> * add verifyHitCount for PPL Signed-off-by: Anan <[email protected]> * Changeset file for PR #9082 created/updated --------- Signed-off-by: Anan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Make createWorkspaceIndexPatterns to handle no default cluster and clean up (#9129) * Make createWorkspaceIndexPatterns to handle no default cluster and clean up Signed-off-by: Anan <[email protected]> * Changeset file for PR #9129 created/updated --------- Signed-off-by: Anan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * add data-test-subj (#9135) Signed-off-by: Federico Silva <[email protected]> * [Discover] Adding Cypress Tests for S3 Datasets (#9113) * [Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) (#9119) * Add test for filtering functionality for discover, which enables query enhancement * Make test more robust: Add logic to use date picker start and end buttons if set to absolute times. Check the table length directly instead of number of hits to avoid bug where not all results load. --------- Signed-off-by: Argus Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add tests for saved search creation and loading for query enhancement (#9112) * Add tests for saved search creation and loading for query enhancement * click on a random element before typing on query editor to bypass the popover that appears * address pr comments - refactor to create saved search as an api call * address pr comments - specifically navigate to discover page before setting datasource Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Justin Kim <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]> * fix: 0 rendered in discover when there are no results (#9153) * fix: 0 rendered in discover when there are no results Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #9153 created/updated --------- Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Cypress][Fix] Update saved search utilities (#9151) * update saved search * minor refactor4 on setDatePickerDatesAndSearchIfRelevant Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Justin Kim <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * chore: use relative paths in cypress (#9079) * chore: use relative paths in cypress when we move to running tests in parallel we won't be able to use a single hardcoded basepath as these can differ by tasks Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #9079 created/updated --------- Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) (#9166) * add spec for old ui Signed-off-by: Argus Li <[email protected]> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <[email protected]> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <[email protected]> * Fix DataSource url Signed-off-by: Argus Li <[email protected]> * Changeset file for PR #9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <[email protected]> * Remove final force. Signed-off-by: Argus Li <[email protected]> * Fix final force. Signed-off-by: Argus Li <[email protected]> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <[email protected]> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <[email protected]> * fix import Signed-off-by: Argus Li <[email protected]> --------- Signed-off-by: Argus Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * change casing to folder structures to be compliant with our rules (#9197) Signed-off-by: Justin Kim <[email protected]> * [Fix] Saved Search Integ Test Update: update saving a new saved search test spec (#9200) * wait for the page to be loaded before loading a saved search * when loading a saved search and saving it as a new saved search, use a different name Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Justin Kim <[email protected]> * refactor query enhancement tests (#9208) Signed-off-by: Justin Kim <[email protected]> * chore: change casing of data-logs to be compliant with our git hook rules (#9220) Signed-off-by: Justin Kim <[email protected]> * chore: remove unused/redundant functions from field_display_filtering utils (#9219) Signed-off-by: Justin Kim <[email protected]> * Create cypress command namespacing util (#9150) * update cy.createInitialWorkspaceWithDataSource -> cy.osd.createInitialWorkspaceWithDataSource (#9262) Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Argus Li <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: Anan <[email protected]> Signed-off-by: Justin Kim <[email protected]> Signed-off-by: Federico Silva <[email protected]> Signed-off-by: Federico Silva <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: Argus Li <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Justin Kim <[email protected]> Co-authored-by: Federico Silva <[email protected]> Co-authored-by: Federico Silva <[email protected]> Co-authored-by: Federico Silva <[email protected]> Co-authored-by: Sean Li <[email protected]> Co-authored-by: d rowe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chore: change casing of our tests' folder structure to be snake_case. This is being done so that future commits to the integration tests can be made with the git hooks, because previously the git hooks were failing due to the casing:
Testing the changes
I was able to commit this change without
--no-verifyChangelog
Check List
yarn test:jestyarn test:jest_integration