[Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) #9119

ArgusLi · 2024-12-24T18:41:39Z

Description

Adds a Cypress test suite for filtering in the Discover page.

Issues Resolved

Closes #8945.

Screenshot

720-1.mov

720-2.mov

720-3.mov

720-4.mov

720-5.mov

720-6.mov

720-7.mov

720-8.mov

Testing the changes

With OSD running, run yarn run cypress open. In E2E specs, you will see a new test spec field_display_filter.spec.js. Select it and run it.

Changelog

test: Add cypress integration test for the new Data Explorer UI's Filtering.

codecov · 2024-12-24T18:57:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (40e61c7) to head (ddff77a).
Report is 43 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9119   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files        3809     3809           
  Lines       91267    91267           
  Branches    14413    14413           
=======================================
+ Hits        55616    55618    +2     
+ Misses      32097    32096    -1     
+ Partials     3554     3553    -1

Flag	Coverage Δ
Linux_1	`28.97% <ø> (ø)`
Linux_2	`56.45% <ø> (ø)`
Linux_3	`37.97% <ø> (+<0.01%)`	⬆️
Linux_4	`29.03% <ø> (ø)`
Windows_1	`28.98% <ø> (ø)`
Windows_2	`56.40% <ø> (ø)`
Windows_3	`37.97% <ø> (ø)`
Windows_4	`29.03% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ananzh · 2024-12-30T20:33:30Z

...egration/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/helpers.js

+ * @param {string} expectedQueryHitsAfterFilterApplied expected number of hits in string after the filter is applied. Note you should add commas when necessary e.g. 9,999
+ */
+export function verifyDocTableFirstExpandedFieldFirstRowExistsFilterButtonFiltersCorrectField(
+  docTableRowNumber,


why we need a specific utility for the first row?

Moving it to the spec instead.

Signed-off-by: Federico Silva <[email protected]>

ananzh · 2024-12-30T20:42:44Z

...egration/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/helpers.js

+ * Check if the first expanded Doc Table Field's first row's Filter For, Filter Out and Exists Filter buttons are disabled.
+ * @param {boolean} isEnabled Boolean determining if these buttons are disabled
+ */
+export function verifyDocTableFirstExpandedFieldFirstRowFilterForFilterOutExistsFilterButtons(


Why we need a utility to check enable or disable? We can write directly in the test, right?

it('verifies filter buttons state', () => { const shouldText = isEnabled ? 'be.enabled' : 'be.disabled'; cy.getElementByTestId('addInclusiveFilterButton').should(shouldText); cy.getElementByTestId('removeInclusiveFilterButton').should(shouldText); cy.getElementByTestId('addExistsFilterButton').should(shouldText); });

ananzh · 2024-12-30T20:51:13Z

...egration/core-opensearch-dashboards/opensearch-dashboards/apps/query_enhancements/helpers.js

+ * @param {string} expectedQueryHitsWithoutFilter expected number of hits in string after the filter is removed Note you should add commas when necessary e.g. 9,999
+ * @param {string} expectedQueryHitsAfterFilterApplied expected number of hits in string after the filter is applied. Note you should add commas when necessary e.g. 9,999
+ */
+export function verifyDocTableFirstExpandedFieldFirstRowFilterForButtonFiltersCorrectField(


can we combine this filter for and filter out into one? and simplify toggle (exists) one to see if we combine all three?

Ok I have combined for and out into one. The toggle is very different so I'm not combining it.

Signed-off-by: Federico Silva <[email protected]>

…ring

angle943 · 2024-12-31T20:59:58Z

...rch-dashboards/opensearch-dashboards/apps/query_enhancements/field_display_filtering.spec.js

+   * @param {number} expandedDocumentRowNumber Integer starts from 0 for the first row
+   * @param {string} expectedQueryHitsWithoutFilter expected number of hits in string after the filter is removed Note you should add commas when necessary e.g. 9,999
+   * @param {string} expectedQueryHitsAfterFilterApplied expected number of hits in string after the filter is applied. Note you should add commas when necessary e.g. 9,999
+   * @example verifyDocTableFirstExpandedFieldFirstRowFilterForButtonFiltersCorrectField('for', 0, 0, '10,000', '1');


Nice! I did not know about @example

angle943 · 2024-12-31T21:03:46Z

...rch-dashboards/opensearch-dashboards/apps/query_enhancements/field_display_filtering.spec.js

+  });
+
+  beforeEach(() => {
+    cy.navigateToWorkSpaceHomePage(`${BASE_PATH}`, `${workspace}`);


can we change this to navigateToWorkSpaceSpecificPage with page: 'discover'? See #9112 (comment) for rationale

angle943 · 2024-12-31T21:49:16Z

cypress/utils/apps/data_explorer/commands.js

@@ -162,3 +162,187 @@ function checkForElementVisibility() {
      }
    });
 }
+


All the newly added functions here are regular functions, not cypress commands. Since this file is commands.js, only Cypress.Commands.add functions should be here

So we got two options to rectify this. Either: 1) Make all these functions into cypress custom commands or 2) move these functions out to another file . I am going to vote for choice 2 for the following reason:

Cypress best practices recommends it (See 1. Don't make everything a custom command) (I personally feel that we use too much cypress commands in the codebase already)

As to where we should move these... This is just a suggestion but what I did was create a utils directory next to the tests itself: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9112/files#diff-80ee042bf13b443df19ca0fbb20fc6242ca982791beef74d65eb1d8d74f39f89

I agree that we should move them to their own file. I will move them to a similarly named utils file.

angle943 · 2024-12-31T21:51:08Z

cypress/utils/apps/data_explorer/index.d.ts

+      expectedQueryHitsAfterFilterApplied: string,
+      shouldMatch: boolean
+    );
+    verifyDocTableFirstExpandedFieldFirstRowToggleColumnButtonHasIntendedBehavior();


Because these aren't Cypress custom commands, the types shouldn't be added here nested within declare namespace Cypress { interface Chainable. Because then our IDEs think we can chain these off of cy:

If you move these functions to a separate file, we don't need to create a typescript dec file for it, since you already JSDoc-annotated it

angle943 · 2024-12-31T21:52:51Z

cypress/utils/apps/query_enhancements/constants.js

+      { name: 'PPL', isFilterButtonsEnabled: false },
+    ],
+  },
+};


btw if my PR gets merged, you can leverage it: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9112/files#diff-d7928a5f6f39c85900fa1e53e0feef6c1c26ea04701b1eb658be5eb2e89d9bd1R104

For example, isFilterButtonsEnabled in my datatype is here: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/9112/files#diff-d7928a5f6f39c85900fa1e53e0feef6c1c26ea04701b1eb658be5eb2e89d9bd1R54

angle943 · 2024-12-31T21:57:38Z

cypress/utils/commands.js

@@ -30,10 +30,49 @@ Cypress.Commands.add('getElementsByTestIds', (testIds, options = {}) => {
  return cy.get(selectors.join(','), options);
 });

-Cypress.Commands.add('getElementByDataTestId', (testId) => {
-  return cy.get(`[data-testid="${testId}"]`);
+/**


it doesn't appear these JSDocs help with IDEs, at least on my machine. Since these aren't regular functions, I don't think JSDocs will help us here. Could we remove them and instead add the typings to here? https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/cypress/utils/index.d.ts

Signed-off-by: Federico Silva <[email protected]>

Signed-off-by: Argus Li <[email protected]>

…pensearch-project#9119) * Add test for filtering functionality for discover, which enables query enhancement * Make test more robust: Add logic to use date picker start and end buttons if set to absolute times. Check the table length directly instead of number of hits to avoid bug where not all results load. --------- Signed-off-by: Argus Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

Signed-off-by: Federico Silva <[email protected]>

…pensearch-project#9119) * Add test for filtering functionality for discover, which enables query enhancement * Make test more robust: Add logic to use date picker start and end buttons if set to absolute times. Check the table length directly instead of number of hits to avoid bug where not all results load. --------- Signed-off-by: Argus Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: Federico Silva <[email protected]>

…pensearch-project#9119) * Add test for filtering functionality for discover, which enables query enhancement * Make test more robust: Add logic to use date picker start and end buttons if set to absolute times. Check the table length directly instead of number of hits to avoid bug where not all results load. --------- Signed-off-by: Argus Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…ing backports (#9261) * [Discover] Makes caching dataset options optional (#8799) * [Discover] Makes caching dataset options optional. * Adds unit test * Changeset file for PR #8799 created/updated * Update test Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> * Upgrade Cypress to v12 (#8995) * Update Cypress to v12 (#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <[email protected]> * Add required e2e.js Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8926 created/updated * Update license header Signed-off-by: Daniel Rowe <[email protected]> * Update license in e2e.js Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <[email protected]> * fix lint Signed-off-by: Daniel Rowe <[email protected]> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover Test] TestID-69: Filtering. Add data-test-subj tags. (#9027) * Update Cypress to v12 (#8926) * Update cypress to v12 Signed-off-by: Daniel Rowe <[email protected]> * Add required e2e.js Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8926 created/updated * Update license header Signed-off-by: Daniel Rowe <[email protected]> * Update license in e2e.js Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * fix: support imports without extensions in cypress webpack build (#8993) * fix: support imports without extensions in cypress webpack build Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #8993 created/updated * use typescript config Signed-off-by: Daniel Rowe <[email protected]> * fix lint Signed-off-by: Daniel Rowe <[email protected]> * disable new test isolation feature This isolation was causing regressions Signed-off-by: Daniel Rowe <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add data-test-subj tags. Signed-off-by: Argus Li <[email protected]> --------- Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Argus Li <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Migrate query enhancement tests from functional repo to main (#9048) * migrate query enhacenement tests Signed-off-by: abbyhu2000 <[email protected]> * ignore lint in data files Signed-off-by: abbyhu2000 <[email protected]> * remove yarn lock changes Signed-off-by: abbyhu2000 <[email protected]> * add changelog Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * Add missing data-test-subj tags for discover plugin (#9049) * Add data-test-subj for discover Signed-off-by: Anan Zhuang <[email protected]> * fix comment Signed-off-by: Anan Zhuang <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> * Add missing data-test-subj tags for data plugin (#9051) * Add missing data-test-subj tags for data plugin * Update Snapshots * Fix as per the comments --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Follow up on #9048 by updating data and utilities (#9060) * Follow up on #9048 by updating data and utilities Feature branch PRs: #9038 #9006 Signed-off-by: Anan <[email protected]> * fix comment Signed-off-by: Anan <[email protected]> * update path and add utility from suchit commit Signed-off-by: Anan <[email protected]> * update the path to run sample test Signed-off-by: Anan <[email protected]> * fix PR comments Signed-off-by: Anan <[email protected]> * skip tests before enable workspace Signed-off-by: Anan <[email protected]> --------- Signed-off-by: Anan <[email protected]> * refactor some query-enhancement utility functions, add some missing typings (#9074) * refactor some query-enhancement utility functions, add some missing typings Signed-off-by: Justin Kim <[email protected]> * Changeset file for PR #9074 created/updated --------- Signed-off-by: Justin Kim <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * add queryEditorLanguageOptions data-test-subj on language_selector.tsx (#9029) Signed-off-by: Federico Silva <[email protected]> Co-authored-by: Federico Silva <[email protected]> * Re-enable dataset_selector.spec.js and queries.spec.js under workspace (#9082) * Re-enable dataset_selector.spec.js and queries.spec.js under workspace Signed-off-by: Anan <[email protected]> * fix comment Signed-off-by: Anan <[email protected]> * add verifyHitCount for PPL Signed-off-by: Anan <[email protected]> * Changeset file for PR #9082 created/updated --------- Signed-off-by: Anan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Make createWorkspaceIndexPatterns to handle no default cluster and clean up (#9129) * Make createWorkspaceIndexPatterns to handle no default cluster and clean up Signed-off-by: Anan <[email protected]> * Changeset file for PR #9129 created/updated --------- Signed-off-by: Anan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * add data-test-subj (#9135) Signed-off-by: Federico Silva <[email protected]> * [Discover] Adding Cypress Tests for S3 Datasets (#9113) * [Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) (#9119) * Add test for filtering functionality for discover, which enables query enhancement * Make test more robust: Add logic to use date picker start and end buttons if set to absolute times. Check the table length directly instead of number of hits to avoid bug where not all results load. --------- Signed-off-by: Argus Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * Add tests for saved search creation and loading for query enhancement (#9112) * Add tests for saved search creation and loading for query enhancement * click on a random element before typing on query editor to bypass the popover that appears * address pr comments - refactor to create saved search as an api call * address pr comments - specifically navigate to discover page before setting datasource Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Justin Kim <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]> * fix: 0 rendered in discover when there are no results (#9153) * fix: 0 rendered in discover when there are no results Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #9153 created/updated --------- Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Cypress][Fix] Update saved search utilities (#9151) * update saved search * minor refactor4 on setDatePickerDatesAndSearchIfRelevant Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Justin Kim <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * chore: use relative paths in cypress (#9079) * chore: use relative paths in cypress when we move to running tests in parallel we won't be able to use a single hardcoded basepath as these can differ by tasks Signed-off-by: Daniel Rowe <[email protected]> * Changeset file for PR #9079 created/updated --------- Signed-off-by: Daniel Rowe <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Discover 2.0 Testing] Create View List of Saved Queries Test (Test-Id 124: View list of Saved query) (#9166) * add spec for old ui Signed-off-by: Argus Li <[email protected]> * Add comment about cleaning up saved queries Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for save query new ui Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for save query button for new ui Signed-off-by: Argus Li <[email protected]> * Add data-test-subj for open query button in query management popover Signed-off-by: Argus Li <[email protected]> * Add new ui spec to test list saved queries Signed-off-by: Argus Li <[email protected]> * Fix DataSource url Signed-off-by: Argus Li <[email protected]> * Changeset file for PR #9166 created/updated * Address Justin's comments. Signed-off-by: Argus Li <[email protected]> * Remove final force. Signed-off-by: Argus Li <[email protected]> * Fix final force. Signed-off-by: Argus Li <[email protected]> * Move utils to Suchit's suggested location, fix comments Signed-off-by: Argus Li <[email protected]> * Rename specs, change cypress workflow to use new save query ui, merge old ui and new ui commands Signed-off-by: Argus Li <[email protected]> * fix import Signed-off-by: Argus Li <[email protected]> --------- Signed-off-by: Argus Li <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * change casing to folder structures to be compliant with our rules (#9197) Signed-off-by: Justin Kim <[email protected]> * [Fix] Saved Search Integ Test Update: update saving a new saved search test spec (#9200) * wait for the page to be loaded before loading a saved search * when loading a saved search and saving it as a new saved search, use a different name Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Justin Kim <[email protected]> * refactor query enhancement tests (#9208) Signed-off-by: Justin Kim <[email protected]> * chore: change casing of data-logs to be compliant with our git hook rules (#9220) Signed-off-by: Justin Kim <[email protected]> * chore: remove unused/redundant functions from field_display_filtering utils (#9219) Signed-off-by: Justin Kim <[email protected]> * Create cypress command namespacing util (#9150) * update cy.createInitialWorkspaceWithDataSource -> cy.osd.createInitialWorkspaceWithDataSource (#9262) Signed-off-by: Justin Kim <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Daniel Rowe <[email protected]> Signed-off-by: Argus Li <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: Anan <[email protected]> Signed-off-by: Justin Kim <[email protected]> Signed-off-by: Federico Silva <[email protected]> Signed-off-by: Federico Silva <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: Argus Li <[email protected]> Co-authored-by: Daniel Rowe <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Justin Kim <[email protected]> Co-authored-by: Federico Silva <[email protected]> Co-authored-by: Federico Silva <[email protected]> Co-authored-by: Federico Silva <[email protected]> Co-authored-by: Sean Li <[email protected]> Co-authored-by: d rowe <[email protected]>

Create Spec

0d31c22

github-actions bot added the repeat-contributor label Dec 24, 2024

Changeset file for PR opensearch-project#9119 created/updated

989bac1

Merge branch 'main' into argus/testid-69-filtering

741d85e

ArgusLi mentioned this pull request Dec 24, 2024

[Discover Test] TestID-69: Filtering, Test Suite: Filter actions in table field #9011

Closed

3 tasks

ananzh reviewed Dec 30, 2024

View reviewed changes

silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Dec 30, 2024

Changeset file for PR opensearch-project#9119 created/updated

f03da06

Signed-off-by: Federico Silva <[email protected]>

ananzh reviewed Dec 30, 2024

View reviewed changes

silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Dec 30, 2024

Changeset file for PR opensearch-project#9119 created/updated

080351b

Signed-off-by: Federico Silva <[email protected]>

ArgusLi added 3 commits December 30, 2024 15:39

Merge remote-tracking branch 'origin/main' into argus/testid-69-filte…

425b663

…ring

Fix constants after merging main.

0b2ef32

Address comments.

85346b2

angle943 reviewed Dec 31, 2024

View reviewed changes

angle943 requested changes Dec 31, 2024

View reviewed changes

angle943 mentioned this pull request Dec 31, 2024

TESTID-140: sidebar spec #9128

Closed

7 tasks

silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Jan 2, 2025

Changeset file for PR opensearch-project#9119 created/updated

8d8ff31

Signed-off-by: Federico Silva <[email protected]>

ArgusLi added 2 commits January 2, 2025 14:02

Address comments.

682a6cc

merge main

ddff77a

Signed-off-by: Argus Li <[email protected]>

angle943 approved these changes Jan 3, 2025

View reviewed changes

LDrago27 approved these changes Jan 3, 2025

View reviewed changes

ananzh approved these changes Jan 5, 2025

View reviewed changes

ananzh merged commit 55f203a into opensearch-project:main Jan 5, 2025
67 of 69 checks passed

silvaf-dev pushed a commit to silvaf-dev/OpenSearch-Dashboards that referenced this pull request Jan 7, 2025

Changeset file for PR opensearch-project#9119 created/updated

eb4d15a

Signed-off-by: Federico Silva <[email protected]>

ArgusLi mentioned this pull request Jan 9, 2025

Add Utils for Data Explorer Page Cypress Testing #9009

Closed

7 tasks

ananzh added the discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative label Jan 15, 2025

angle943 mentioned this pull request Jan 18, 2025

Backport/backport lots of prs for discover 2.0 #9218

Closed

7 tasks

ananzh mentioned this pull request Jan 23, 2025

[2.x Manual Backport] Backport cypress related work to 2.x and 2 missing backports #9261

Merged

7 tasks

ananzh added the v2.19.0 label Jan 23, 2025

ananzh mentioned this pull request Feb 17, 2025

[GitHub Request] Add @angle943 as the maintainer for the OpenSearch-Dashboards as a outside collaborator opensearch-project/.github#287

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) #9119

[Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) #9119

ArgusLi commented Dec 24, 2024 •

edited

Loading

codecov bot commented Dec 24, 2024 •

edited

Loading

ananzh Dec 30, 2024

ArgusLi Dec 31, 2024

ananzh Dec 30, 2024

ananzh Dec 30, 2024

ArgusLi Dec 31, 2024

angle943 Dec 31, 2024

angle943 Dec 31, 2024

angle943 Dec 31, 2024

ArgusLi Jan 2, 2025

angle943 Dec 31, 2024 •

edited

Loading

angle943 Dec 31, 2024

angle943 Dec 31, 2024

@@ @@ -162,3 +162,187 @@ function checkForElementVisibility() { @@
                     }
                   });
               }

[Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) #9119

[Discover 2.0 Testing] Create Filtering Test (TestId-69: Filtering) #9119

Conversation

ArgusLi commented Dec 24, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

codecov bot commented Dec 24, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angle943 Dec 31, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArgusLi commented Dec 24, 2024 •

edited

Loading

codecov bot commented Dec 24, 2024 •

edited

Loading

angle943 Dec 31, 2024 •

edited

Loading