Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Request] Add @angle943 as the maintainer for the OpenSearch-Dashboards as a outside collaborator #287

Closed
ananzh opened this issue Feb 17, 2025 · 5 comments
Assignees

Comments

@ananzh
Copy link
Member

ananzh commented Feb 17, 2025

What is the type of request?

User Permission

Details of the request

We would like to nominate @angle943 to MAINTAINERS.md and .github/CODEOWNERS of OpenSearch-Dashboards repos [OpenSearch-Dashboards] so that he can approve PRs and merge code into the main branch.

We have received upvotes (including myself) from existing maintainers of opensearch-dashboards to add @angle943 as the maintainers of this repo as a outside collaborator.

Tagging maintainers who have already upvoted: @ashwin-pc @SuZhou-Joe @LDrago27 @ananzh

Additional information to support your request

Key contributions include:

  • Actively reviewing and providing detailed technical guidance on multiple PRs
  • Ensuring code quality and test coverage standards are met
  • Supporting the onboarding and development of new contributors

Key evidence of Justin's involvement:

When does this request need to be completed?

This is not an urgent request. 2-3 business days is fine.

Notes

Track the progress of your request here: https://github.com/orgs/opensearch-project/projects/208/views/33.
Member of @opensearch-project/admin will take a look at the request soon.
Thanks!

@peterzhuamazon
Copy link
Member

Pending verification of the voting process.

Also please send over the draft PR to add @angle943 into both codeowner file and maintainers.md.

Thanks.

@peterzhuamazon peterzhuamazon moved this from 🆕 New to ⌛ On Hold in Engineering Effectiveness Board Feb 17, 2025
@peterzhuamazon
Copy link
Member

Offline confirming with @ananzh and open an invite ticket for @angle943.

https://jira.linuxfoundation.org/plugins/servlet/desk/portal/2/IT-27812

Thanks.

@peterzhuamazon peterzhuamazon moved this from ⌛ On Hold to 📋 Escalation in Engineering Effectiveness Board Feb 17, 2025
@peterzhuamazon
Copy link
Member

@peterzhuamazon
Copy link
Member

Hi @angle943 @ananzh the invite has been sent.

Please accept.

Thanks.

@peterzhuamazon peterzhuamazon moved this from 📋 Escalation to 🏗 In progress in Engineering Effectiveness Board Feb 18, 2025
@peterzhuamazon peterzhuamazon moved this from 🏗 In progress to ⌛ On Hold in Engineering Effectiveness Board Feb 19, 2025
@peterzhuamazon
Copy link
Member

Based on @ananzh comment @angle943 already joined.
Add as maintainer.

Thanks.

@github-project-automation github-project-automation bot moved this from ⌛ On Hold to ✅ Done in Engineering Effectiveness Board Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants