Update Cypress to v12

[d-buckner]

Description

This is to update Cypress from v9 to v12. This PR is for the cypress-unification branch and these changes won't be merged into main until the final functional tests pass.

Testing the changes

I've run the tests locally. We can use the results of the runner on this PR for verification as well.

Changelog

• chore: update cypress to v12

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.88%. Comparing base (539675e) to head (b0aa197).
Report is 1 commits behind head on cypress-unification.

Additional details and impacted files

@@                 Coverage Diff                  @@
##           cypress-unification    #8926   +/-   ##
====================================================
  Coverage                60.88%   60.88%           
====================================================
  Files                     3802     3802           
  Lines                    91070    91070           
  Branches                 14374    14374           
====================================================
  Hits                     55444    55444           
  Misses                   32085    32085           
  Partials                  3541     3541           

Flag	Coverage Δ
Linux_1	29.02% <ø> (ø)
Linux_2	56.39% <ø> (ø)
Linux_3	37.90% <ø> (ø)
Linux_4	29.00% <ø> (ø)
Windows_1	29.03% <ø> (ø)
Windows_2	56.34% <ø> (ø)
Windows_3	37.90% <ø> (-0.01%)	⬇️
Windows_4	29.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zhongnansu]

CI is failing, could you fix? @d-rowe

[d-buckner]

CI is failing, could you fix? @d-rowe

Yes, taking a look. The main culprit is

  /usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/cypress-unification*:refs/remotes/origin/cypress-unification* +refs/tags/cypress-unification*:refs/tags/cypress-unification*
  The process '/usr/bin/git' failed with exit code 1

I'll work to repro locally and fix

[kavilla]

Suggested change

	*/
	/*
	* Copyright OpenSearch Contributors
	* SPDX-License-Identifier: Apache-2.0
	*/

[d-buckner]

Thanks for providing the new one. I've updated this.

[kavilla]

not related to this pr but if we have the chance we should structure these values a little bit more nicer

example:

VISBUILDER: {
  ENABLED: true
}

[d-buckner]

Makes sense. I'll take a look and see if I can include that in this project in one of the subsequent PRs.

[kavilla]

/*

• Copyright OpenSearch Contributors
• SPDX-License-Identifier: Apache-2.0
  */

[kavilla]

plugins if they dont run yarn osd bootstrap --single-version=loose might run into issues if they define the cypress version that is isn't this one

[kavilla]

something to consider mimicking

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.x/package.json#L170 opensearch-next

[kavilla]

but i wouldn't block this pr since its going to feature branch but might need it for main

[kavilla]

build repo defines cypress version 12.13 https://github.com/opensearch-project/opensearch-build/blob/0931ccc2752d9eced6cb3015b822b4a10742fc80/docker/ci/dockerfiles/current/test.almalinux8.systemd-base.x64.arm64.ppc64le.dockerfile#L58

we might need to create an issue to bump the version in the build repo

[kavilla]

do we need to update this ? https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/package.json#L59

[d-buckner]

Makes sense. Let me take a look at all the instances of cypress in our runners and other repos and I'll put together a small overview of what's needed to get all of these on a unified version of cypress.