-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change casing to folder structures to be compliant with our rules #9194
change casing to folder structures to be compliant with our rules #9194
Conversation
Signed-off-by: Justin Kim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated to this PR. but we should avoid having duplicate files. we should do the current way of having a single file that does a conditional based on cypress env variables. example: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/57db1eb9a3e4bd72372963a9ceee8c4a153bc13d/cypress/integration/plugins/security/tenants_spec.js#L11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this way we reduce the amount of files for local development and if we need to modify these tests we just neeed to do it once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kavilla, @AMoo-Miki is currently adding and testing this logic based on his future CI/CD. example:
Line 17 in 08bc81f
ifEnabled(['WORKSPACE', '!SECURITY']).describe( |
As discussed with him before, for current test, we will use ciGroup 10 and then his PR will update all the tests in query enhancement.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9194 +/- ##
=======================================
Coverage 61.01% 61.01%
=======================================
Files 3813 3813
Lines 91400 91400
Branches 14443 14443
=======================================
Hits 55772 55772
Misses 32067 32067
Partials 3561 3561
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Kim <[email protected]>
ciGroup 10 failed. Re-run it. |
Signed-off-by: Justin Kim <[email protected]>
...re_opensearch_dashboards/opensearch_dashboards/apps/query_enhancements/utils/saved_search.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Justin Kim <[email protected]>
Closing this due to merge conflict: #9197 |
Description
Chore: change casing of our tests' folder structure to be snake_case. This is being done so that future commits to the integration tests can be made with the git hooks, because previously the git hooks were failing due to the casing:
Testing the changes
I was able to commit this change without
--no-verify
Changelog
Check List
yarn test:jest
yarn test:jest_integration