Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change casing to folder structures to be compliant with our rules #9194

Conversation

angle943
Copy link
Collaborator

Description

Chore: change casing of our tests' folder structure to be snake_case. This is being done so that future commits to the integration tests can be made with the git hooks, because previously the git hooks were failing due to the casing:

Screenshot 2024-12-31 at 12 36 19 PM

Testing the changes

I was able to commit this change without --no-verify

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to this PR. but we should avoid having duplicate files. we should do the current way of having a single file that does a conditional based on cypress env variables. example: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/57db1eb9a3e4bd72372963a9ceee8c4a153bc13d/cypress/integration/plugins/security/tenants_spec.js#L11

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this way we reduce the amount of files for local development and if we need to modify these tests we just neeed to do it once

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kavilla, @AMoo-Miki is currently adding and testing this logic based on his future CI/CD. example:

As discussed with him before, for current test, we will use ciGroup 10 and then his PR will update all the tests in query enhancement.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.01%. Comparing base (5a290a4) to head (1cdaca8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9194   +/-   ##
=======================================
  Coverage   61.01%   61.01%           
=======================================
  Files        3813     3813           
  Lines       91400    91400           
  Branches    14443    14443           
=======================================
  Hits        55772    55772           
  Misses      32067    32067           
  Partials     3561     3561           
Flag Coverage Δ
Linux_1 29.08% <ø> (ø)
Linux_2 56.45% <ø> (ø)
Linux_3 38.03% <ø> (ø)
Linux_4 29.03% <ø> (ø)
Windows_1 29.09% <ø> (ø)
Windows_2 56.40% <ø> (ø)
Windows_3 38.03% <ø> (ø)
Windows_4 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh
Copy link
Member

ananzh commented Jan 16, 2025

ciGroup 10 failed. Re-run it.

@ananzh ananzh added the discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative label Jan 16, 2025
@angle943
Copy link
Collaborator Author

Closing this due to merge conflict: #9197

@angle943 angle943 closed this Jan 16, 2025
@angle943 angle943 deleted the change-directory-casing-for-tests branch January 21, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative repeat-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants