Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: fix CreateMultisigAccount interop #1804

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Mar 4, 2021

Introduced in #1720.

Close #1803.

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1804 (52e4d69) into master (4a9ca25) will increase coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1804      +/-   ##
==========================================
+ Coverage   83.56%   83.83%   +0.27%     
==========================================
  Files         271      271              
  Lines       22052    22396     +344     
==========================================
+ Hits        18427    18775     +348     
+ Misses       2500     2479      -21     
- Partials     1125     1142      +17     
Impacted Files Coverage Δ
pkg/interop/contract/contract.go 0.00% <0.00%> (ø)
cli/smartcontract/smart_contract.go 90.39% <0.00%> (+2.67%) ⬆️
pkg/rpc/client/rpc.go 86.69% <0.00%> (+3.01%) ⬆️
pkg/services/oracle/request.go 62.29% <0.00%> (+4.91%) ⬆️
pkg/rpc/client/nep17.go 56.83% <0.00%> (+8.11%) ⬆️
cli/wallet/validator.go 81.17% <0.00%> (+9.30%) ⬆️
pkg/services/oracle/oracle.go 90.58% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a9ca25...52e4d69. Read the comment docs.

AnnaShaleva added a commit that referenced this pull request Mar 4, 2021
@roman-khimov roman-khimov merged commit dedcab2 into master Mar 4, 2021
@roman-khimov roman-khimov deleted the interop/createmultisigaccount-fix branch March 4, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateMultisigAccount can't convert Array to Integer
3 participants