Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: add test for syscall handling #1809

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Mar 4, 2021

Fix 2 bugs along the way.
This is obviously needed (#1806, #1804).

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1809 (7c62df1) into master (39817aa) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1809      +/-   ##
==========================================
+ Coverage   83.53%   83.62%   +0.08%     
==========================================
  Files         273      273              
  Lines       21980    21980              
==========================================
+ Hits        18362    18380      +18     
+ Misses       2498     2477      -21     
- Partials     1120     1123       +3     
Impacted Files Coverage Δ
pkg/core/interops.go 100.00% <ø> (ø)
pkg/interop/contract/contract.go 0.00% <0.00%> (ø)
pkg/services/oracle/request.go 62.29% <0.00%> (+6.55%) ⬆️
pkg/services/oracle/oracle.go 90.58% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39817aa...7c62df1. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.94.0 milestone Mar 4, 2021
@roman-khimov roman-khimov merged commit 1d70504 into master Mar 5, 2021
@roman-khimov roman-khimov deleted the fix/syscalltest branch March 5, 2021 07:39
"contract.Call": {interopnames.SystemContractCall, []string{u160, `"m"`, "1", "3"}, false},
"contract.CreateMultisigAccount": {interopnames.SystemContractCreateMultisigAccount, []string{"1", pubs}, false},
"contract.CreateStandardAccount": {interopnames.SystemContractCreateStandardAccount, []string{pub}, false},
"contract.IsStandard": {interopnames.SystemContractIsStandard, []string{b}, false},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[]string{u160}?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Go smart contract compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants