Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: fix ConvertContextToReadOnly interop #1805

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Mar 4, 2021

The same bug as in #1804.

Also checked the rest of interops, they're OK. Maybe we need some test for such bugs.

@AnnaShaleva AnnaShaleva added the bug Something isn't working label Mar 4, 2021
@AnnaShaleva AnnaShaleva self-assigned this Mar 4, 2021
@roman-khimov roman-khimov added this to the v0.94.0 milestone Mar 4, 2021
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #1805 (0c46408) into master (0e7bb5c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1805   +/-   ##
=======================================
  Coverage   83.57%   83.58%           
=======================================
  Files         271      271           
  Lines       22077    22077           
=======================================
+ Hits        18451    18452    +1     
+ Misses       2500     2499    -1     
  Partials     1126     1126           
Impacted Files Coverage Δ
pkg/interop/storage/storage.go 0.00% <0.00%> (ø)
pkg/network/server.go 72.76% <0.00%> (-0.16%) ⬇️
pkg/services/oracle/request.go 57.37% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e7bb5c...0c46408. Read the comment docs.

@roman-khimov roman-khimov merged commit 58ea460 into master Mar 4, 2021
@roman-khimov roman-khimov deleted the interop/convertcontext-fix branch March 4, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants