Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor syscall handing #1720

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Refactor syscall handing #1720

merged 2 commits into from
Feb 24, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Feb 8, 2021

Depends on #1711 .

  1. Introduce neogointernal package with Syscall* functions.
  2. Process syscall wrappers as usual Go functions.
  3. For native contract wrappers inlinining is done twice (for the func itself + inner syscall).

Base automatically changed from compiler/inline to master February 15, 2021 16:05
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #1720 (8511825) into master (abee3b5) will decrease coverage by 0.10%.
The diff coverage is 31.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1720      +/-   ##
==========================================
- Coverage   82.71%   82.61%   -0.11%     
==========================================
  Files         270      272       +2     
  Lines       22193    22157      -36     
==========================================
- Hits        18356    18304      -52     
- Misses       2712     2731      +19     
+ Partials     1125     1122       -3     
Impacted Files Coverage Δ
pkg/interop/binary/binary.go 0.00% <0.00%> (ø)
pkg/interop/contract/contract.go 0.00% <0.00%> (ø)
pkg/interop/crypto/crypto.go 0.00% <0.00%> (ø)
pkg/interop/iterator/iterator.go 0.00% <0.00%> (ø)
pkg/interop/json/json.go 0.00% <0.00%> (ø)
pkg/interop/neogointernal/syscall.go 0.00% <0.00%> (ø)
pkg/interop/runtime/engine.go 0.00% <0.00%> (ø)
pkg/interop/runtime/runtime.go 0.00% <0.00%> (ø)
pkg/interop/storage/storage.go 0.00% <0.00%> (ø)
pkg/compiler/analysis.go 96.47% <100.00%> (-0.63%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abee3b5...df5314f. Read the comment docs.

pkg/compiler/codegen.go Outdated Show resolved Hide resolved
pkg/compiler/codegen.go Outdated Show resolved Hide resolved
pkg/compiler/func_scope.go Show resolved Hide resolved
@roman-khimov
Copy link
Member

And it seems to be fixing #941, but it's not mentioned anywhere.

@roman-khimov roman-khimov merged commit 46fbd94 into master Feb 24, 2021
@roman-khimov roman-khimov deleted the compiler/syscall branch February 24, 2021 16:31
AnnaShaleva added a commit that referenced this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants