propose to stop using joshjs for issue #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHY: joshjs's bug prevents firmware upload by GUI With v1.0.2, we cannot upload firmware by GUI. This is because joshjs bug has appeared in the improvements made so far. Fortunately, joshjs is now applied to only one location, so decided to stop using it.
pojiro
changed the title
jjcarstens
approved these changes
Jul 25, 2022
|
Works for me. I have no attachment to JoshJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propose to stop using joshjs for issue #843
WHY: joshjs's bug prevents firmware upload by GUI
With v1.0.2, we cannot upload firmware by GUI.
This is because joshjs bug has appeared in the improvements made so far.
Fortunately, joshjs is now applied to only one location, so propose to stop using it.