Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propose to stop using joshjs for issue #844

Merged
merged 1 commit into from
Jul 25, 2022
Merged

propose to stop using joshjs for issue #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apps/nerves_hub_www/assets/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import '@popperjs/core'
import $ from 'jquery'
import { Socket } from 'phoenix'
import { LiveSocket } from 'phoenix_live_view'
import Josh from 'joshjs'

let dates = require('./dates')
let csrfToken = document
Expand All @@ -18,8 +17,6 @@ let liveSocket = new LiveSocket('/live', Socket, {

liveSocket.connect()

new Josh()

$(function () {
$('.custom-upload-input').on('change', function () {
let fileName = $(this).val().split('\\').pop()
Expand Down
27 changes: 0 additions & 27 deletions apps/nerves_hub_www/assets/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion apps/nerves_hub_www/assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"dependencies": {
"@popperjs/core": "^2.11.4",
"bootstrap": "^5.1.3",
"joshjs": "^1.0.7",
"jquery": "^3.6.0",
"moment": "^2.29.2",
"phoenix": "file:../../../deps/phoenix",
Expand Down
2 changes: 1 addition & 1 deletion apps/nerves_hub_www/lib/nerves_hub_www_web/templates/home/index.html.heex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<h1>Manage OTA firmware updates across your devices</h1>
<p>NervesHub is an extensible web service that allows you to manage over-the-air (OTA) firmware updates of devices in the field. Built with Phoenix, NervesHub delivers first-class support for hardware deployments directly from the command line.</p>
<%= if permit_uninvited_signups() do %>
<a class="btn btn-primary btn-lg btn-home josh-js" data-josh-anim-name="pulse" href={Routes.account_path(@conn, :new)}>Get Started</a>
<a class="btn btn-primary btn-lg btn-home" href={Routes.account_path(@conn, :new)}>Get Started</a>
<% end %>
</div>
<div class="hero-image">
Expand Down