Skip to content

Commit

Permalink
fix: changed to not use joshjs
Browse files Browse the repository at this point in the history
WHY: joshjs's bug prevents firmware upload by GUI

With v1.0.2, we cannot upload firmware by GUI.
This is because joshjs bug has appeared in the improvements made so far.
Fortunately, joshjs is now applied to only one location, so decided to stop using it.
  • Loading branch information
pojiro authored and fhunleth committed Jul 25, 2022
1 parent 87682ed commit 234952d
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 32 deletions.
3 changes: 0 additions & 3 deletions apps/nerves_hub_www/assets/js/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import '@popperjs/core'
import $ from 'jquery'
import { Socket } from 'phoenix'
import { LiveSocket } from 'phoenix_live_view'
import Josh from 'joshjs'

let dates = require('./dates')
let csrfToken = document
Expand All @@ -18,8 +17,6 @@ let liveSocket = new LiveSocket('/live', Socket, {

liveSocket.connect()

new Josh()

$(function () {
$('.custom-upload-input').on('change', function () {
let fileName = $(this).val().split('\\').pop()
Expand Down
27 changes: 0 additions & 27 deletions apps/nerves_hub_www/assets/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion apps/nerves_hub_www/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
"dependencies": {
"@popperjs/core": "^2.11.4",
"bootstrap": "^5.1.3",
"joshjs": "^1.0.7",
"jquery": "^3.6.0",
"moment": "^2.29.2",
"phoenix": "file:../../../deps/phoenix",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<h1>Manage OTA firmware updates across your devices</h1>
<p>NervesHub is an extensible web service that allows you to manage over-the-air (OTA) firmware updates of devices in the field. Built with Phoenix, NervesHub delivers first-class support for hardware deployments directly from the command line.</p>
<%= if permit_uninvited_signups() do %>
<a class="btn btn-primary btn-lg btn-home josh-js" data-josh-anim-name="pulse" href={Routes.account_path(@conn, :new)}>Get Started</a>
<a class="btn btn-primary btn-lg btn-home" href={Routes.account_path(@conn, :new)}>Get Started</a>
<% end %>
</div>
<div class="hero-image">
Expand Down

0 comments on commit 234952d

Please sign in to comment.