v1.0.2, cannot upload firmware by GUI

[pojiro]

Describe the bug

With v1.0.2, we cannot upload firmware by GUI, because HTML input tag type file doesn't work.
I think this is because joshjs's potential bug reveals in improvements up to v1.0.2.

The error message is following.

The error prevents to execute following jQuery.

nerves_hub_web/apps/nerves_hub_www/assets/js/app.js

Lines 21 to 32 in 87682ed

	new Josh()
	$(function () {
	$('.custom-upload-input').on('change', function () {
	let fileName = $(this).val().split('\\').pop()
	$(this)
	.siblings('.custom-upload-label')
	.removeClass('not-selected')
	.addClass('selected')
	.html("Selected File: <div class='file-name'>" + fileName + '</div>')
	})
	})

To Reproduce

0. mix assets.setup && make iex-server
1. Go to http://localhost:4000/org/NervesTeam/SmartRentHub/firmware/upload
2. Click on 'Click to upload file'
3. Then select some firmware you have. This ends with no action.

Expected behavior

can upload firmware

Desktop (please complete the following information):

• OS: [Linux]
• Browser [chrome, firefox]
• Version [nerves_hub_web: v1.0.2]

Additional context

I made a PR to fix this joshjs's issue.

I also have an idea of what to do if the PR is not accepted. That is to stop using joshjs, currently joshjs is used only one place,

nerves_hub_web/apps/nerves_hub_www/lib/nerves_hub_www_web/templates/home/index.html.heex

Line 17 in 87682ed

<a class="btn btn-primary btn-lg btn-home josh-js" data-josh-anim-name="pulse" href={Routes.account_path(@conn, :new)}>Get Started</a>

so I think we can choose to stop using joshjs. I already tried to uninstall joshjs on my self-hosted nerves-hub and confirmed uploadable and deployable.

[tonnenpinguin]

I noticed the josh exceptions a while ago already and ended up dropping josh from our fork as well because I didn't see the benefit of it being there in the first place :)

By the way: Another fix is to just wrap the new Josh() call in a try catch block. That would also allow the jquery to be executed, although it might be worthwhile to figure out a way around using jquery in the first place 🙃

[pojiro]

I already tried to uninstall joshjs on my self-hosted nerves-hub and confirmed uploadable and deployable.

#844 is the commit i tried.

[fhunleth]

Thanks for looking into this and fixing!