Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Convergence #19409

Closed
23 of 32 tasks
czearing opened this issue Aug 16, 2021 · 1 comment
Closed
23 of 32 tasks

Switch Convergence #19409

czearing opened this issue Aug 16, 2021 · 1 comment
Assignees
@khmakoto
Labels
Area: Components Component: Switch Component: Toggle Fluent UI react-components (v9) Type: Epic
Milestone
September Project...

Comments

@czearing
Copy link
Collaborator

czearing commented Aug 16, 2021 •
edited
Loading

Preparation:

  • Started prep
  • Open UI Research complete
    • [https://open-ui.org/components/switch]
  • Comparison on v8 and v0 complete
  • Gather open GitHub issues related to component
  • react-slider package scaffolded
    link to react-slider package
  • Component Spec authored and reviewed
  • Deliverable: Reviewed component spec

Implementation

link to react-slider package

  • Implement component
  • Add storybook stories
  • Using hooks
  • Using makeStyles
  • Respects Figma tokens (and using provider)
  • Respects API principles, shorthands and slots handling
  • No dependency on v0/v7
  • Add tests - Conformance, Unit, and VR
    • Bundle size fixtures
    • Conformance tests
    • Unit tests
    • VR tests
    • Accessibility behavior tests
  • Write README.md covering basic usage
  • Write initial MIGRATION.md guide (include v8 and v0)
  • Set component ownership in CODEOWNERS
  • Deliverable: Experimental component ready for partner use, component re-exported in react-components

Validation

  • Started validating
  • Add and validate in UI Builder
  • Add and validate in docs site
  • Validate with token pipeline
  • Validate in product
  • Finalize migration guide
    • Author codemods
  • Deliverable: Preview component ready for broader/3rd party use
@czearing czearing self-assigned this Aug 16, 2021
This was referenced Aug 17, 2021
Merged
Merged
Closed
This was referenced Sep 8, 2021
Merged
Merged
Merged
Merged
Merged
@czearing czearing mentioned this issue Sep 20, 2021
Merged
2 tasks
@khmakoto khmakoto assigned khmakoto and unassigned czearing Feb 24, 2022
@khmakoto khmakoto mentioned this issue Feb 24, 2022
Merged
@khmakoto khmakoto mentioned this issue Mar 9, 2022
Merged
@khmakoto
Copy link
Member

Component is stable now, closing for now in favor of smaller issues if they come up in the future.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@khmakoto khmakoto

Labels
Area: Components Component: Switch Component: Toggle Fluent UI react-components (v9) Type: Epic
Projects
None yet
Milestone
September Project Cycle Q3 2021
Development

No branches or pull requests
4 participants
@czearing @khmakoto @paulgildea @behowell