-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(react-switch) - Updating package.json to public #19735
(react-switch) - Updating package.json to public #19735
Conversation
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2c980c60e3c332f678cc4a74c0e3051756191bac (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 53c9701:
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
ContextualMenu | mount | 4160 | 6619 | 1000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 897 | 914 | 5000 | |
BaseButton | mount | 890 | 907 | 5000 | |
Breadcrumb | mount | 2651 | 2670 | 1000 | |
ButtonNext | mount | 456 | 452 | 5000 | |
Checkbox | mount | 1509 | 1538 | 5000 | |
CheckboxBase | mount | 1306 | 1298 | 5000 | |
ChoiceGroup | mount | 4746 | 4701 | 5000 | |
ComboBox | mount | 969 | 976 | 1000 | |
CommandBar | mount | 10347 | 10371 | 1000 | |
ContextualMenu | mount | 4160 | 6619 | 1000 | Possible regression |
DefaultButton | mount | 1120 | 1154 | 5000 | |
DetailsRow | mount | 3699 | 3791 | 5000 | |
DetailsRowFast | mount | 3693 | 3710 | 5000 | |
DetailsRowNoStyles | mount | 3547 | 3530 | 5000 | |
Dialog | mount | 2411 | 2390 | 1000 | |
DocumentCardTitle | mount | 146 | 158 | 1000 | |
Dropdown | mount | 3222 | 3232 | 5000 | |
FluentProviderNext | mount | 7533 | 7492 | 5000 | |
FluentProviderWithTheme | mount | 342 | 347 | 10 | |
FluentProviderWithTheme | virtual-rerender | 98 | 97 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 482 | 498 | 10 | |
FocusTrapZone | mount | 1823 | 1776 | 5000 | |
FocusZone | mount | 1841 | 1840 | 5000 | |
IconButton | mount | 1749 | 1731 | 5000 | |
Label | mount | 340 | 324 | 5000 | |
Layer | mount | 3015 | 3041 | 5000 | |
Link | mount | 464 | 461 | 5000 | |
MakeStyles | mount | 1845 | 1910 | 50000 | |
MenuButton | mount | 1490 | 1463 | 5000 | |
MessageBar | mount | 2037 | 2043 | 5000 | |
Nav | mount | 3226 | 3254 | 1000 | |
OverflowSet | mount | 1112 | 1112 | 5000 | |
Panel | mount | 2427 | 2351 | 1000 | |
Persona | mount | 858 | 866 | 1000 | |
Pivot | mount | 1407 | 1420 | 1000 | |
PrimaryButton | mount | 1276 | 1293 | 5000 | |
Rating | mount | 7639 | 7641 | 5000 | |
SearchBox | mount | 1329 | 1332 | 5000 | |
Shimmer | mount | 2537 | 2529 | 5000 | |
Slider | mount | 1945 | 1980 | 5000 | |
SpinButton | mount | 4968 | 5013 | 5000 | |
Spinner | mount | 431 | 425 | 5000 | |
SplitButton | mount | 3150 | 3176 | 5000 | |
Stack | mount | 499 | 485 | 5000 | |
StackWithIntrinsicChildren | mount | 1479 | 1488 | 5000 | |
StackWithTextChildren | mount | 4463 | 4475 | 5000 | |
SwatchColorPicker | mount | 10057 | 10212 | 5000 | |
Tabs | mount | 1401 | 1492 | 1000 | |
TagPicker | mount | 2593 | 2603 | 5000 | |
TeachingBubble | mount | 13252 | 13465 | 5000 | |
Text | mount | 423 | 421 | 5000 | |
TextField | mount | 1378 | 1331 | 5000 | |
ThemeProvider | mount | 1196 | 1212 | 5000 | |
ThemeProvider | virtual-rerender | 589 | 604 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1855 | 1909 | 5000 | |
Toggle | mount | 804 | 807 | 5000 | |
buttonNative | mount | 120 | 121 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Potential regressions comparing to master
Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
---|---|---|---|---|
AlertMinimalPerf.default | 258 | 274 | 0.94:1 | analysis |
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ButtonMinimalPerf.default | 174 | 161 | 1.08:1 |
LabelMinimalPerf.default | 388 | 362 | 1.07:1 |
PortalMinimalPerf.default | 186 | 176 | 1.06:1 |
RefMinimalPerf.default | 244 | 232 | 1.05:1 |
StatusMinimalPerf.default | 681 | 648 | 1.05:1 |
TreeWith60ListItems.default | 176 | 168 | 1.05:1 |
AccordionMinimalPerf.default | 146 | 141 | 1.04:1 |
DividerMinimalPerf.default | 364 | 349 | 1.04:1 |
FormMinimalPerf.default | 413 | 396 | 1.04:1 |
TreeMinimalPerf.default | 809 | 780 | 1.04:1 |
AnimationMinimalPerf.default | 415 | 402 | 1.03:1 |
ButtonSlotsPerf.default | 560 | 545 | 1.03:1 |
GridMinimalPerf.default | 344 | 333 | 1.03:1 |
LayoutMinimalPerf.default | 371 | 359 | 1.03:1 |
ListWith60ListItems.default | 638 | 618 | 1.03:1 |
ProviderMergeThemesPerf.default | 1751 | 1698 | 1.03:1 |
IconMinimalPerf.default | 597 | 577 | 1.03:1 |
TableMinimalPerf.default | 402 | 392 | 1.03:1 |
TextMinimalPerf.default | 346 | 335 | 1.03:1 |
CardMinimalPerf.default | 540 | 531 | 1.02:1 |
ChatWithPopoverPerf.default | 356 | 349 | 1.02:1 |
DropdownManyItemsPerf.default | 685 | 669 | 1.02:1 |
FlexMinimalPerf.default | 287 | 280 | 1.02:1 |
HeaderMinimalPerf.default | 357 | 350 | 1.02:1 |
InputMinimalPerf.default | 1269 | 1248 | 1.02:1 |
ProviderMinimalPerf.default | 982 | 965 | 1.02:1 |
SkeletonMinimalPerf.default | 353 | 347 | 1.02:1 |
TableManyItemsPerf.default | 1905 | 1873 | 1.02:1 |
ToolbarMinimalPerf.default | 943 | 925 | 1.02:1 |
TooltipMinimalPerf.default | 1037 | 1012 | 1.02:1 |
AttachmentMinimalPerf.default | 155 | 154 | 1.01:1 |
AttachmentSlotsPerf.default | 1048 | 1036 | 1.01:1 |
ButtonOverridesMissPerf.default | 1694 | 1675 | 1.01:1 |
CarouselMinimalPerf.default | 466 | 461 | 1.01:1 |
ChatMinimalPerf.default | 646 | 641 | 1.01:1 |
CheckboxMinimalPerf.default | 2777 | 2743 | 1.01:1 |
DatepickerMinimalPerf.default | 5452 | 5407 | 1.01:1 |
DropdownMinimalPerf.default | 3106 | 3081 | 1.01:1 |
ImageMinimalPerf.default | 365 | 363 | 1.01:1 |
ItemLayoutMinimalPerf.default | 1223 | 1208 | 1.01:1 |
SegmentMinimalPerf.default | 343 | 341 | 1.01:1 |
SplitButtonMinimalPerf.default | 4126 | 4091 | 1.01:1 |
TextAreaMinimalPerf.default | 486 | 482 | 1.01:1 |
VideoMinimalPerf.default | 628 | 621 | 1.01:1 |
DialogMinimalPerf.default | 749 | 751 | 1:1 |
ListMinimalPerf.default | 501 | 500 | 1:1 |
LoaderMinimalPerf.default | 689 | 691 | 1:1 |
SliderMinimalPerf.default | 1541 | 1538 | 1:1 |
CustomToolbarPrototype.default | 3882 | 3869 | 1:1 |
BoxMinimalPerf.default | 357 | 362 | 0.99:1 |
ChatDuplicateMessagesPerf.default | 281 | 283 | 0.99:1 |
EmbedMinimalPerf.default | 4097 | 4137 | 0.99:1 |
HeaderSlotsPerf.default | 754 | 763 | 0.99:1 |
ListNestedPerf.default | 552 | 559 | 0.99:1 |
MenuButtonMinimalPerf.default | 1666 | 1689 | 0.99:1 |
MenuMinimalPerf.default | 834 | 847 | 0.98:1 |
RadioGroupMinimalPerf.default | 439 | 446 | 0.98:1 |
ReactionMinimalPerf.default | 371 | 378 | 0.98:1 |
PopupMinimalPerf.default | 593 | 610 | 0.97:1 |
AvatarMinimalPerf.default | 189 | 196 | 0.96:1 |
ListCommonPerf.default | 609 | 640 | 0.95:1 |
RosterPerf.default | 1142 | 1210 | 0.94:1 |
🎉 Handy links: |
Pull request checklist
$ yarn change
Description of changes
Removing
"private": true,
from the converged Switch component's package.