Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(react-switch) - Adding bundle size tool #19732

Merged

Conversation

czearing
Copy link
Collaborator

@czearing czearing commented Sep 9, 2021

Pull request checklist

Description of changes

Adding a .fixture.js file to the converged Switch component to measure bundle size.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d29c0e4:

Sandbox Source
Fluent UI React Starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-switch
Switch
0 B
0 B
18.013 kB
6.167 kB
🆕 New entry

🤖 This report was generated against 1faed19b8bf0481bab8a2fc7b4efa0c2e4bb1be5

@size-auditor
Copy link

size-auditor bot commented Sep 9, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5b40f30ba0d1c4678c1bdba3413ec64bc1de7e51 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 932 920 5000
BaseButton mount 942 933 5000
Breadcrumb mount 2748 2827 1000
ButtonNext mount 455 460 5000
Checkbox mount 1590 1538 5000
CheckboxBase mount 1314 1321 5000
ChoiceGroup mount 4880 4902 5000
ComboBox mount 1081 1009 1000
CommandBar mount 10898 10794 1000
ContextualMenu mount 6890 6929 1000
DefaultButton mount 1149 1160 5000
DetailsRow mount 3805 3878 5000
DetailsRowFast mount 3952 3956 5000
DetailsRowNoStyles mount 3717 3656 5000
Dialog mount 2550 2572 1000
DocumentCardTitle mount 147 144 1000
Dropdown mount 3371 3400 5000
FluentProviderNext mount 7884 7833 5000
FluentProviderWithTheme mount 366 371 10
FluentProviderWithTheme virtual-rerender 103 107 10
FluentProviderWithTheme virtual-rerender-with-unmount 520 526 10
FocusTrapZone mount 1861 1804 5000
FocusZone mount 1884 1891 5000
IconButton mount 1811 1798 5000
Label mount 355 337 5000
Layer mount 3098 3093 5000
Link mount 480 495 5000
MakeStyles mount 1935 1923 50000
MenuButton mount 1501 1511 5000
MessageBar mount 2118 2155 5000
Nav mount 3409 3303 1000
OverflowSet mount 1146 1163 5000
Panel mount 2438 2422 1000
Persona mount 859 855 1000
Pivot mount 1452 1473 1000
PrimaryButton mount 1349 1323 5000
Rating mount 7860 7997 5000
SearchBox mount 1343 1356 5000
Shimmer mount 2567 2607 5000
Slider mount 1986 2027 5000
SpinButton mount 5167 5110 5000
Spinner mount 434 418 5000
SplitButton mount 3287 3260 5000
Stack mount 512 522 5000
StackWithIntrinsicChildren mount 1600 1547 5000
StackWithTextChildren mount 4831 4708 5000
SwatchColorPicker mount 10826 10869 5000
Tabs mount 1565 1484 1000
TagPicker mount 2760 2729 5000
TeachingBubble mount 13763 13812 5000
Text mount 434 427 5000
TextField mount 1425 1411 5000
ThemeProvider mount 1233 1242 5000
ThemeProvider virtual-rerender 621 614 5000
ThemeProvider virtual-rerender-with-unmount 1949 1980 5000
Toggle mount 840 831 5000
buttonNative mount 115 118 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 165 151 1.09:1
CarouselMinimalPerf.default 504 466 1.08:1
ListCommonPerf.default 666 624 1.07:1
LoaderMinimalPerf.default 739 698 1.06:1
AttachmentMinimalPerf.default 162 155 1.05:1
ButtonMinimalPerf.default 179 170 1.05:1
TextAreaMinimalPerf.default 526 500 1.05:1
CardMinimalPerf.default 572 551 1.04:1
IconMinimalPerf.default 637 612 1.04:1
AnimationMinimalPerf.default 422 411 1.03:1
AvatarMinimalPerf.default 197 192 1.03:1
EmbedMinimalPerf.default 4305 4193 1.03:1
ImageMinimalPerf.default 386 373 1.03:1
SkeletonMinimalPerf.default 368 358 1.03:1
VideoMinimalPerf.default 655 636 1.03:1
BoxMinimalPerf.default 369 360 1.02:1
ChatDuplicateMessagesPerf.default 297 292 1.02:1
ChatWithPopoverPerf.default 378 369 1.02:1
DatepickerMinimalPerf.default 5931 5812 1.02:1
FormMinimalPerf.default 422 413 1.02:1
GridMinimalPerf.default 347 339 1.02:1
LayoutMinimalPerf.default 378 370 1.02:1
MenuMinimalPerf.default 884 865 1.02:1
MenuButtonMinimalPerf.default 1728 1690 1.02:1
PopupMinimalPerf.default 616 606 1.02:1
PortalMinimalPerf.default 207 203 1.02:1
SegmentMinimalPerf.default 346 340 1.02:1
StatusMinimalPerf.default 696 681 1.02:1
TableManyItemsPerf.default 1963 1926 1.02:1
TextMinimalPerf.default 355 349 1.02:1
CheckboxMinimalPerf.default 2851 2814 1.01:1
InputMinimalPerf.default 1290 1273 1.01:1
ReactionMinimalPerf.default 385 382 1.01:1
ToolbarMinimalPerf.default 960 954 1.01:1
TreeWith60ListItems.default 173 171 1.01:1
ButtonOverridesMissPerf.default 1770 1772 1:1
ButtonSlotsPerf.default 572 571 1:1
DialogMinimalPerf.default 773 771 1:1
DividerMinimalPerf.default 371 372 1:1
DropdownMinimalPerf.default 3173 3175 1:1
HeaderMinimalPerf.default 362 363 1:1
HeaderSlotsPerf.default 766 765 1:1
LabelMinimalPerf.default 391 392 1:1
ListMinimalPerf.default 533 533 1:1
RefMinimalPerf.default 248 247 1:1
SplitButtonMinimalPerf.default 4212 4207 1:1
CustomToolbarPrototype.default 4005 4016 1:1
TreeMinimalPerf.default 810 807 1:1
AttachmentSlotsPerf.default 1074 1080 0.99:1
ChatMinimalPerf.default 654 662 0.99:1
TableMinimalPerf.default 404 407 0.99:1
DropdownManyItemsPerf.default 688 702 0.98:1
ItemLayoutMinimalPerf.default 1214 1241 0.98:1
ProviderMergeThemesPerf.default 1725 1752 0.98:1
ProviderMinimalPerf.default 1035 1051 0.98:1
TooltipMinimalPerf.default 1017 1033 0.98:1
FlexMinimalPerf.default 285 293 0.97:1
ListWith60ListItems.default 653 670 0.97:1
SliderMinimalPerf.default 1581 1629 0.97:1
AlertMinimalPerf.default 274 285 0.96:1
ListNestedPerf.default 551 578 0.95:1
RosterPerf.default 1185 1248 0.95:1
RadioGroupMinimalPerf.default 435 458 0.95:1

@czearing czearing merged commit 2c980c6 into microsoft:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants