Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(react-switch) - Adding MIGRATION.md #19734

Merged

Conversation

czearing
Copy link
Collaborator

@czearing czearing commented Sep 9, 2021

Pull request checklist

Description of changes

Adding a MIGRATION.md file to the converged Switch component and fixing a typo in the react-slider MIGRATION.md file.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-slider
Slider
30.481 kB
9.681 kB
react-switch
Switch
18.013 kB
6.167 kB
🤖 This report was generated against 2c980c60e3c332f678cc4a74c0e3051756191bac

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f4952f6:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 9, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2c980c60e3c332f678cc4a74c0e3051756191bac (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 889 911 5000
BaseButton mount 897 876 5000
Breadcrumb mount 2578 2617 1000
ButtonNext mount 428 433 5000
Checkbox mount 1474 1502 5000
CheckboxBase mount 1268 1281 5000
ChoiceGroup mount 4601 4711 5000
ComboBox mount 984 976 1000
CommandBar mount 10175 10152 1000
ContextualMenu mount 6497 6535 1000
DefaultButton mount 1085 1138 5000
DetailsRow mount 3733 3732 5000
DetailsRowFast mount 3798 3790 5000
DetailsRowNoStyles mount 3531 3600 5000
Dialog mount 2430 2451 1000
DocumentCardTitle mount 137 150 1000
Dropdown mount 3279 3270 5000
FluentProviderNext mount 7495 7580 5000
FluentProviderWithTheme mount 348 350 10
FluentProviderWithTheme virtual-rerender 93 94 10
FluentProviderWithTheme virtual-rerender-with-unmount 486 455 10
FocusTrapZone mount 1763 1828 5000
FocusZone mount 1814 1825 5000
IconButton mount 1895 1692 5000
Label mount 337 338 5000
Layer mount 2964 3067 5000
Link mount 466 440 5000
MakeStyles mount 1807 1807 50000
MenuButton mount 1462 1458 5000
MessageBar mount 1998 2058 5000
Nav mount 3215 3320 1000
OverflowSet mount 1132 1118 5000
Panel mount 2393 2398 1000
Persona mount 805 850 1000
Pivot mount 1427 1391 1000
PrimaryButton mount 1261 1281 5000
Rating mount 7597 7676 5000
SearchBox mount 1324 1331 5000
Shimmer mount 2495 2519 5000
Slider mount 1912 1973 5000
SpinButton mount 4994 5009 5000
Spinner mount 416 446 5000
SplitButton mount 3095 3048 5000
Stack mount 484 477 5000
StackWithIntrinsicChildren mount 1528 1568 5000
StackWithTextChildren mount 4424 4380 5000
SwatchColorPicker mount 10129 10176 5000
Tabs mount 1408 1397 1000
TagPicker mount 2610 2595 5000
TeachingBubble mount 13316 13229 5000
Text mount 406 417 5000
TextField mount 1364 1354 5000
ThemeProvider mount 1144 1178 5000
ThemeProvider virtual-rerender 605 569 5000
ThemeProvider virtual-rerender-with-unmount 1808 1851 5000
Toggle mount 796 772 5000
buttonNative mount 117 115 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AlertMinimalPerf.default 265 256 1.04:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
GridMinimalPerf.default 341 316 1.08:1
RefMinimalPerf.default 243 226 1.08:1
ButtonMinimalPerf.default 163 153 1.07:1
DividerMinimalPerf.default 359 337 1.07:1
FlexMinimalPerf.default 298 279 1.07:1
ImageMinimalPerf.default 370 345 1.07:1
IconMinimalPerf.default 603 564 1.07:1
FormMinimalPerf.default 399 380 1.05:1
SegmentMinimalPerf.default 348 330 1.05:1
AvatarMinimalPerf.default 186 179 1.04:1
RadioGroupMinimalPerf.default 441 425 1.04:1
AccordionMinimalPerf.default 147 143 1.03:1
ChatWithPopoverPerf.default 363 352 1.03:1
CheckboxMinimalPerf.default 2803 2717 1.03:1
LabelMinimalPerf.default 390 379 1.03:1
LayoutMinimalPerf.default 349 339 1.03:1
ProviderMinimalPerf.default 985 957 1.03:1
ToolbarMinimalPerf.default 923 893 1.03:1
BoxMinimalPerf.default 334 328 1.02:1
DropdownManyItemsPerf.default 656 644 1.02:1
HeaderSlotsPerf.default 740 722 1.02:1
MenuMinimalPerf.default 842 824 1.02:1
ProviderMergeThemesPerf.default 1664 1632 1.02:1
SliderMinimalPerf.default 1589 1564 1.02:1
SplitButtonMinimalPerf.default 4174 4098 1.02:1
StatusMinimalPerf.default 664 654 1.02:1
TreeWith60ListItems.default 169 166 1.02:1
ButtonOverridesMissPerf.default 1679 1666 1.01:1
ChatMinimalPerf.default 658 652 1.01:1
ListMinimalPerf.default 499 494 1.01:1
AttachmentSlotsPerf.default 1080 1077 1:1
CardMinimalPerf.default 524 523 1:1
DatepickerMinimalPerf.default 5279 5287 1:1
EmbedMinimalPerf.default 4121 4133 1:1
ListNestedPerf.default 560 559 1:1
MenuButtonMinimalPerf.default 1588 1590 1:1
TableMinimalPerf.default 390 390 1:1
CustomToolbarPrototype.default 3813 3828 1:1
AnimationMinimalPerf.default 399 404 0.99:1
AttachmentMinimalPerf.default 145 147 0.99:1
CarouselMinimalPerf.default 449 453 0.99:1
ChatDuplicateMessagesPerf.default 288 292 0.99:1
DialogMinimalPerf.default 734 739 0.99:1
DropdownMinimalPerf.default 3067 3095 0.99:1
InputMinimalPerf.default 1241 1249 0.99:1
RosterPerf.default 1150 1163 0.99:1
TableManyItemsPerf.default 1897 1911 0.99:1
TooltipMinimalPerf.default 1003 1015 0.99:1
ButtonSlotsPerf.default 560 570 0.98:1
PopupMinimalPerf.default 585 599 0.98:1
SkeletonMinimalPerf.default 342 350 0.98:1
TreeMinimalPerf.default 761 780 0.98:1
ItemLayoutMinimalPerf.default 1188 1224 0.97:1
ListCommonPerf.default 592 612 0.97:1
PortalMinimalPerf.default 166 172 0.97:1
TextMinimalPerf.default 321 331 0.97:1
ListWith60ListItems.default 601 628 0.96:1
VideoMinimalPerf.default 608 632 0.96:1
TextAreaMinimalPerf.default 476 503 0.95:1
LoaderMinimalPerf.default 651 698 0.93:1
ReactionMinimalPerf.default 370 403 0.92:1
HeaderMinimalPerf.default 338 372 0.91:1

@czearing czearing merged commit 9fcb642 into microsoft:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants