Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(react-switch) - Adding VR tests #19733

Merged

Conversation

czearing
Copy link
Collaborator

@czearing czearing commented Sep 9, 2021

Pull request checklist

Description of changes

Adding VR tests to the converged Switch component.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a6fdefb:

Sandbox Source
Fluent UI React Starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 9, 2021

📊 Bundle size report

🤖 This report was generated against 2c980c60e3c332f678cc4a74c0e3051756191bac

@size-auditor
Copy link

size-auditor bot commented Sep 9, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8ee2ef0e43ed910185760abd396a8656a5d840d5 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 9, 2021

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 901 903 5000
BaseButton mount 933 934 5000
Breadcrumb mount 2637 2669 1000
ButtonNext mount 468 461 5000
Checkbox mount 1491 1570 5000
CheckboxBase mount 1297 1271 5000
ChoiceGroup mount 4743 4810 5000
ComboBox mount 1017 1001 1000
CommandBar mount 10326 10344 1000
ContextualMenu mount 6644 6711 1000
DefaultButton mount 1143 1160 5000
DetailsRow mount 3789 3740 5000
DetailsRowFast mount 3764 3778 5000
DetailsRowNoStyles mount 3547 3540 5000
Dialog mount 2486 2463 1000
DocumentCardTitle mount 160 149 1000
Dropdown mount 3299 3297 5000
FluentProviderNext mount 7524 7554 5000
FluentProviderWithTheme mount 345 368 10
FluentProviderWithTheme virtual-rerender 90 105 10
FluentProviderWithTheme virtual-rerender-with-unmount 458 465 10
FocusTrapZone mount 1775 1793 5000
FocusZone mount 1830 1796 5000
IconButton mount 1758 1788 5000
Label mount 338 347 5000
Layer mount 2994 3072 5000
Link mount 458 465 5000
MakeStyles mount 1879 1903 50000
MenuButton mount 1479 1486 5000
MessageBar mount 2031 2013 5000
Nav mount 3346 3258 1000
OverflowSet mount 1139 1113 5000
Panel mount 2356 2360 1000
Persona mount 867 856 1000
Pivot mount 1429 1417 1000
PrimaryButton mount 1338 1332 5000
Rating mount 7663 7687 5000
SearchBox mount 1354 1330 5000
Shimmer mount 2534 2571 5000
Slider mount 1995 2009 5000
SpinButton mount 5065 5067 5000
Spinner mount 404 430 5000
SplitButton mount 3223 3170 5000
Stack mount 511 490 5000
StackWithIntrinsicChildren mount 1642 1647 5000
StackWithTextChildren mount 4612 4653 5000
SwatchColorPicker mount 10375 10366 5000
Tabs mount 1436 1418 1000
TagPicker mount 2621 2605 5000
TeachingBubble mount 13287 13276 5000
Text mount 429 435 5000
TextField mount 1401 1393 5000
ThemeProvider mount 1193 1187 5000
ThemeProvider virtual-rerender 611 600 5000
ThemeProvider virtual-rerender-with-unmount 1879 1882 5000
Toggle mount 846 815 5000
buttonNative mount 107 126 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 172 153 1.12:1
IconMinimalPerf.default 632 589 1.07:1
ButtonSlotsPerf.default 567 534 1.06:1
FormMinimalPerf.default 406 384 1.06:1
ImageMinimalPerf.default 384 363 1.06:1
PortalMinimalPerf.default 190 179 1.06:1
AlertMinimalPerf.default 274 260 1.05:1
LabelMinimalPerf.default 387 369 1.05:1
ListNestedPerf.default 553 530 1.04:1
MenuMinimalPerf.default 855 822 1.04:1
TreeWith60ListItems.default 177 171 1.04:1
DropdownManyItemsPerf.default 698 679 1.03:1
HeaderMinimalPerf.default 357 348 1.03:1
TooltipMinimalPerf.default 1067 1032 1.03:1
BoxMinimalPerf.default 346 340 1.02:1
ChatMinimalPerf.default 660 644 1.02:1
InputMinimalPerf.default 1318 1291 1.02:1
StatusMinimalPerf.default 684 673 1.02:1
TableManyItemsPerf.default 1904 1865 1.02:1
ButtonMinimalPerf.default 166 164 1.01:1
DatepickerMinimalPerf.default 5529 5496 1.01:1
DialogMinimalPerf.default 760 753 1.01:1
DropdownMinimalPerf.default 3187 3166 1.01:1
FlexMinimalPerf.default 287 284 1.01:1
GridMinimalPerf.default 330 326 1.01:1
ProviderMinimalPerf.default 1077 1063 1.01:1
RadioGroupMinimalPerf.default 455 451 1.01:1
RefMinimalPerf.default 236 233 1.01:1
SegmentMinimalPerf.default 351 349 1.01:1
SkeletonMinimalPerf.default 350 346 1.01:1
SplitButtonMinimalPerf.default 4279 4227 1.01:1
ToolbarMinimalPerf.default 926 913 1.01:1
TreeMinimalPerf.default 815 804 1.01:1
AvatarMinimalPerf.default 205 204 1:1
ButtonOverridesMissPerf.default 1748 1750 1:1
EmbedMinimalPerf.default 4244 4226 1:1
LayoutMinimalPerf.default 359 358 1:1
ListMinimalPerf.default 509 508 1:1
ListWith60ListItems.default 646 643 1:1
MenuButtonMinimalPerf.default 1667 1664 1:1
RosterPerf.default 1195 1197 1:1
PopupMinimalPerf.default 610 609 1:1
ProviderMergeThemesPerf.default 1758 1765 1:1
TableMinimalPerf.default 409 409 1:1
CustomToolbarPrototype.default 4088 4106 1:1
DividerMinimalPerf.default 359 363 0.99:1
HeaderSlotsPerf.default 743 748 0.99:1
ItemLayoutMinimalPerf.default 1202 1213 0.99:1
ReactionMinimalPerf.default 377 381 0.99:1
SliderMinimalPerf.default 1667 1686 0.99:1
VideoMinimalPerf.default 624 629 0.99:1
AttachmentSlotsPerf.default 1083 1103 0.98:1
CardMinimalPerf.default 546 557 0.98:1
ChatWithPopoverPerf.default 365 374 0.98:1
ListCommonPerf.default 620 632 0.98:1
TextAreaMinimalPerf.default 490 499 0.98:1
AnimationMinimalPerf.default 395 406 0.97:1
CarouselMinimalPerf.default 467 480 0.97:1
CheckboxMinimalPerf.default 2738 2815 0.97:1
TextMinimalPerf.default 338 347 0.97:1
AttachmentMinimalPerf.default 151 158 0.96:1
ChatDuplicateMessagesPerf.default 283 295 0.96:1
LoaderMinimalPerf.default 688 713 0.96:1

@czearing czearing closed this Sep 9, 2021
@czearing czearing reopened this Sep 9, 2021
@czearing czearing merged commit 64ec970 into microsoft:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants