This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[GH-15724] Remove usage of findDOMNode from Create Team screens #6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
the
Setup Cloud Test Server
hmhealey
approved these changes
Oct 5, 2020
jgilliam17
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Thank you @Jonany
Tested, looks good to merge.
- Verified Create Team screens - works as expected.
jgilliam17
added
4: Reviews Complete
|
Test server destroyed |
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Oct 6, 2020
…o MM-20462 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: [MM-22161] - Improve accessibility of channel switcher (mattermost#6199) [MM-20460] Migrate 'components/permissions_gates/channel_permission_gate' module and associated tests to TypeScript (mattermost#6601) [GH-15724] Remove usage of findDOMNode from Create Team screens (mattermost#6621) [MM-29302] Billing Summary Card - No Billing History case (mattermost#6639) /files should target=_blank (mattermost#6616) MM T134 visual verification of tooltips (mattermost#6604) MM-24812 Add e2e tests for adding reactions to existing reactions in archived channel posts (mattermost#6579) [MM-20490] Migrate 'components/post_view/combined_user_activity_post' module and associated tests to TypeScript (mattermost#6632) MM-24810 Add e2e for reactions for archived channel posts (mattermost#6562) [MM-28965] - Prevent link overlap in channel header (mattermost#6546) MM-28780: Migrate dotMenu string refs to functional ones (mattermost#6592) Cypress/E2E: Fix archived channel specs (mattermost#6617) Fixed cypress env for PostgreSQL connection (mattermost#6627) Migrate post_list_row component to typescript (mattermost#6593) Cypress/E2E: Fix managing bot accounts spec (mattermost#6614) Cypress/E2E: Stabilize profile popover spec (mattermost#6612) Migrated string refs in signup_email (mattermost#6602) Renaming diagnostics-to-telemetry (mattermost#5741)
amyblais
added
Changelog/Not Needed
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
* added tests for passing state to updateParent * changed display_name to use internal state instead of findDOMNode * changed team_utl to use internal state instead of findDOMNode * fixed style issues
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
* added tests for passing state to updateParent * changed display_name to use internal state instead of findDOMNode * changed team_utl to use internal state instead of findDOMNode * fixed style issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed usage of findDOMNode from Create Team screens.
Ticket Link
Fixes mattermost/mattermost#15724
Related Pull Requests
None.
Screenshots
None.