This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Renaming diagnostics-to-telemetry #5741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
commented
Jun 17, 2020
components/root/root.jsx
Outdated
| @@ -158,14 +158,14 @@ export default class Root extends React.PureComponent { | |||
| } | |||
|
|
|||
| const segmentKey = Constants.DIAGNOSTICS_SEGMENT_KEY; | |||
There was a problem hiding this comment.
I'm not renamign this constast because is a placeholder, but I don't know if we are changing this value somehow during the initialization.
There was a problem hiding this comment.
you can change it, but then you'll need to modify here as well to ensure new builds are properly managed
There was a problem hiding this comment.
I think the key is changed by the build process if I remember correctly, so we'd need to find where that's actually done.
jespino
commented
Jun 17, 2020
components/root/root.jsx
Outdated
| @@ -199,7 +199,7 @@ export default class Root extends React.PureComponent { | |||
| const rudderKey = Constants.DIAGNOSTICS_RUDDER_KEY; | |||
There was a problem hiding this comment.
Same about this constants.
jespino
added
2: Dev Review
Willyfrog
approved these changes
Jun 18, 2020
hmhealey
approved these changes
Jun 19, 2020
hmhealey
added
4: Reviews Complete
|
/update-branch |
|
Error trying to update the PR. |
|
/update-branch |
|
Error trying to update the PR. |
|
/update-branch |
|
Error trying to update the PR. |
prapti
approved these changes
Sep 30, 2020
prapti
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Oct 6, 2020
…o MM-20462 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: [MM-22161] - Improve accessibility of channel switcher (mattermost#6199) [MM-20460] Migrate 'components/permissions_gates/channel_permission_gate' module and associated tests to TypeScript (mattermost#6601) [GH-15724] Remove usage of findDOMNode from Create Team screens (mattermost#6621) [MM-29302] Billing Summary Card - No Billing History case (mattermost#6639) /files should target=_blank (mattermost#6616) MM T134 visual verification of tooltips (mattermost#6604) MM-24812 Add e2e tests for adding reactions to existing reactions in archived channel posts (mattermost#6579) [MM-20490] Migrate 'components/post_view/combined_user_activity_post' module and associated tests to TypeScript (mattermost#6632) MM-24810 Add e2e for reactions for archived channel posts (mattermost#6562) [MM-28965] - Prevent link overlap in channel header (mattermost#6546) MM-28780: Migrate dotMenu string refs to functional ones (mattermost#6592) Cypress/E2E: Fix archived channel specs (mattermost#6617) Fixed cypress env for PostgreSQL connection (mattermost#6627) Migrate post_list_row component to typescript (mattermost#6593) Cypress/E2E: Fix managing bot accounts spec (mattermost#6614) Cypress/E2E: Stabilize profile popover spec (mattermost#6612) Migrated string refs in signup_email (mattermost#6602) Renaming diagnostics-to-telemetry (mattermost#5741)
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
* Renaming diagnostics-to-telemetry * Fixing snapshots * Migrating new diagnostic terms * fix typo * Updating snapshot * Other small fix
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
* Renaming diagnostics-to-telemetry * Fixing snapshots * Migrating new diagnostic terms * fix typo * Updating snapshot * Other small fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renaming diagnostics-to-telemetry