This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[GH-15620] Migrated string refs in signup_email #6602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflog
suggested changes
Oct 1, 2020
There was a problem hiding this comment.
@varunks99 - thanks for you contribution!
Please run npm run fix to address linting issues.
Comment on lines
61
to
63
| this.email = React.createRef(); | ||
| this.name = React.createRef(); | ||
| this.password = React.createRef(); |
There was a problem hiding this comment.
Please rename to 'emailRef', 'nameRef', etc
There was a problem hiding this comment.
@reflog, I renamed the refs and fixed the linting issues.
varunks99
force-pushed
the
GH-15620_migrate_refs_signup_email
branch
from
9657da8 to
11b0c5e
Compare
Renamed refs Fixed linting issue
varunks99
force-pushed
the
GH-15620_migrate_refs_signup_email
branch
from
11b0c5e to
f2d9fd8
Compare
Willyfrog
added
3: QA Review
jgilliam17
added
the
Setup Cloud Test Server
jgilliam17
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Thank you @varunks99
Tested, looks good to merge.
- Verified email sign-up works es expected.
jgilliam17
added
4: Reviews Complete
|
Test server destroyed |
|
@reflog, If this looks good to you, would you mind merging? Thanks! |
Done |
amyblais
added
Changelog/Not Needed
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Oct 6, 2020
…o MM-20462 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: [MM-22161] - Improve accessibility of channel switcher (mattermost#6199) [MM-20460] Migrate 'components/permissions_gates/channel_permission_gate' module and associated tests to TypeScript (mattermost#6601) [GH-15724] Remove usage of findDOMNode from Create Team screens (mattermost#6621) [MM-29302] Billing Summary Card - No Billing History case (mattermost#6639) /files should target=_blank (mattermost#6616) MM T134 visual verification of tooltips (mattermost#6604) MM-24812 Add e2e tests for adding reactions to existing reactions in archived channel posts (mattermost#6579) [MM-20490] Migrate 'components/post_view/combined_user_activity_post' module and associated tests to TypeScript (mattermost#6632) MM-24810 Add e2e for reactions for archived channel posts (mattermost#6562) [MM-28965] - Prevent link overlap in channel header (mattermost#6546) MM-28780: Migrate dotMenu string refs to functional ones (mattermost#6592) Cypress/E2E: Fix archived channel specs (mattermost#6617) Fixed cypress env for PostgreSQL connection (mattermost#6627) Migrate post_list_row component to typescript (mattermost#6593) Cypress/E2E: Fix managing bot accounts spec (mattermost#6614) Cypress/E2E: Stabilize profile popover spec (mattermost#6612) Migrated string refs in signup_email (mattermost#6602) Renaming diagnostics-to-telemetry (mattermost#5741)
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
Renamed refs Fixed linting issue
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
Renamed refs Fixed linting issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request migrates all string-refs in ./components/signup/signupemail/signupemail.jsx to functional ones using the
createRefAPI.Ticket Link
https://mattermost.atlassian.net/browse/MM-29085
This fixes mattermost/mattermost#15620.