Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Fix archived channel specs #6617

Merged
merged 2 commits into from
Oct 5, 2020

Conversation

josephbaylon
Copy link
Contributor

Summary

  • Removed duplicate uiCreateChannel command
  • Updated uiCreateChannel to take in options
  • Updated channel.d.ts
  • Fixed createArchivedChannel params for archived_leave_channel_spec
  • Fixed archived_channels_2_spec to use original uiCreateChannel

Ticket Link

None - master only

Screen Shot 2020-10-02 at 1 42 53 PM
Screen Shot 2020-10-02 at 1 41 22 PM

@josephbaylon josephbaylon added the 3: QA Review Requires review by a QA tester label Oct 2, 2020
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all tests passed. Changes LGTM

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 5, 2020
@srkgupta srkgupta merged commit 2473625 into mattermost:master Oct 5, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 5, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 6, 2020
…o MM-20462

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp:
  [MM-22161] - Improve accessibility of channel switcher (mattermost#6199)
  [MM-20460] Migrate 'components/permissions_gates/channel_permission_gate' module and associated tests to TypeScript (mattermost#6601)
  [GH-15724] Remove usage of findDOMNode from Create Team screens (mattermost#6621)
  [MM-29302] Billing Summary Card - No Billing History case (mattermost#6639)
  /files should target=_blank (mattermost#6616)
  MM T134 visual verification of tooltips (mattermost#6604)
  MM-24812 Add e2e tests for adding reactions to existing reactions in archived channel posts (mattermost#6579)
  [MM-20490] Migrate 'components/post_view/combined_user_activity_post' module and associated tests to TypeScript (mattermost#6632)
  MM-24810 Add e2e for reactions for archived channel posts (mattermost#6562)
  [MM-28965] - Prevent link overlap in channel header (mattermost#6546)
  MM-28780: Migrate dotMenu string refs to functional ones (mattermost#6592)
  Cypress/E2E: Fix archived channel specs (mattermost#6617)
  Fixed cypress env for PostgreSQL connection (mattermost#6627)
  Migrate post_list_row component to typescript (mattermost#6593)
  Cypress/E2E: Fix managing bot accounts spec (mattermost#6614)
  Cypress/E2E: Stabilize profile popover spec (mattermost#6612)
  Migrated string refs in signup_email (mattermost#6602)
  Renaming diagnostics-to-telemetry (mattermost#5741)
@josephbaylon josephbaylon deleted the fix-archived-channel-specs branch October 7, 2020 22:03
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
* Cypress/E2E: Fix archived channel specs

* Fix lint
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
* Cypress/E2E: Fix archived channel specs

* Fix lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants