Merge apache 025b31c #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow id as a valid name for pylint * Re-enable pylint for superset/models/core.py * re-enable pylint for superset/models/sql_lab.py * re-enable pylint for superset/models/schedules.py * re-enable pylint for superset/models/helpers.py * re-enable pylint for superset/models/annotations.py * re-enable pylint on superset/models/tags.py * a couple more fixes after black formatting... * Add another inline pylint disable * Fix black * Move to inline disables for 'id' attribute on models * Fix lint disables after black reformatted them
* re-enable pylint for superset/views/tags.py * Re-enable pylint for superset/views/dashboard.py * Re-enable pylint for superset/views/sql_lab.py * Re-enable pylint for superset/views/datasource.py * Re-enable pylint for superset/views/utils.py * Re-enable pylint for superset/views/log/__init__.py * pylint fix * Improve naming
* Re-enable pylint for superset/jinja_context.py * Re-enable pylint for superset/sql_lab.py * Re-enable pylint for superset/sql_parse.py * Re-enable pylint for superset/exceptions.py * Re-enable lint for superset/translations/utils.py * Re-enable pylint for superset/views/schedules.py * Re-enable pylint for superset/views/base.py * Re-enable pylint for superset/views/log/views.py * Re-enable pylint for superset/views/annotations.py * black * PR feedback, pylint, isort fixes * Black, one more time... * Move ungrouped-imports to a global disable
* [dashboard] fix time granularity display values * fix review comments
* Require the SQLAlchemy URI when creating a database * Add migration to make dbs.sqlalchemy_uri not-nullable * Fixes for black, isort, tests * Alter migration to use current revision from master as downgrade target * Update tests to support new db constraint * black
* [fix] nullable booleans in dataframe * added comment
* feat: add user agent logging * fix: lint * fix: address feedback * fix: formatting
* fix: add default params to log * fix: add optional typing * fix: linting
* working! * sigh... linting. * more linting
* [superset] Slight performance improvement, remove SQLA first * [superset] Slight performance improvement, remove SQLA first * [superset] black it * [superset] Revert warm up cache change * [superset] Fix warm up cache slice_id may be none * [superset] Reverted changes of methods one by get * [superset] Reverted changes of methods one by get
khtruong
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging apache 025b31c into Lyft Master
@khtruong @DiggidyDave @betodealmeida