re-enable Pylint on a number of view files #8773
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8773 +/- ##
==========================================
- Coverage 72.07% 65.83% -6.24%
==========================================
Files 123 482 +359
Lines 12844 24154 +11310
Branches 0 2770 +2770
==========================================
+ Hits 9257 15902 +6645
- Misses 3587 8074 +4487
- Partials 0 178 +178
Continue to review full report at Codecov.
|
| @has_access_api | ||
| @expose("/", methods=["POST"]) | ||
| def post(self): | ||
| def post(self): # pylint: disable=no-self-use |
There was a problem hiding this comment.
That rule is pretty annoying, I get the whole "you should use @staticmethod", but it's shortsighted for derivative classes where the base offers a nice handle on the object.
I'd vote for turning it off.
There was a problem hiding this comment.
I think it's valuable outside of this context. As I was doing this work, I identified quite a few methods that could be refactored out of a large class into a stand-alone function. I'd like to keep the rule for those instances.
mistercrunch
added
🏷️ bot
CATEGORY
Choose one
SUMMARY
Re-enables pylint checking on a number of view files.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@john-bodley @dpgaspar @mistercrunch