Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable pylint for some model files #8770

Merged
merged 12 commits into from
Dec 10, 2019

Conversation

willbarrett
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@john-bodley @dpgaspar @mistercrunch

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #8770 into master will decrease coverage by 6.16%.
The diff coverage is 71.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8770      +/-   ##
=========================================
- Coverage   72.07%   65.9%   -6.17%     
=========================================
  Files         123     483     +360     
  Lines       12844   24166   +11322     
  Branches        0    2770    +2770     
=========================================
+ Hits         9257   15927    +6670     
- Misses       3587    8061    +4474     
- Partials        0     178     +178
Impacted Files Coverage Δ
superset/models/tags.py 58.58% <ø> (ø) ⬆️
superset/models/sql_lab.py 91.89% <100%> (+0.9%) ⬆️
superset/models/annotations.py 92% <100%> (ø) ⬆️
superset/models/schedules.py 88.88% <50%> (-2.03%) ⬇️
superset/models/core.py 83.09% <64.7%> (ø) ⬆️
superset/models/helpers.py 86.41% <81.25%> (+0.14%) ⬆️
superset/utils/cache.py 41.66% <0%> (-4.49%) ⬇️
superset/sql_validators/presto_db.py 82.43% <0%> (-2.08%) ⬇️
superset/stats_logger.py 74.41% <0%> (ø) ⬆️
superset/cli.py 37.19% <0%> (ø) ⬆️
... and 387 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665e947...f39cc1f. Read the comment docs.

.pylintrc Outdated Show resolved Hide resolved
@mistercrunch mistercrunch merged commit adf2cc2 into apache:master Dec 10, 2019
@mistercrunch mistercrunch deleted the wbarrett/pylint-models branch December 10, 2019 21:25
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants