Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move function in utils folder to fix circular import issues #8814

Merged
merged 2 commits into from
Dec 13, 2019

Conversation

willbarrett
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

A function in superset/utils/core.py had a circular import fix applied to it (required in utils/core due to it being depended on by the model layer) but it was only referenced in one place, in another utils file. Moving it to that file removes the need for the circular import fix.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@dpgaspar @craig-rueda

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #8814 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8814      +/-   ##
==========================================
+ Coverage   65.84%   65.88%   +0.03%     
==========================================
  Files         483      483              
  Lines       24177    24175       -2     
  Branches     2777     2777              
==========================================
+ Hits        15920    15928       +8     
+ Misses       8079     8069      -10     
  Partials      178      178
Impacted Files Coverage Δ
superset/utils/dashboard_import_export.py 58.97% <100%> (+28.53%) ⬆️
superset/utils/core.py 87.71% <100%> (-0.38%) ⬇️
superset/db_engine_specs/postgres.py 83.33% <0%> (+27.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed54f6e...d8d49f5. Read the comment docs.

@dpgaspar dpgaspar merged commit b87f21f into apache:master Dec 13, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants