refactor(app/outbound): forward-compatible test code #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
see linkerd/linkerd2#8733. Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
cratelyn
changed the title
Signed-off-by: katelyn martin <[email protected]>
Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/hyper-1.x-forward-compatible-tests-app-outbound
branch
from
073a027 to
95ed2b1
Compare
This was referenced Feb 27, 2025
olix0r
approved these changes
Feb 28, 2025
cratelyn
added a commit
that referenced
this pull request
Feb 28, 2025
see linkerd/linkerd2#8733 for more information. see #3559 and #3614 for more information on the `ForwardCompatibleBody<B>` wrapper. this branch updates test code in `linkerd-app-inbound` so that it interacts with request and response bodies via an adapter that polls for frames in a manner consistent with the 1.0 api of `http_body`. this allows us to limit the diff in #3504, which will only need to remove this adapter once using hyper 1.0. see #3672 and #3673, which perform the same change for `linkerd-app-outbound` and `linkerd-app-integration`, respectively. --- * refactor(app/inbound): `linkerd-http-body-compat` test dependency Signed-off-by: katelyn martin <[email protected]> * refactor(app/inbound): use `ForwardCompatibleBody` see linkerd/linkerd2#8733. Signed-off-by: katelyn martin <[email protected]> --------- Signed-off-by: katelyn martin <[email protected]>
cratelyn
deleted the
kate/hyper-1.x-forward-compatible-tests-app-outbound
branch
cratelyn
added a commit
that referenced
this pull request
Feb 28, 2025
see linkerd/linkerd2#8733 for more information. see #3559 and #3614 for more information on the `ForwardCompatibleBody<B>` wrapper. this branch updates test code in `linkerd-app-integration` so that it interacts with request and response bodies via an adapter that polls for frames in a manner consistent with the 1.0 api of `http_body`. this allows us to limit the diff in #3504, which will only need to remove this adapter once using hyper 1.0. see #3671 and #3672, which perform the same change for `linkerd-app-inbound` and `linkerd-app-outbound`, respectively. --- * chore(app/integration): `linkerd-http-body-compat` test dependency Signed-off-by: katelyn martin <[email protected]> * refactor(app/integration): generalize `hyper::Body` Signed-off-by: katelyn martin <[email protected]> * refactor(app/integration): use `ForwardCompatibleBody` Signed-off-by: katelyn martin <[email protected]> --------- Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Feb 28, 2025
see linkerd/linkerd2#8733 for more information. see #3559 and #3614 for more information on the `ForwardCompatibleBody<B>` wrapper. this branch updates test code in `linkerd-app-outbound` related to timeouts so that it interacts with request and response bodies via an adapter that polls for frames in a manner consistent with the 1.0 api of `http_body`. this allows us to limit the diff in #3504, which will only need to remove this adapter once using hyper 1.0. see #3671, #3672, and #3673, which performed the same change for `linkerd-app-inbound`, other code in `linkerd-app-outbound`, and `linkerd-app-integration`, respectively. Signed-off-by: katelyn martin <[email protected]>
This was referenced Feb 28, 2025
cratelyn
added a commit
that referenced
this pull request
Feb 28, 2025
see linkerd/linkerd2#8733 for more information. see #3559 and #3614 for more information on the `ForwardCompatibleBody<B>` wrapper. this branch updates test code in `linkerd-app-outbound` related to timeouts so that it interacts with request and response bodies via an adapter that polls for frames in a manner consistent with the 1.0 api of `http_body`. this allows us to limit the diff in #3504, which will only need to remove this adapter once using hyper 1.0. see #3671, #3672, and #3673, which performed the same change for `linkerd-app-inbound`, other code in `linkerd-app-outbound`, and `linkerd-app-integration`, respectively. Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Mar 4, 2025
see linkerd/linkerd2#8733 for more information. see #3559 and #3614 for more information on the `ForwardCompatibleBody<B>` wrapper. `telemetry::log_stream::collect_logs` is a function responsible for digesting a streaming body, and deserializing each chunk into a `serde_json::Value`, until either (a) a shutdown signal is received, or (b) the end of the body is reached. this commit updates test code in `linkerd-app-integration` so that it interacts with request and response bodies via an adapter that polls for frames in a manner consistent with the 1.0 api of `http_body`. this allows us to limit the diff in #3504, which will only need to remove this adapter once using hyper 1.0. * linkerd/linkerd2#8733 * #3671 * #3672 * #3673 * #3676 Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Mar 4, 2025
see linkerd/linkerd2#8733 for more information. see #3559 and #3614 for more information on the `ForwardCompatibleBody<B>` wrapper. `telemetry::log_stream::collect_logs` is a function responsible for digesting a streaming body, and deserializing each chunk into a `serde_json::Value`, until either (a) a shutdown signal is received, or (b) the end of the body is reached. this commit updates test code in `linkerd-app-integration` so that it interacts with request and response bodies via an adapter that polls for frames in a manner consistent with the 1.0 api of `http_body`. this allows us to limit the diff in #3504, which will only need to remove this adapter once using hyper 1.0. * linkerd/linkerd2#8733 * #3671 * #3672 * #3673 * #3676 Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Mar 4, 2025
see linkerd/linkerd2#8733 for more information. see #3559 and #3614 for more information on the `ForwardCompatibleBody<B>` wrapper. `telemetry::log_stream::collect_logs` is a function responsible for digesting a streaming body, and deserializing each chunk into a `serde_json::Value`, until either (a) a shutdown signal is received, or (b) the end of the body is reached. this commit updates test code in `linkerd-app-integration` so that it interacts with request and response bodies via an adapter that polls for frames in a manner consistent with the 1.0 api of `http_body`. this allows us to limit the diff in #3504, which will only need to remove this adapter once using hyper 1.0. * linkerd/linkerd2#8733 * #3671 * #3672 * #3673 * #3676 Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Mar 10, 2025
note: this commit will not compile, code changes are intentionally elided from this commit. this commit upgrades hyper, http, tonic, prost, related dependencies, and their assorted cargo features. see <linkerd/linkerd2#8733>. see also: * #3379 * #3380 * #3382 * #3405 * hyperium/hyper#3796 * #3411 * #3421 * #3427 * #3428 * #3432 * #3433 * #3444 * #3445 * #3454 * #3455 * #3456 * #3457 * #3461 * #3459 * #3465 * #3466 * #3467 * #3468 * linkerd/linkerd2-proxy-api#421 * linkerd/linkerd2#13492 * linkerd/linkerd2#13493 * hyperium/hyper#3816 * #3472 * #3473 * #3479 * tokio-rs/tokio#7059 * #3509 * hyperium/http-body#140 * #3515 * hyperium/http-body#141 * #3530 * #3531 * #3540 * #3556 * #3558 * #3559 * #3564 * #3567 * #3573 * #3583 * hyperium/http-body#144 * #3585 * #3586 * #3597 * #3598 * #3611 * #3614 * #3615 * #3616 * #3647 * #3651 * #3653 * #3654 * #3655 * #3656 * #3657 * #3660 * #3671 * #3672 * #3673 * #3676 * hyperium/http-body#147 * #3692 * #3699 * #3700 * #3701 * #3708 * linkerd/drain-rs#36 * #3715 * #3717 * eminence/procfs#340 --- squash: chore(deps): add hyper-util workspace dependency chore(deps): add http-body-util workspace dependency chore(deps): upgrade linkerd2-proxy-api this commit represents main as of linkerd/linkerd2-proxy-api#421. Signed-off-by: katelyn martin <[email protected]>
cratelyn
added a commit
that referenced
this pull request
Mar 11, 2025
note: this commit will not compile, code changes are intentionally elided from this commit. this commit upgrades hyper, http, tonic, prost, related dependencies, and their assorted cargo features. see <linkerd/linkerd2#8733>. see also: * #3379 * #3380 * #3382 * #3405 * hyperium/hyper#3796 * #3411 * #3421 * #3427 * #3428 * #3432 * #3433 * #3444 * #3445 * #3454 * #3455 * #3456 * #3457 * #3461 * #3459 * #3465 * #3466 * #3467 * #3468 * linkerd/linkerd2-proxy-api#421 * linkerd/linkerd2#13492 * linkerd/linkerd2#13493 * hyperium/hyper#3816 * #3472 * #3473 * #3479 * tokio-rs/tokio#7059 * #3509 * hyperium/http-body#140 * #3515 * hyperium/http-body#141 * #3530 * #3531 * #3540 * #3556 * #3558 * #3559 * #3564 * #3567 * #3573 * #3583 * hyperium/http-body#144 * #3585 * #3586 * #3597 * #3598 * #3611 * #3614 * #3615 * #3616 * #3647 * #3651 * #3653 * #3654 * #3655 * #3656 * #3657 * #3660 * #3671 * #3672 * #3673 * #3676 * hyperium/http-body#147 * #3692 * #3699 * #3700 * #3701 * #3708 * linkerd/drain-rs#36 * #3715 * #3717 * eminence/procfs#340 --- squash: chore(deps): add hyper-util workspace dependency chore(deps): add http-body-util workspace dependency chore(deps): upgrade linkerd2-proxy-api this commit represents main as of linkerd/linkerd2-proxy-api#421. Signed-off-by: katelyn martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see linkerd/linkerd2#8733 for more information.
see #3559 and #3614 for more information on the
ForwardCompatibleBody<B>wrapper.this branch updates test code in
linkerd-app-outboundso that it interacts with request and response bodies via an adapter that polls for frames in a manner consistent with the 1.0 api ofhttp_body.this allows us to limit the diff in #3504, which will only need to remove this adapter once using hyper 1.0.
see #3671 and #3673, which perform the same change for
linkerd-app-inboundandlinkerd-app-integration, respectively.