Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(app/trace-collector): remove Default bounds #3651

Merged
merged 1 commit into from
Feb 25, 2025
Merged

chore(app/trace-collector): remove Default bounds #3651

merged 1 commit into from
Feb 25, 2025

Conversation

cratelyn
Copy link
Collaborator

see linkerd/linkerd2#8733 for more information.

in hyper 1.x, Incoming bodies do not provide a Default implementation. compare the trait implementations here:

this commit removes these bounds from the
linkerd_app::trace_collector::otel_collector::SpanExporter<T, S> and other connected functions.

@cratelyn
chore(app/trace_collector): remove Default bounds
ab737de 
see linkerd/linkerd2#8733 for more information.

in hyper 1.x, `Incoming` bodies do not provide a `Default`
implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes these bounds from the
`linkerd_app::trace_collector::otel_collector::SpanExporter<T, S>` and
other connected functions.

Signed-off-by: katelyn martin <[email protected]>
@cratelyn cratelyn mentioned this pull request Feb 25, 2025
Open
@cratelyn cratelyn marked this pull request as ready for review February 25, 2025 19:44
@cratelyn cratelyn requested a review from a team as a code owner February 25, 2025 19:44
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(proxy/identity-client): remove Default bounds
82ba897 
linkerd/linkerd2#8733 for more information.

see also, #3651 for
another related pull request.

in hyper 1.x, `Incoming` bodies do not provide a `Default`
implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes these bounds from
`linkerd_proxy_identity_client::Certify<C, S>`.

Signed-off-by: katelyn martin <[email protected]>
@cratelyn cratelyn mentioned this pull request Feb 25, 2025
Merged
@cratelyn cratelyn changed the title chore(app/trace_collector): remove Default bounds chore(app/trace-collector): remove Default bounds Feb 25, 2025
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(app/inbound): remove Default bounds
7673074 
see linkerd/linkerd2#8733 for more information.

see also, #3651 and #3653 for some related pull requests.

in hyper 1.x, `Incoming` bodies do not provide a `Default`
implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes `Default` bounds from policy lookup in the inbound
proxy.

Signed-off-by: katelyn martin <[email protected]>
@cratelyn cratelyn mentioned this pull request Feb 25, 2025
Merged
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(app/inbound): remove Default bounds
f66ca52 
see linkerd/linkerd2#8733 for more information.

see also, #3651 #3653, and #3654 for some related pull requests.

in hyper 1.x, `Incoming` bodies do not provide a `Default` implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes `Default` bounds from policy lookup in the outbound
proxy. this means that in `linkerd-app`, we can invoke
`Outbound::build_policies()` when using hyper 1.x (_see #3504_)

Signed-off-by: katelyn martin <[email protected]>
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(app/outbound): remove Default bounds
eb311c4 
see linkerd/linkerd2#8733 for more information.

see also, #3651 #3653, and #3654 for some related pull requests.

in hyper 1.x, `Incoming` bodies do not provide a `Default` implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes `Default` bounds from policy lookup in the outbound
proxy. this means that in `linkerd-app`, we can invoke
`Outbound::build_policies()` when using hyper 1.x (_see #3504_)

Signed-off-by: katelyn martin <[email protected]>
@cratelyn cratelyn mentioned this pull request Feb 25, 2025
Merged
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(proxy/api-resolve): remove Default bounds
9af770a 
see linkerd/linkerd2#8733 for more information.

see also, #3651 #3653, and #3654 for some related pull requests.

in hyper 1.x, `Incoming` bodies do not provide a `Default`
implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes `Default` bounds from `Resolve<S>`.

this means that in `linkerd-app`, we can invoke
`new_recover_default()` when using hyper 1.x (_see #3504_)

Signed-off-by: katelyn martin <[email protected]>
@cratelyn cratelyn mentioned this pull request Feb 25, 2025
Merged
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(service-profiles): remove Default bounds
f7a4345 
see linkerd/linkerd2#8733 for more
information.

see also, #3651 #3653, #3654, and #3655 for some related pull requests.

in hyper 1.x, `Incoming` bodies do not provide a `Default`
implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes `Default` bounds from `Client<R, S>` used to create
watches on service profiles.

Signed-off-by: katelyn martin <[email protected]>
@cratelyn cratelyn mentioned this pull request Feb 25, 2025
Merged
@cratelyn cratelyn merged commit 5ee4f71 into main Feb 25, 2025
15 checks passed
@cratelyn cratelyn deleted the kate/hyper-1.x-loosen-trace-collector-body-default-bounds branch February 25, 2025 21:00
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(app/inbound): remove Default bounds (#3654)
1a12be5 
see linkerd/linkerd2#8733 for more information.

see also, #3651 and #3653 for some related pull requests.

in hyper 1.x, `Incoming` bodies do not provide a `Default`
implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes `Default` bounds from policy lookup in the inbound
proxy.

Signed-off-by: katelyn martin <[email protected]>
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(app/outbound): remove Default bounds (#3655)
09a0c0f 
see linkerd/linkerd2#8733 for more information.

see also, #3651 #3653, and #3654 for some related pull requests.

in hyper 1.x, `Incoming` bodies do not provide a `Default` implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes `Default` bounds from policy lookup in the outbound
proxy. this means that in `linkerd-app`, we can invoke
`Outbound::build_policies()` when using hyper 1.x (_see #3504_)

Signed-off-by: katelyn martin <[email protected]>
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(proxy/api-resolve): remove Default bounds (#3656)
f054e54 
see linkerd/linkerd2#8733 for more information.

see also, #3651 #3653, and #3654 for some related pull requests.

in hyper 1.x, `Incoming` bodies do not provide a `Default`
implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes `Default` bounds from `Resolve<S>`.

this means that in `linkerd-app`, we can invoke
`new_recover_default()` when using hyper 1.x (_see #3504_)

Signed-off-by: katelyn martin <[email protected]>
cratelyn added a commit that referenced this pull request Feb 25, 2025
@cratelyn
chore(service-profiles): remove Default bounds (#3657)
4df3d57 
see linkerd/linkerd2#8733 for more
information.

see also, #3651 #3653, #3654, and #3655 for some related pull requests.

in hyper 1.x, `Incoming` bodies do not provide a `Default`
implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes `Default` bounds from `Client<R, S>` used to create
watches on service profiles.

Signed-off-by: katelyn martin <[email protected]>
cratelyn added a commit that referenced this pull request Feb 26, 2025
@cratelyn
chore(proxy/identity-client): remove Default bounds (#3653)
8daafde 
linkerd/linkerd2#8733 for more information.

see also, #3651 for
another related pull request.

in hyper 1.x, `Incoming` bodies do not provide a `Default`
implementation. compare the trait implementations here:

* https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body
* https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations

this commit removes these bounds from
`linkerd_proxy_identity_client::Certify<C, S>`.

Signed-off-by: katelyn martin <[email protected]>
This was referenced Feb 26, 2025
Open
Merged
cratelyn added a commit that referenced this pull request Feb 26, 2025
@cratelyn
chore(app/trace-collector): remove Default bound (#3660)
5945c92 
see #3651 and linkerd/linkerd2#8733.

#3651 missed this unused trait bound, which we want to loosen
to account for changes in hyper's api.

Signed-off-by: katelyn martin <[email protected]>
cratelyn added a commit that referenced this pull request Mar 10, 2025
@cratelyn
chore(deps): upgrade to hyper 1.x
0a8c4a5 
note: this commit will not compile, code changes are intentionally
elided from this commit.

this commit upgrades hyper, http, tonic, prost, related dependencies,
and their assorted cargo features.

see <linkerd/linkerd2#8733>.

see also:

* #3379
* #3380
* #3382
* #3405
* hyperium/hyper#3796
* #3411
* #3421
* #3427
* #3428
* #3432
* #3433
* #3444
* #3445
* #3454
* #3455
* #3456
* #3457
* #3461
* #3459
* #3465
* #3466
* #3467
* #3468
* linkerd/linkerd2-proxy-api#421
* linkerd/linkerd2#13492
* linkerd/linkerd2#13493
* hyperium/hyper#3816
* #3472
* #3473
* #3479
* tokio-rs/tokio#7059
* #3509
* hyperium/http-body#140
* #3515
* hyperium/http-body#141
* #3530
* #3531
* #3540
* #3556
* #3558
* #3559
* #3564
* #3567
* #3573
* #3583
* hyperium/http-body#144
* #3585
* #3586
* #3597
* #3598
* #3611
* #3614
* #3615
* #3616
* #3647
* #3651
* #3653
* #3654
* #3655
* #3656
* #3657
* #3660
* #3671
* #3672
* #3673
* #3676
* hyperium/http-body#147
* #3692
* #3699
* #3700
* #3701
* #3708
* linkerd/drain-rs#36
* #3715
* #3717
* eminence/procfs#340

---

squash:

chore(deps): add hyper-util workspace dependency

chore(deps): add http-body-util workspace dependency

chore(deps): upgrade linkerd2-proxy-api

this commit represents main as of linkerd/linkerd2-proxy-api#421.

Signed-off-by: katelyn martin <[email protected]>
cratelyn added a commit that referenced this pull request Mar 11, 2025
@cratelyn
chore(deps): upgrade to hyper 1.x
b6af8db 
note: this commit will not compile, code changes are intentionally
elided from this commit.

this commit upgrades hyper, http, tonic, prost, related dependencies,
and their assorted cargo features.

see <linkerd/linkerd2#8733>.

see also:

* #3379
* #3380
* #3382
* #3405
* hyperium/hyper#3796
* #3411
* #3421
* #3427
* #3428
* #3432
* #3433
* #3444
* #3445
* #3454
* #3455
* #3456
* #3457
* #3461
* #3459
* #3465
* #3466
* #3467
* #3468
* linkerd/linkerd2-proxy-api#421
* linkerd/linkerd2#13492
* linkerd/linkerd2#13493
* hyperium/hyper#3816
* #3472
* #3473
* #3479
* tokio-rs/tokio#7059
* #3509
* hyperium/http-body#140
* #3515
* hyperium/http-body#141
* #3530
* #3531
* #3540
* #3556
* #3558
* #3559
* #3564
* #3567
* #3573
* #3583
* hyperium/http-body#144
* #3585
* #3586
* #3597
* #3598
* #3611
* #3614
* #3615
* #3616
* #3647
* #3651
* #3653
* #3654
* #3655
* #3656
* #3657
* #3660
* #3671
* #3672
* #3673
* #3676
* hyperium/http-body#147
* #3692
* #3699
* #3700
* #3701
* #3708
* linkerd/drain-rs#36
* #3715
* #3717
* eminence/procfs#340

---

squash:

chore(deps): add hyper-util workspace dependency

chore(deps): add http-body-util workspace dependency

chore(deps): upgrade linkerd2-proxy-api

this commit represents main as of linkerd/linkerd2-proxy-api#421.

Signed-off-by: katelyn martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olix0r olix0r olix0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cratelyn @olix0r