chore(service-profiles): remove `Default` bounds #3657

cratelyn · 2025-02-25T20:39:32Z

see linkerd/linkerd2#8733 for more information.

see also, #3651 #3653, #3654, and #3655 for some related pull requests.

in hyper 1.x, Incoming bodies do not provide a Default implementation. compare the trait implementations here:

this commit removes Default bounds from Client<R, S> used to create watches on service profiles.

see linkerd/linkerd2#8733 for more information. see also, #3651 #3653, #3654, and #3655 for some related pull requests. in hyper 1.x, `Incoming` bodies do not provide a `Default` implementation. compare the trait implementations here: * https://docs.rs/hyper/0.14.31/hyper/body/struct.Body.html#impl-Default-for-Body * https://docs.rs/hyper/latest/hyper/body/struct.Incoming.html#trait-implementations this commit removes `Default` bounds from `Client<R, S>` used to create watches on service profiles. Signed-off-by: katelyn martin <[email protected]>

note: this commit will not compile, code changes are intentionally elided from this commit. this commit upgrades hyper, http, tonic, prost, related dependencies, and their assorted cargo features. see <linkerd/linkerd2#8733>. see also: * #3379 * #3380 * #3382 * #3405 * hyperium/hyper#3796 * #3411 * #3421 * #3427 * #3428 * #3432 * #3433 * #3444 * #3445 * #3454 * #3455 * #3456 * #3457 * #3461 * #3459 * #3465 * #3466 * #3467 * #3468 * linkerd/linkerd2-proxy-api#421 * linkerd/linkerd2#13492 * linkerd/linkerd2#13493 * hyperium/hyper#3816 * #3472 * #3473 * #3479 * tokio-rs/tokio#7059 * #3509 * hyperium/http-body#140 * #3515 * hyperium/http-body#141 * #3530 * #3531 * #3540 * #3556 * #3558 * #3559 * #3564 * #3567 * #3573 * #3583 * hyperium/http-body#144 * #3585 * #3586 * #3597 * #3598 * #3611 * #3614 * #3615 * #3616 * #3647 * #3651 * #3653 * #3654 * #3655 * #3656 * #3657 * #3660 * #3671 * #3672 * #3673 * #3676 * hyperium/http-body#147 * #3692 * #3699 * #3700 * #3701 * #3708 * linkerd/drain-rs#36 * #3715 * #3717 * eminence/procfs#340 --- squash: chore(deps): add hyper-util workspace dependency chore(deps): add http-body-util workspace dependency chore(deps): upgrade linkerd2-proxy-api this commit represents main as of linkerd/linkerd2-proxy-api#421. Signed-off-by: katelyn martin <[email protected]>

cratelyn mentioned this pull request Feb 25, 2025

proxy: Figure out the plan for Hyper 1.0 migration linkerd/linkerd2#8733

Open

cratelyn marked this pull request as ready for review February 25, 2025 20:45

cratelyn requested a review from a team as a code owner February 25, 2025 20:45

olix0r approved these changes Feb 25, 2025

View reviewed changes

cratelyn merged commit 4df3d57 into main Feb 25, 2025
15 checks passed

cratelyn deleted the kate/hyper-1.x-service-profiles-loosen-body-default-bounds branch February 25, 2025 21:01

cratelyn mentioned this pull request Feb 26, 2025

chore(deps)!: upgrade to hyper 1.x #3504

Open

Provide feedback