Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cache): enable partial cache in downstream projects #21238

Open
wants to merge 194 commits into
base: eugster/cache_cleanup_merge_all
Choose a base branch
from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Jan 29, 2025

Add features to cache and cleanup code:


Follow-up PR:

Notes:

Completed:

Open in Gitpod

@joneugster joneugster added WIP Work in progress t-meta Tactics, attributes or user commands CI Modifies the continuous integration / deployment setup labels Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

PR summary bf24f6145a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ HashMemo.filterByRootModules
+ isFromMathlib
+ isInLeanCore
+ isPartOfMathlibCache
+ parseArgs
- HashMemo.filterByFilePaths
- PackageDirs
- getPackageDirs
- isPathFromMathlib
- toPaths

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joneugster joneugster changed the title refactor(Cache): cleanup cache feat(Cache): enable partial cache in downstream projects Jan 30, 2025
@joneugster joneugster removed the WIP Work in progress label Jan 31, 2025
@joneugster joneugster marked this pull request as ready for review January 31, 2025 03:59
@joneugster joneugster force-pushed the eugster/cache_cleanup_merge_all branch from 969581a to 9cb6b37 Compare February 13, 2025 18:15
@joneugster joneugster changed the base branch from eugster/cache_cleanup_merge_all to eugster/cache_pseudo_module_args February 13, 2025 19:35
@joneugster joneugster changed the base branch from eugster/cache_pseudo_module_args to eugster/cache_cleanup_merge_all February 13, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) CI Modifies the continuous integration / deployment setup t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants