-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Cache): enable partial cache in downstream projects #21238
Open
joneugster
wants to merge
194
commits into
eugster/cache_cleanup_merge_all
Choose a base branch
from
eugster/cache_cleanup
base: eugster/cache_cleanup_merge_all
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(Cache): enable partial cache in downstream projects #21238
joneugster
wants to merge
194
commits into
eugster/cache_cleanup_merge_all
from
eugster/cache_cleanup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary bf24f6145aImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
1 task
kim-em
reviewed
Jan 30, 2025
kim-em
reviewed
Jan 30, 2025
kim-em
reviewed
Jan 30, 2025
kim-em
reviewed
Jan 30, 2025
kim-em
reviewed
Jan 30, 2025
kim-em
reviewed
Jan 30, 2025
This reverts commit dc09cdc.
Co-authored-by: Kim Morrison <[email protected]>
…er/cache_cleanup_merge_all
…he_cleanup_merge_all
969581a
to
9cb6b37
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked-by-other-PR
This PR depends on another PR to Mathlib (this label is automatically managed by a bot)
CI
Modifies the continuous integration / deployment setup
t-meta
Tactics, attributes or user commands
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add features to
cache
and cleanup code:lake exe cache get MyProject.Basic
downloads only the relevant cache to buildMyProject/Basic.lean
Mathlib/Init.lean
and modulesMathlib.Init
likewisefeat(Cache): extend argument-parsing to allow module names, file names and directory names #21822
Mathlib/Data
orMathlib.Data
and does a directory walk to find all.lean
files thereinfeat(Cache): extend argument-parsing to allow module names, file names and directory names #21822,
feat(Cache): Allow arguments of the form
Mathlib.Data
which correspond to a folder but not a file #21838[Merged by Bors] - fix(Cache): error on import loop #21632
refactor(Cache): use module name as key instead of unresolved file path #21834
lake_manifest.json
, use the Lean search path fromLEAN_SRC_PATH
instead.[Merged by Bors] - refactor(Cache): use the Lean search path instead of lake-manifest to determine Mathlib root. #21666
Lean.findLean
chore(Cache): remove unused hardcoded package directories #21818
getFileImports
to use search path and return module names and source file location #21815Mathlib.Data
which correspond to a folder but not a file #21838Follow-up PR:
Notes:
miniget
command, a minimal version ofget
#20568Completed:
depends on: feat(Cache): add fileCache.Lean
with helper functions and cleanupcheckForToolchainMismatch
#21663cache lookup
help #21701CacheM.Context
#21703default
#21707HashMemo
#21711Cache.Lean
#21816