Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Cache): stylistic change to not use default #21707

Closed
wants to merge 2 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Feb 11, 2025

Purely stylistic change based on the docstring of default:

[…] This element does not have any particular specified properties, […]


Open in Gitpod

@joneugster joneugster added easy < 20s of review time. See the lifecycle page for guidelines. t-meta Tactics, attributes or user commands labels Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

PR summary aef2795518

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

depsMap : Std.HashMap FilePath (Array FilePath) := {}
cache : Std.HashMap FilePath (Option UInt64) := {}
hashMap : HashMap := {}
depsMap : Std.HashMap FilePath (Array FilePath) := ∅
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're using this as \emptyset is a nicer syntax for an empty set. Fair point, that's something I can get by with.

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@adomani
Copy link
Collaborator

adomani commented Feb 11, 2025

Same as the previous one, although I do not expect this to cause any issues. Anyway, could you merge once the other pieces are working together well?

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 11, 2025

✌️ joneugster can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 11, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 11, 2025
@joneugster
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 11, 2025
Purely stylistic change based on the docstring of `default`:

> […] This element does not have any particular specified properties, […]
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 11, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Cache): stylistic change to not use default [Merged by Bors] - chore(Cache): stylistic change to not use default Feb 11, 2025
@mathlib-bors mathlib-bors bot closed this Feb 11, 2025
@mathlib-bors mathlib-bors bot deleted the eugster/cache_cleanup_do_not_use_default branch February 11, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants