-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Cache): stylistic change to not use default
#21707
Conversation
PR summary aef2795518Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
maintainer merge
depsMap : Std.HashMap FilePath (Array FilePath) := {} | ||
cache : Std.HashMap FilePath (Option UInt64) := {} | ||
hashMap : HashMap := {} | ||
depsMap : Std.HashMap FilePath (Array FilePath) := ∅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're using this as \emptyset is a nicer syntax for an empty set. Fair point, that's something I can get by with.
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Same as the previous one, although I do not expect this to cause any issues. Anyway, could you merge once the other pieces are working together well? Thanks! bors d+ |
✌️ joneugster can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
Pull request successfully merged into master. Build succeeded: |
default
default
Purely stylistic change based on the docstring of
default
: