Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Cache): use module name for file hash instead of non-resolved file path #21842

Open
wants to merge 1 commit into
base: eugster/cache_cleanup
Choose a base branch
from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Feb 13, 2025

This invalidates cache once, similarly to when the lean-toolchain gets bumped or the lakefile modified.


Open in Gitpod

@joneugster joneugster added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) t-meta Tactics, attributes or user commands CI Modifies the continuous integration / deployment setup WIP Work in progress labels Feb 13, 2025
Copy link

github-actions bot commented Feb 13, 2025

PR summary cf75039c83

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ HashMemo.filterByRootModules
+ Lean.Name.fromComponents
+ findWithExtBase
+ isFromMathlib
+ isInLeanCore
+ isPartOfMathlibCache
+ parseArgs
- HashMemo.filterByFilePaths
- PackageDirs
- getPackageDirs
- isPathFromMathlib
- toPaths

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@joneugster joneugster changed the base branch from master to eugster/cache_cleanup February 13, 2025 18:46
@mathlib4-dependent-issues-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 13, 2025
@joneugster joneugster changed the title refactor(Cache): cleanup some parts of cache which result in cache invalidation. refactor(Cache): use module name for file hash instead of non-resolved file path Feb 13, 2025
@joneugster joneugster force-pushed the eugster/cache_cleanup_invalidate branch from 39a2e44 to cf75039 Compare February 13, 2025 20:52
@joneugster joneugster removed the WIP Work in progress label Feb 13, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) CI Modifies the continuous integration / deployment setup t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants