-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - doc(Cache/Hashing): add docstring for HashMemo
#21711
Conversation
joneugster
commented
Feb 11, 2025
PR summary e88a97b477Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
This reverts commit bc050ab.
Co-authored-by: Eric Wieser <[email protected]>
Cache/Hashing.lean
Outdated
depsMap : Std.HashMap FilePath (Array FilePath) := ∅ | ||
/-- | ||
For modules in Mathlib or upstream, this contains the same information | ||
as `hashMap`. Contains `none` if a source file couldn't be found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it none
only for source files not in mathlib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the docstring. Files downstream will fall into the latter category, but not necessarily exclusively.
E.g. if you'll write import Mathlib.Data
in another mathlib file and try to get cache, this file will have none
as Mathlib/Data.lean
doesn't exist. (meaning no cache will be retrieved for the file with bad import)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Thanks!
✌️ joneugster can now approve this pull request. To approve and merge a pull request, simply reply with |
bors r+ |
Pull request successfully merged into master. Build succeeded: |
HashMemo
HashMemo